From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253A7C4345F for ; Mon, 15 Apr 2024 18:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D31C6B009B; Mon, 15 Apr 2024 14:48:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783966B009D; Mon, 15 Apr 2024 14:48:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D5E56B009E; Mon, 15 Apr 2024 14:48:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3EE586B009B for ; Mon, 15 Apr 2024 14:48:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E8943C0783 for ; Mon, 15 Apr 2024 18:48:04 +0000 (UTC) X-FDA: 82012650888.10.54CD80F Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 7B5F3180013 for ; Mon, 15 Apr 2024 18:48:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aMh34gPU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Llg1fPbk; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf16.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713206881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5nJgjV7pn4of70HqbYdz0++BxXaE04QtKFzC6NQOpkY=; b=cEaV04fFvh70RF8QrNToxizrSUzr7s4jVDK2o32xnnCc/odYFNoNxijDpLpHrIjWSzaucg SzcDkeGt1ZYIfhfb83ixcT6UTsdnoHqtSwP590AQC7dcQjX97WstxihRRniMVzVwIICzOS TlNBgByktsJTUCZC1SaDVJd+dForbMY= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aMh34gPU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Llg1fPbk; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf16.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713206881; a=rsa-sha256; cv=pass; b=sqQQSNP7r4NNekcPu5VZqB/gw2qYeYPDdqwslh2FUhOKN6pZT7DqFC+Vh0aOz1BshLkCJ9 RdAYrc1X3B2Pg9YDzuQ8Zr7f1n3uRv5hnaajYCSzNwiM/WznPAdWLJKCCFJfpV/WGF4+qH iVO/d7um2TmlqP9yR8MA4yCqZcjiWAk= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43FIlQNG015342; Mon, 15 Apr 2024 18:47:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=5nJgjV7pn4of70HqbYdz0++BxXaE04QtKFzC6NQOpkY=; b=aMh34gPUSTit6sJIF+VZp3jCMzAeax+Vs9le7PuCmEyZuKHDBvAP7iFoc0k/7CaM7b8T NBOGB3lN1N5ZKZi+5yLfvNvu8XCdCUSwlaCXzcuksf98NCMJQUkKAwlUoOEQnumSYpA3 I9I1ZBP/SoqcOMA0/oU/i7eWx636H4PaG02FrwGkv9sAH8SsmvhyIXUnv+x779wKk53K Lih+6BBk5D+Uc4olBP+4yTCCswHb02kdyOX/aW4t8hCbOQmEuFR3/uPv+kWOJXHc1SYp H65hY3DN7q4YTaoYfI2DPTN+bHinFZfaE9p5/Cs+RBIxUBPud701+JbzL+jTlIkHrTaO 9w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfjkv3fcs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2024 18:47:43 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43FIWAxl028683; Mon, 15 Apr 2024 18:47:43 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2040.outbound.protection.outlook.com [104.47.57.40]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xfgg66cht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Apr 2024 18:47:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1bIc2sVU3j+yUtgugRdwPWugfYk9qxMBLdbPlTVK8qirOzL2/7z9vNIJuZiz399XTxlvvDtS0+NJ8CK4nDAuWUuY8QS7CwdrH80wp8M2dAvA6XwHURaAw2zgO7B73fb+BdtxvQNrHJeAGxYm1V5uFCvsPrv2Kq+F+JIa0P1+UAe1Zkf66LQjowr+V4GUtgWHSB1K8/l4GHjYmkjmzQv6lhh8xi+fdKWHZ0ycSgF3FZ5Dootd1YB3EEGVjOwInd57wssqQglJCzE5l9MgdikpH9+QvkhLkgfEfP72jLragq3iii8D9uxgX3glwiAp8uXCCc3bAeEviHVva3tcsOJnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5nJgjV7pn4of70HqbYdz0++BxXaE04QtKFzC6NQOpkY=; b=oAN8E/xd3uyhS8ClBvve14FcSLG9k+zWXzrL9OGIKojuSjCUHhYMHkPC0toLTG3GOpMFhLuJAGKXPXtx97Mxy9+2+yP4QlUoelRzoyq3RcNXARjaywbLcWnwh7qk6Yse/CP/HEfyYzhGpVx2AjF/UC3Z7OCphB0U16hAceT9jC8SmH9HIYNC3VQCR1RQEddvLykKW1iDdk/lpypsU2NfcYlExTgY39IueJyoweSYcHscjqJfsMxFB53Rx3EsWTMDiljYbAkUIndtTtcXDJp4o1efpKaVwP9WIwTiQcQBVgxO3j5fMOoHwBz3DEQDPzoUA0X/q4aO8QIXj+amUktdSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5nJgjV7pn4of70HqbYdz0++BxXaE04QtKFzC6NQOpkY=; b=Llg1fPbkUP0JdGsRV9zOMVWNf1RxBFDbqzXnZcvfiCPGhF8MznmEgWISJ26tKM1euqkenzxpmgYD2YxuB377ifykAm0Wmnn1FSPlo8DludvJKUBDhYmOsFaX/mVZIjT6MY7hhT0iHAH7AW4/FCPPUK9evNO+BCK2GYFqZ/6yPBU= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CY8PR10MB7218.namprd10.prod.outlook.com (2603:10b6:930:76::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 18:47:40 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 18:47:40 +0000 Message-ID: <3fef3bba-80e7-4a3c-9e9b-a2fce8391c51@oracle.com> Date: Mon, 15 Apr 2024 11:47:39 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/11] mm/memory-failure: Convert memory_failure() to use a folio To: Matthew Wilcox , Miaohe Lin Cc: Oscar Salvador , linux-mm@kvack.org, Jane Chu References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-8-willy@infradead.org> <2cc02f91-fbca-4160-9f31-bfb54f882f08@oracle.com> <1677b7a8-179d-4e4f-a7f3-5d6244586cdb@oracle.com> Content-Language: en-US From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR08CA0038.namprd08.prod.outlook.com (2603:10b6:a03:117::15) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CY8PR10MB7218:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b7d432b-3072-4edb-0ec6-08dc5d7c8744 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q7eOMZ6cna0FHvCX2lAyGn6SAAUuyoW7OwN+7FwyN7BCzZMWEZGQ1aycmeAZJemnAID8KxEnHpy++Yj8iQiC+OWFQLk3ggIIKb5gTOvugIcvEh3+W5wfMCylmgg53ybBWCxAIokykl40hnzBrmPGl2P33DDWCmddDLmUZ22mVhiWTZYT/ih48DjjlKgvnRBI/SARtPCodyxT932jDNhp03P0xWZNvkdmoi727W4SMsWonG+mWE0LWX4dwJbkTDbVwVvvcuv29jMCbGvs8IeRiwBBM/0aXjIssF6g0cxUcq1itI9FJr63HIQFFB7uI/BR25b9MjqP3k1icvOdg14Qsu0gcoh/IoT1d2iJtYGTe3P7U79IKuoY64yclJGw3CzXTGU2v6nYDiLJBaUD5L9YM5Tch0OFDdFNbMU5mXpZxxVfFOyA/5uT4PqZtVIA/TvpcQz9ScmZUzPaAQ9hjGbYvABi4M0RIrNwk+sMtmOrSswRdcVENWmk5Ssuk3lkIEQAR/NjDSs6SaRRY1niG/7QsxuBT1napTC7gIw2yIv07vNfKKdQ60cOatB00BEtV0nFv5+vsLZO093XlObFO0Ghcj1PtlcDT6R66oMjdgwz0yGQFTzATsn25J4nGOCPwgyasYTwAuRFd6YtTG4/bwB203WSAcZfaHdUPh4nKfCzwHc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0tXUXUvRzdSVHJSbmxBRzFxVVpoOFptS2w2bWlrQStCWmNvVC9PczhlTk1n?= =?utf-8?B?eDFpMHBVVTg3UElvbUpIRGhyQ0V3K1RSd2dpYm9GTlR0Z2RoWGpjSjNOd2Iy?= =?utf-8?B?MXRvK3JySDNsRVRkaWJ3cmFzbHhMc3BwWVE5elFRU1ZRcG44cnNrZ0FxWkdo?= =?utf-8?B?UW9IaWx3RTRTbzBjYk1MVnA1Nlh4MFJqbHZ0bUM3TkdTQW5naDN4dVBEdVNL?= =?utf-8?B?YWM0RWNHZ0ZGd3BpL0JFbkR0S2tMcnhDNTByZ3hHb0NISm8vZk1EL1Z0cE43?= =?utf-8?B?WXVlejNhV1RoKzdGcExFRFNUaUlRNjJrVmI2UHg3d0dBRmhnR2Zma1VoSkxj?= =?utf-8?B?VXN3MUpsNklvQmI4MkZKRllLUjhtQnlZaUI4T3QxWnlQYklpckxlamlibzVD?= =?utf-8?B?ZGZvczlDcnlUOGxTU3ZmdmMrUTRMbHJoS1JJY3ZvY2tVUE5QSlcrUE0vY3p5?= =?utf-8?B?cFpNOUxsY1hYbU93ZTdQWHB6dzEvQitPY3BUY1BMRmg3NHI5NVZTV0xxRFFv?= =?utf-8?B?OWJZM2N5Yy9ESE5XS3ZLeG1kemovR2lxdGJMaGcrMSsrTmNvZSs5cmJ5ZE9v?= =?utf-8?B?UzV4RUlIemlzUUhCeXNQbGxZNEc5ajRpeGhhVGptODZNYzc3QmthVDdaRUto?= =?utf-8?B?ZUp4cXlidi9RYWY3TmQzWGlObXpxM0wvMWNVT3lPS2NqZ2RhQTVqRFVrWDht?= =?utf-8?B?bDk4Z3VRbk1va0NJbzkwYUhDUmJleGM2UVBtcnl6QkNJd01HZ2hQNUdLNEI0?= =?utf-8?B?ZUZjUlRxRUdZK09CSVNPL3lYRWgrdVRyaGdkdVZONElNOTh1ajhGYkdMMi92?= =?utf-8?B?aHMrb3lhQzg5V1Rpc2IrTXBoNUEwY0liNlRFU3ZlU2tlbUpDUGFJT1A3dnlH?= =?utf-8?B?L0FSVy9GbGs0VXFGODB4ZTdLRjc1cnpNL1pEUjVMY0RPb0Z6WWlZSXRNSHk1?= =?utf-8?B?V05BS3Noc0VoNVFtOEJFK0VvRFlsRlhxdklEMFM5UWExR1VacUF6SlNwd0w4?= =?utf-8?B?d09WOE1ZWU9DME1zeDJ1czJQQlYwKzBMN2NoQmdZTlNVUUxxMTFhOWpqWTB6?= =?utf-8?B?TTJsZ0JPZkZtLzVYYXkwcHpWZW1YQk54MVNOd3BLZWE3ZmRTd0FzUGlWQ0gw?= =?utf-8?B?dU5zUUpLMkpFNllsTEdlMWZrUkpXL0U1dWhUZ0tQQXVGOHpodG5EdUhKUDE4?= =?utf-8?B?UTk3OHdLV1NTQVkyMkgwcU5mQUg4Z3BFSXBLTlBFSjdic1ZYVTF2STgxemM4?= =?utf-8?B?dFhPWGxLa3lnTU52eHNxOXkxQnpKV3Q3bkRPOHp5V3dnVHFhUXhPdzlwemNU?= =?utf-8?B?ak9DN2xyUWZYaVd5a2g4QUZXLzZqVDV4cmFlVjZMZVdYZHNEZWt0L0R4Y1hB?= =?utf-8?B?S0JQYUFRTTdvQ3hESU9QVlprSHg5QW1ZSEhhQW1MU3V6aEt4MmFRR1ZHRFpJ?= =?utf-8?B?ZkM3OUlpMGxJeFh0MGxRWW81NW9FRGw4UjhHUWhETmJCN21Fc3JtdXFWL0VY?= =?utf-8?B?ZTdzNk9ZMStTSHk1bmw5d1I0WGx4a2IwY2xPWnRoMzRwZklxVFRsd0VDQTMz?= =?utf-8?B?OWdKL1p4bUVsRHVncDRpQUl0Q3lEaUlaYmF6OWwrbDhPYW0xdFZFSlk2VlIy?= =?utf-8?B?WUNRQ1hZTERWcHNhZzVXUDUzN1NjS2xabmptWFZZQWNDS3BvL2VBQmNaWFdi?= =?utf-8?B?blBWelNrck1iZ3M4UEhPMEJYWC9xNmVoZnF1WHI1RkhmVDdtckVTNEJmVkxs?= =?utf-8?B?ZEgzMzFmZXdOa2drU1ZJR0s2TnZMN3Fqbm1DRVR0STBjV0krRU84dXgrdWMy?= =?utf-8?B?ZlVldmNpSUloSDF6T0FIZG5UdFQ3OCtualQzN3JXZzJ5NzR5Vi95U1NURzJu?= =?utf-8?B?azN6R1IxWVJnMzFUYy9pa2RZbDNTUFZFa2R4Y0g3ZEQva2tENnRpL2I4eW9X?= =?utf-8?B?alAzZWF5M2ZydnErdmgvY2pmR3hodHp6S1lCSVFHMm1TeE8yakw2OGR0T1kz?= =?utf-8?B?S2hTNkYzZ1NiZDZ2ZVgrY3VYdnYwRWxnS1FCQU5OQkRnSmtBelptZnd0WWI2?= =?utf-8?B?czhFc2tSbkhYK3JOWVRJV1dPTU1mU1FJQ0VJNzdMWXV0YVF4YmY0Nzd1WnF4?= =?utf-8?Q?WHRMrRmX4ru+hLxjZIcEIlhHM?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kq5A6x9+ZzmyXBTIL8coEYaPooMByaqvyoKeYr1NmfFOhF3oLnF1QRVcWXk5Fo5vR1Y8yQOCIy3MZc2xdqyfQiNQMVLrCnH3Cp6kPzH4SuzHR1+0h+cSA7poA0xCaPcfea6F0Qn9Chp5OnYTKKjGwmHA2YyMJ5miWp+UAgQ9GeDJawUaRDty5VF8LzSz/0+QitqlAIScF87c2aNz9/c98yno26NbHhk1yNRFQWCu1HnaLV+gl5wmJ4d3ERv6uR3Q/7SexAmkX+nxu6zefIeES5UUOXLaYZ/sksL+NZfLH8jRctpIvx0UuaTDRBlttprW3hC2RiQnm+v7RH/ggkOsiBTKukNtx+QM+bxBRBSv9U27ao3s+bJPFeLIVtIoYO2cVPRnUeMSteZuDnBxACEpBM3uQR7AInpGtYBUL3b75JRZKp/s8F8/lgiRyzRGkURKN0KsTdqIX4mcyNQ5tyQbRFoGe2GrPN7M+Seot7++YkT4MzEjHpUwba3suY0mUWcUwawenoi8RduioLdwSJnR0LSVOh2CLpkOSbYNbTTsRyd20ZEFiRUARpUupDSUDLtV9gjgTraN5QEhtQMC4JwogbKFYpzKZQQfnGyz66+/lNk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7d432b-3072-4edb-0ec6-08dc5d7c8744 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 18:47:40.8511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J2hMjEcJ6NffNWXs8Wyd+MUifNUdPfJWZKERStjj2KAoro20rKyyRyG46baZjnrkV/R26M+jgR5H6jy5iV42Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7218 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-15_16,2024-04-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404150124 X-Proofpoint-ORIG-GUID: o4Iz4RvNlcxRa2AlKpUphMU8jSDfFoIg X-Proofpoint-GUID: o4Iz4RvNlcxRa2AlKpUphMU8jSDfFoIg X-Rspamd-Queue-Id: 7B5F3180013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: se84rgr1psp9xhrpy3njj8zkcf6cs5r6 X-HE-Tag: 1713206881-703207 X-HE-Meta: U2FsdGVkX1+qIAmlBaHte2YnvgJTHv9996Wlu8JuURsCJzw+yU6drEyO7439EiPOazXlTNjhMt7bCfnDDPgtcdYb4xP8t/6lUxvkh9L9B8WKQoQDcUjq7P+Z2MtXhI+Am9oxJVzCp9NQ0CVbH+XEM+C4fFiiEd/OFYlcB6jWeZ7TmCu6F4aX/ZLmRbuGOmRFImtTE5GaCDi81mycv29CSgJi9B4QNapPW8DR0qm00wBcZX514LQDoDDyezMR0o0w4BUTNYO77hmU6FmPpEkXvCxFveD6tPZ2JYUmUATEezGo5+OSTYOVEqJCZImsxkPs3Tx7ipwRDVDqR1vA+Vcbe5SV8JCl9RPjs3QykNS2n6dJvIIm1Udx4k+aPVxhCgdBGloOG9QnmHHzrq7nZIe/0UdY6WfNQ8xDiVq3j10rv0W//4fOAZNbvJF2u8PNPk7qz/wkc8PjoUj05de0PBwKmxh8qSipBwgZny/fJ7sLZvDDDtVBo8p7UtRtpsUXKefat2t/Hor+UxiLH9hcK7OVHSbhyxDIZmz8OhMnnOpXRP/8JmM9QeeHRXI9cTj15O8eI0UevcOebApq+F+9f1sIeKcZSPxrdSCG144qoFVF1/AJp0I4RCcKgBP5Xgf88R9Brwk9v1Aef44vifJHpEUmh2NK5JXGwp2w/7YU4M24UvHxMIn798YcXHmYWUDrgNnMbmZe3x0F6m9Fwxec8vQnFTgdiM1unxbBhKRUmSSprPalCpMv1G7wKioZONGGrC6AM4qfoBqh43CKPJ7rbzAttcnZrTGeY+3hYgLxd9DUaulLsFovsO3Fo8yAxf5mlmwrGbm+eiccN6ecY42RyKsfH53t26/cVBX21Pm5Exg1Ggayxc/E1adwreCO5NxoONElBYviQ2De79c5+3BDxo5opWScxViRwoAhkBe4G6dTHVsJU2uWpQUpnZGOGm0SgyKp/R3XexXJFw8DM27laLq gYLpkdwQ zP5QY54Qk2niqUwg7U8eOIxdKQAdFLXql7+dLa6oZMZseQ7Ai1dpB/mMZsuaBMGDy/5ejVnJ7SkvtIBK3bUoN1sRoenzCe9NKz4jIzXcdzR/c0UBHlJhiplKwXzhJ90zE8ux6Qnjg/4SEOiI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/12/2024 12:48 PM, Matthew Wilcox wrote: > On Thu, Apr 11, 2024 at 05:00:33PM +0800, Miaohe Lin wrote: >> But as code changes, the above page lock shift is gone. And I think below logic can't >> trigger now. As we hold extra page refcnt so page can't be coallesced into a new THP or Slab page. >> >> /* >> * We're only intended to deal with the non-Compound page here. >> * However, the page could have changed compound pages due to >> * race window. If this happens, we could try again to hopefully >> * handle the page next round. >> */ >> if (PageCompound(p)) { >> if (retry) { >> ClearPageHWPoison(p); >> unlock_page(p); >> put_page(p); >> flags &= ~MF_COUNT_INCREASED; >> retry = false; >> goto try_again; >> } >> res = action_result(pfn, MF_MSG_DIFFERENT_COMPOUND, MF_IGNORED); >> goto unlock_page; >> } >> >> So it might be better to replace above code block as WARN_ON(PageCompound(p)) and remove MF_MSG_DIFFERENT_COMPOUND case. >> Any thoughts? > Yes, I think you're right. As the MM handling of pages has evolved, > people haven't kept memory-failure uptodate. That's both understandable > and regrettable. > > I don't have the time to focus on memory-failure myself; I have a couple > of hundred uses of page->mapping to eliminate. And I'd want to get a > lot more serious about testing before starting on that journey. > > I do have ideas for handling hwpoison without splitting a folio. > I'd also really like to improve memory-failure to handle sub-page-size > blast radius (Intel CXL used to have a blast radius of 256 bytes). > But realistically, these things are never going to rise high enough on > my todo list to actually get done. Yeah, glad to have the issue identified, that's progress. I'm working on a series dealing with handling hwpoison without splitting a THP, will post it for comments. thanks, -jane