Re: [BENCHMARKS] Namesys VM patches improve kbuild

Nikita Danilov
2004-01-30T12:00:48Z

Andrew Morton writes:
> Nick Piggin <piggin@cyberone.com.au> wrote:
> >
> > Hi Nikita,
> >
> > Just having a look at your patch. I think maybe this array
> > should be in a seperate cacheline per node?
> >
> > +/* dummy pages used to scan active lists */
> > +static struct page scan_pages[MAX_NUMNODES][MAX_NR_ZONES];
> > +
>
> You really want it a member of `struct zone', don't you?
>
> That'll cause include dependency hell, so maybe a page* in struct zone.

I don't quite understand:

struct zone {

....

/*
* dummy page used as place holder during scanning of
* active_list in refill_inactive_zone()
*/
struct page *scan_page;

....

};

is already here. Array scan_pages[][] contains struct pages to which
zone->scan_page's point to. Yes, I didn't embed struct page into struct
zone exactly due to dependencies problems.

>
>

Nikita.