Re: [PATCH 1/5] mm improvements

Nick Piggin
2004-02-09T07:00:18Z

Rik van Riel wrote:

> On Wed, 4 Feb 2004, Nick Piggin wrote:
>
>> > 1/5: vm-no-rss-limit.patch
>> > Remove broken RSS limiting. Simple problem, Rik is onto it.
>> >
>
>
> Does the patch below fix the performance problem with the
> rss limit patch ?
>
>

Sorry I missed this Rik. The rsslimit patch is now too old
to apply to the mm tree because of one of my patches.

To fix this you need to be able to check rsslimit before
clearing referenced bits, and possibly not clear referenced
bit at all.

Its obviously inefficient to do to check ptes twice, so probably
just doing it once would be OK, you'd just need to do something
like:

if (referenced && dont_clear_referenced)
SetPageReferenced(page);

at the end.