From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE01E77198 for ; Tue, 7 Jan 2025 10:16:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A8F06B00AD; Tue, 7 Jan 2025 05:16:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 832066B00C5; Tue, 7 Jan 2025 05:16:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65DF96B00C6; Tue, 7 Jan 2025 05:16:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C73F6B00C5 for ; Tue, 7 Jan 2025 05:16:01 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DE8ECA0818 for ; Tue, 7 Jan 2025 10:16:00 +0000 (UTC) X-FDA: 82980250080.12.DC6497D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 4F0EC18000B for ; Tue, 7 Jan 2025 10:15:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fQFWNDLy; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736244958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U1Tyags7KUo/2iWrdBFB7FhTvuR7pSasRgI7K4kz2G8=; b=1EEejegQS17m1Nq7MkF09Md/pwZaKetI+qXQw7BtUUim0nQItRvJMBL0znRJTqSR7tzXBT ptt8jAq/RoepaBFf8hZTHFw8vdbBGcjtzuqrEo2AcVHoWoD7Kxw8YHJNCp1YPPjUbXGagi 1cwC7pU4mDpoJXgAgeiC+uy40j3FVyI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fQFWNDLy; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736244958; a=rsa-sha256; cv=none; b=SgcXNKISn9PRHZKkVVuJPPqvK2AAmqGPGMHgaHFuzfTGzshUyZTPqGDs/WgfLgHqFCXHr9 2cMUomqC8hmbnCsq2l6mP4qFycYC94tkNthx+iIZq2/04FW9xRGJ22wXZjTo/8rZfAYVvn XXgo802Y+RqJOsXHIeM4qMEQqL8cQHE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736244957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U1Tyags7KUo/2iWrdBFB7FhTvuR7pSasRgI7K4kz2G8=; b=fQFWNDLy3lCgVfBPTQ67OUgsgWZP9Euzjcu1Y6La2FZsBoiIdAVpELXewjGDc30Vo0SBWd AQhTXkjmxfGvfIdnN5rV4Cg6GpXISxNH1c/DSggzKqXN3G+fdszwCfo9esKHNEryZb/MZz C91yjc/0A2zifHYVxUw6t0YFoYylgFw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-oV_27E48MWSw8G5qC4CcyA-1; Tue, 07 Jan 2025 05:15:56 -0500 X-MC-Unique: oV_27E48MWSw8G5qC4CcyA-1 X-Mimecast-MFC-AGG-ID: oV_27E48MWSw8G5qC4CcyA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so120971205e9.3 for ; Tue, 07 Jan 2025 02:15:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736244955; x=1736849755; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U1Tyags7KUo/2iWrdBFB7FhTvuR7pSasRgI7K4kz2G8=; b=OSn1m468mj1H7y3JPssn9z4FxWa1Dx7Dwxex5L1Klf3I3munb96eQw1hkAu93bhGGs EW60qTJBU2YNQGs6z/QMI2K4+MTi1XI/mhMMVl+QYSmY5PicUmtOTThmvx9DKnrCP03R hFwt5QXoGXu4N9+NGb1MXP7h6CwJdSaFa/GhRGrDqzeGz3O8mbVncnSc7x6LonvBkH1v sNrUxdAtZNVUB/TyeufnQOIOjny5bvZhSVzOjajhza2y5yCItCT+7rv2Z7jfrrsQ8RPP 3w3rU8wdvSuOoG1ml4Mo2J1+pZjML0aEYk9mEPPy9gHdsfTOBr7ElWvXUX/h7WRqFHOf 2m6A== X-Forwarded-Encrypted: i=1; AJvYcCWS9yvwEUsh1IpTIF/2ya1cod0L4409jS9unx2+JorMJWnm2oI3YwPJYNU5TTDj4sY0Ney5cMxUhw==@kvack.org X-Gm-Message-State: AOJu0YzC02+7BEV9pizOLlE7XY+LjzQf2ZNRgaoYzqFRNBdHTCBnViq6 PHf624UM5OhTWC71qJQ/OYjOnP63QVjex6ya0CVkIYI4pBkFjVfhidu1f9VSF5YO0x0xsD+ODfk dG8nOZ9tN1ukvBLYc2KcGan8WIgmu8s40x/Y5It40X2yh/TjPJImRfyCg X-Gm-Gg: ASbGncv/H3dT47C4edwsFGcf9Bjcav/cF1wlh+RtWgK9Vd/xgfhRdzoWfsaj5CklcBG KnrMyevQBui4U6aOTPxEFH7LRPZuPWO+P5ZVXL/bmDivbVa6e6dLpUHpRGN8YIjiL0RhauxOdcx J0KMxWumup+i4byc9BgLmM6qCjNT05DgEdsfeUggjyMq+Jrt/5X/aThbzPTNC1YxR8rOcavLaPI rXvLKf2vSynOm0XCKBLP/cyZWpIB+QS29czWbG6/IfB6zrQLvmnTufy59Reu81NBeNZpGUp1Zq6 ZteLuxeQxsLt7fKlthoerF7cO2E3lIt+lIRI1vlpZfXI5NTllAo7UP5G9z+TLJ8iuTLVqircpGl XiSfGfP5t X-Received: by 2002:a05:600c:3b86:b0:435:21a1:b109 with SMTP id 5b1f17b1804b1-43668452e59mr474842345e9.2.1736244955269; Tue, 07 Jan 2025 02:15:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFY45QbhzGnDkzPzmxdYqW1I0knbOXj4b8Jxx/4y/S/jPE9Y3tv3S41GLjtE3NZb06BGP6Pww== X-Received: by 2002:a05:600c:3b86:b0:435:21a1:b109 with SMTP id 5b1f17b1804b1-43668452e59mr474842125e9.2.1736244954882; Tue, 07 Jan 2025 02:15:54 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8a8d3dsm49569030f8f.94.2025.01.07.02.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 02:15:53 -0800 (PST) Message-ID: <40951175-01df-49bf-9dbe-29fbdd114aed@redhat.com> Date: Tue, 7 Jan 2025 11:15:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/memory: simplify outputting of valid_zones_show() To: Shiyang Ruan , linux-mm@kvack.org, osalvador@suse.de, rafael@kernel.org References: <20250107100941.1169222-1-ruansy.fnst@fujitsu.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250107100941.1169222-1-ruansy.fnst@fujitsu.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pTlgYfC2fxw79HXydVZEdh6P5RSgTMPW7bF1yTi3ozM_1736244955 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4F0EC18000B X-Rspam-User: X-Stat-Signature: xq4i6dea1jpj9fa117yscnx19qxnbfum X-HE-Tag: 1736244958-593359 X-HE-Meta: U2FsdGVkX195bIM4vWe9AtYNrLDcPWPC/PJw4oTiWAg8YapiIBH27TITZLHI4IE/LOV0aF0pMu2UpJ/OGz6eAQ/JU8tREdptwZeun2nFg2CQ22osM2l/J7o8/Xn9vR8mE5R/Nlw3LQNQiID8WXLhY7QgpLrbs5V0jHXWyDsfLvY6QbDYP67NkSrXkcJnaA4IEnWXruMhu1COIoYKbNw2c2acIJsZ1x71P6RZLZ8+cG5JohNHzRbIY7eGlxBjCHx/MQBU5tYcVwLNhZ0ilXRl/ZyGr16xgmg1BUx2mtdEw9eejoo8fucnI+c0dy77spPHbpUflt30z9WRjf0vWJ/ctM8VxGR9Xqe1U8INhlpYv3hUE9Z8lILBvTB0WHxUhEGfFpF2F2DshcGPueSSjVBvWDyToF5s9ua0C/UMPvcx124gLItpveTqgcCw++TalVbu3LlKsdPTBAU4YtK7lFjx4ZjUjk0+tVap5R3iubQECoV2gdOG9fPk8N3RXm+ckgXm88beNUtV+ww5e83z9suU08K4Aiqg0umY6gD5LU9HftTBPLcUvTKKW8hGiZjkCvTHjAuc9iNvsmM9c9oGBb3v/1s+rFmTt4HChfB3FuLJwyzynKDOdDnYiost8pV0JtHfPq7We1ghol/KlVlz0IG2zD/BVXNNKgRlBS8cCOxkiodrpxNvkHvrnD51pRtl7AGRQkNp3qZK41LKsUkeywkqR7xn1QQi3ExF5DmR0rERnNL2H9YxBzUiFVrSqG9TsUM+fgD6Sk4ZTvuLQtWPrswFNCZ9sxjoVyFCbG1QhcNPneXJoVY6r20F5yjmQpe1PR5dA/mlmAjtCtgejQHx23ZbAoQiQZVafEbH1vZ91O2Kct+sQF4n9sMQDP0q+l3Sf2u5KCNw4P5UU0XP0dQwFws0SlzRamHN1i6nD5jH8WKJuSWdZWR6/FhEFjXXVNAFDpDUaPrlt/pwJzFNLrc+J0p a2CRz7da WzwIfUfhlgWcNSLxhYpQBzOj5Q9nQ41ylXFXVFLQvD31Z/5jBWMrhgU/p/BisUkoZ7gh5FPU3lXsizbWvVkmJx08DNfC2benRl87AIRdQZkIepgjlLzxGQaVluFA2lOOjRzbZh87VPIxy3ualqMhnjVHPFF2CRSF7TZfAjPurEBgrAgYB84/alOqBUCPgvoZWMIJIqSqS7rfa6KrEVqYwiNltIAEVv568bA2tuUx6T2JDFTPtB9v4OiJVy4rfmltidx2zTz+pIY5SrXCVts6fzg8XULUx9jCrbrtVQyOF1QrVYpAQj9FSqJX5NHy58xZYNti4wabToBFk4THu9Q0eT66gQxDx/Bpuf+1F0Xge26ijOLHu223o0SRO12FbciR+Su5DV57AnKx4zKGguPodmMhtzg9BVeOciiWGmuxYlLDOPKueVP26fV2+ZxTqdTJHOR+hda1naxwzovqbWEkW9rshrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.056049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 11:09, Shiyang Ruan wrote: > No need to specific position at the first writing to the buf because the > @len is always 0 at this time. Use sysfs_emit() instead to simplify it. > > Signed-off-by: Shiyang Ruan > --- > drivers/base/memory.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 67858eeb92ed..d77a83c9af39 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -469,19 +469,17 @@ static ssize_t valid_zones_show(struct device *dev, > default_zone = mem->zone; > if (!default_zone) > return sysfs_emit(buf, "%s\n", "none"); > - len += sysfs_emit_at(buf, len, "%s", default_zone->name); > - goto out; > + return sysfs_emit(buf, "%s\n", default_zone->name); We can go one step further and do: return sysfs_emit(buf, "%s\n", mem->zone ? mem->zone->name : "none"); Avoiding setting/checking default_zone. -- Cheers, David / dhildenb