From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B86BC001DB for ; Thu, 3 Aug 2023 23:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C12302802A2; Thu, 3 Aug 2023 19:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC26D28022C; Thu, 3 Aug 2023 19:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A156D2802A2; Thu, 3 Aug 2023 19:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9135728022C for ; Thu, 3 Aug 2023 19:27:37 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 471041CA5A2 for ; Thu, 3 Aug 2023 23:27:37 +0000 (UTC) X-FDA: 81084382554.29.C4D3AC8 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by imf18.hostedemail.com (Postfix) with ESMTP id 49DD01C0014 for ; Thu, 3 Aug 2023 23:27:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HLuxhMGq; spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691105253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONmtCAT+kc9GFACZZRRlDK9CgQNw3KJNidP18zQEy6E=; b=VfN3Xz/kLM8gvJhmtT0uFKAiHlAicx+x1JEWOv5FFnaBcxZMp6MLcyc8iof0SqG1TPJanv tltxEhtJGtZFIH/vvewSJHGqmYIc8rlRI/dCcCstKiqN+sV80S4iTV29bD1j/VJYi503V1 +44Jh75HnawTq5tC6j3V+PK0Nxll2hg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691105253; a=rsa-sha256; cv=fail; b=XaR4D4mwVbsVSnL9AMnr4DCzgunaqKfddYgkbbJc8qkI/wKKy+AbZ1JV2W/T4BYSCKSWX6 k2iByQotLHuaeWXnySSWwRSBUFLXvyZ5n2IL0PoyN8WVvQTBJJ8iCVxdbQMoaw69NZWRi8 g5pmxG+f1DU8FmxlbadP1vaGCHK3CEE= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HLuxhMGq; spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691105252; x=1722641252; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=XEY85hqzTu4MeOGcvbpUhtOQJxkr16cuhMq+JcwSPlg=; b=HLuxhMGqpTfMzGeaXMHmdUME8MXicPd4jALW6pd8Kv08hUWrSu+Z4Tye V3JGhOQ9ULniowzjc2HXaCV4pHDxnZ1gAuBXH5Ve2sLET9qy/wmM1NXPD k9ammUys0Tgothv+9MwX93mqhfMjHl3R2Fnm7pR7ymp9/+0ph4Ou3imsP M/fcIrRGi4E+akk0q+fJdsUJJlJ4BvBLrLW8DJ/8hvfEfnFQk+LsyUgZ1 21FGzWtaMtvE4fBPwY8K+FfTdLodw+Cg0Ip20gHm4YYq2EkRSlysxl8iq nUNfm94OVnoILSMfC5IciHLlvclhMIChPD43TcriO68zpUNhTliZLd9BT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="349611027" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="349611027" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 16:27:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="759319260" X-IronPort-AV: E=Sophos;i="6.01,253,1684825200"; d="scan'208";a="759319260" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 03 Aug 2023 16:27:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 16:27:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 16:27:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 16:27:28 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 3 Aug 2023 16:27:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjgL+oaO86Nz9gbXSgqeJARKAJUhsc9EdEZeMCEV2L+u3BZ+h1gNBzRsIms5MD0nDCk2Ro1bEtvMyQl3QJHD3iuNNWZj0R4urFwKLWbyiMDajP/AF9IW1QBXCazkCEPhx3S/9YRN0eeIoWWNwca22sNtRMNyTjtk9hXs1/XwpjifxDnnMnzngm5o7j2xo0YBIE3jyImUL3i1WuaIWExs3X9Ked8he+jJFwE00W0nF4STyqZC93ZbIwCUdpxsGUQDDFGcyDt0Py4ZOv8keDUAbqxqNquGOiHsN9+kWpmgtqdmFHlrgDhVic1NNnvrI1+tlIWbhBNrNshKJWEAOOpcLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ONmtCAT+kc9GFACZZRRlDK9CgQNw3KJNidP18zQEy6E=; b=SvI/62Bc6Sv6jS5NoUVvp0VFrhfL8pGVzyUzuQU5C1DavGwoumV0lStF/wXJLlplJIYVgD4I5SV+LsYRuJo7bR0LuLB56i/ifiD2hMRLGPbvsRSXfby4rTQUrweCeEbpoBtd8Rx5tbRZQe+c2xAs3Ljh0QVty0iJObl+XE+ZWZNdBkmjRWlwvi4dukpPRRvGtr+CBVp7/+YCSKtjIQUnA9fTAYcxoMS7EwuULdSEkkaLpDJXYsdoaEjvp1AnuZ7U9KoaQmvhYDTJIFiDbQvdEAv+e54JrDj7DVwe+Sv06KuefDt6O1TW+j9NyjcwZzzQ5OKc1hyHAeDfg0fZZIpQaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by LV8PR11MB8557.namprd11.prod.outlook.com (2603:10b6:408:1e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 23:27:26 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::221b:d422:710b:c9e6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::221b:d422:710b:c9e6%3]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 23:27:26 +0000 Message-ID: <40d49276-fae9-e538-61cf-64bb79233bc3@intel.com> Date: Fri, 4 Aug 2023 07:27:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing Content-Language: en-US To: Yu Zhao CC: Ryan Roberts , , , , , , , , , , References: <20230728161356.1784568-1-fengwei.yin@intel.com> <3bbfde16-ced1-dca8-6a3f-da893e045bc5@arm.com> <56c8f4f9-b54b-b0bb-250c-ec8643accfc7@intel.com> <3541d2de-5cf8-2f84-8153-277e2bfc0101@arm.com> <5f98748a-97ca-6426-1e24-a5675da75381@intel.com> <837ba176-c97f-f81b-c044-eb6aa3d88bb7@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: KU1PR03CA0003.apcprd03.prod.outlook.com (2603:1096:802:18::15) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|LV8PR11MB8557:EE_ X-MS-Office365-Filtering-Correlation-Id: 498d4927-087c-4116-b877-08db94793277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 39aRirNaWvqmu00ZVFYZE1sM30YuhlzYvXEtTS1lpaY2MHZ3bjDFoL+BAB4OYLQ20Tqyps8w1+PWqPG4ox2uNe0FG0nfZx+cnradqVUNJ2AKIdBsVdmRli+nfpU6F+GUphxvyZRIHYbGE/d9II2n91AhWIAIwNZ+Pct6CQdYj+CxvSjQT2RwvG/gKrBFVXUymiWJ1VvKIm8HwbsaOlD0ldjh6rhIiMhxYRfASYbrS+jRScSeUJOP41l5G4yKZZy4whPzt/n2Z47LnJWM7tGzr2ibw7YXqqfQozt9zKSyCxiErBFP/bZAEgj+DDTnpCvXdNstXS9q+kODzQ+MVF/f0rqYMUuwjgAew7JJO7FDoLaz9UP/gG5ROJkz24ToO6aE3Ik++ok6zlYxO953QNuYbRzAEbo4CuEdKeHYp5GzNokgZc7/DHrlierA+0zaao5fXC/8CNrWpAJrsTkiGjfWJT9z7Kh3O4gZmRal0b2odPOcpGPEAItMsXveFAf1Kai5/aoa6YjEyLzmvoD2JsGKo2XTO6aOdUGFX+SVNQVQJXWa0S0TQI4KlInZIGze6/ORV9A2yILWxouWzFQtm+eMktH418y8oc8P3hebOXlwxtXI7aJkKcMDsZWzyGTLJEbt7IjgpLyOCUxS25CprpKNCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(346002)(39860400002)(396003)(376002)(186006)(451199021)(7416002)(31686004)(5660300002)(8936002)(8676002)(41300700001)(66476007)(66556008)(66946007)(6916009)(4326008)(316002)(2906002)(966005)(6486002)(6666004)(478600001)(6512007)(82960400001)(86362001)(83380400001)(2616005)(53546011)(26005)(38100700002)(6506007)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0Q2aGVtQmNuWVpZRGdjU0VCUGtWTy9rb0E3c0sybnU5azVydDAxY0I3VG5V?= =?utf-8?B?eWZIbW91Q3g4SEo1T0JQdjIweUt4Wk1tekdLdWFWOUIwV05JYU9aNmJMRGhj?= =?utf-8?B?OEYyK0s3aE5xU0sxb2dpc0htNG85em9VeVpFK1ZmNVYreVU3SDZhTHg2K3F3?= =?utf-8?B?T1pJYUg2dTcwYzdwSldRS0pzMFJ1UHVuN2U5Ty9QQW1WVjkvOFVNTytPSzly?= =?utf-8?B?czFSL2NRRUQ3aXI1V2pwUGNaK3lwa1Nlbi9KZEVxcS9HSXE5bVFnSDlGVGdi?= =?utf-8?B?U1ZVQ3cvQWtYSGpwRDRDQ2RqY2owU2Q5bStHd2w1LzdISG9tWEVGcG5WU3F0?= =?utf-8?B?NGJET0pJVHJDMllKNHJ5czhPeXZReEVhSVNXVnZDdFNtUVdlQVhPc3lhK0hi?= =?utf-8?B?OWM0NnkzakxONjhwWklqN1VnViszL0VlVkVXV1R3T1hWdm9PWDJJVmFDUVJl?= =?utf-8?B?V0k3S2NYRWpMcEluVWg1cThiRXpjZ0thSit0Q2tuNGhEN3JOVXpYcFV2VWsx?= =?utf-8?B?UnZwVzBVL29mY21jUCsvS1NmdG1mYURuMG94b0dzZ3cwekRTWEtQZTBIazM5?= =?utf-8?B?SmZhNGp5TlBZeit1WE5QNHZ4V1UycVAxZHF0dlFORjgwWnAzRzhKbFlnN2xh?= =?utf-8?B?bi95L2FWc0R6dG45Y0tiU2lNY3JsVFd6bnZvb01HZ0xyQzU3STkwd01ycWZo?= =?utf-8?B?T3QwcnBDUEtNZGJsUitzVDJWcXcydUszQS9neDBYQndyTnljQTNxcVpJL3ow?= =?utf-8?B?K1RIYzVwcFdBME0ycEszSjROam9haUhYWnpwdmQ0ZzUycC9KcnhyQUQxV3Jl?= =?utf-8?B?Y2M5TkQ4WkFHa2s2VnlGK3RxbE9BNTh3K1B0VVJXV01xaFRtMWFvaml5V0Ju?= =?utf-8?B?YUdSak84NlVzcWt3aXYwVW1SZW1HTExSU0lHZVRIQXBFWFZkUU5qa1JQaCt6?= =?utf-8?B?WDEzaWduTDYrN3NuZHdUaXFqSFI3c3VXUzFhRXZHbWtBT2RDdWRtNzRNbmNE?= =?utf-8?B?RTNacGpFaTAyd01ibTRKcXZXZ3hzdWVWZjNBL3ZNOVVtK3d4N2pRQ2w2ZGtl?= =?utf-8?B?WVA1Q0ZTd29iczBZUFdSbzJNcm4yTGsyWHJIc1RpODJjOGdkOHBySjR6T2pD?= =?utf-8?B?S0ZEeE4vMFR3dCsyZERzbzZrSTRKV2xwWmRjOGV1WThXYUZ0cXd0cFRVblNx?= =?utf-8?B?UjhoSG9Vcm9jek5SNmFYTlo3SS9aa21kQ2xqVzQ2RzlsakNabTdONks4bXhJ?= =?utf-8?B?OUFOaTJMdStxUEJ6bHZFcmQxRkJHNlQrR0RUOHpodTdLV1dFN21lc1Z5UU9Q?= =?utf-8?B?aHl4bk5HM2kzRXhpd1c3aHg3Y3dsOEdGSnhEeFZtTTUxajZJK2dKTHhHUmN6?= =?utf-8?B?SWdRbmFXVlBUcUJDT1hrbXRRY2RDZnZRdkFqaUdFWFFySUpFc3pNTUJVUm9v?= =?utf-8?B?c0xabkttdlZlb2loUVNaREMraU1IMnBRaGplSUtTTFhyR29XNXBpTjZETngv?= =?utf-8?B?ZExPZ1FSM2pUeWk3SnJuRERaam9KRE1GME9SNEdVbTZhVnU2UlpDYVZZRG5Y?= =?utf-8?B?WmFmOHJXWDVQaXVrbmxxaHZqMlpQVVhPRXpZeVZVdGk1WkJVbnhwWFVicm9h?= =?utf-8?B?a05JTGUvVGFXYTU0Y2lGc0pYTUFxcmFoaytKUTA0L3BjZnQyOTNJN1ZzS2sv?= =?utf-8?B?SS9VRnJjQ2hEVWFtRDZ3bUtXODJoZ2ZFNDJVbTN6RDNGanNYNjFReXFlTGFG?= =?utf-8?B?ckdEMEJad2ZxRkFYbWM3SGIvNFVYYnc3Slh4dm0rZUEvT2tUVkkrOGdSRWNV?= =?utf-8?B?aTZuUm1zK0FzTjRRQy85L2VrNThVUjRkOGV0cklPVTR3bHRFWmJUbkdxWFAy?= =?utf-8?B?UER1YXJTN0pieDcwQlNxZ1g0S2JZNGVZeHNvMm5tWVIrV1I3SFp0UTdDTDQv?= =?utf-8?B?N3YxaXZUKzMyT2VlbFRPajdGelR1OVY1VTdncHFyUVV6QjRPWXJ0di96YlpY?= =?utf-8?B?blB5SkFqS3RFN1FWQy82Rk15cC9CUWZ0SG5qc3NSL0pRZ3k2YkhqaU5mYnln?= =?utf-8?B?d3MxcmFXZFF6VTBhR2E2T3kyOG5DOGJrSTlYemhQNlFDREhIODBlK3ZPLzhP?= =?utf-8?B?L0UwUlRyellnTzA4dzY2amppbHA5MlF6UXYrSmtFbEhOWU1LaUJWUGxYV0FC?= =?utf-8?B?cGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 498d4927-087c-4116-b877-08db94793277 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 23:27:26.4472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3PhzIQXnwuwbQOW1fJ1UI2oOT/fPM4Gbj/R+nW6Y9yYZOsT/rJh3iRQ2A65ecam956BtQya2FKtyorm1YRVeDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8557 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 49DD01C0014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ue35goo7w8sf9d8m6o9yue94adjb5i3g X-HE-Tag: 1691105252-861209 X-HE-Meta: U2FsdGVkX1/ZqIVmherzNFM2OduE0BUEdpyj+zGD6Muugi6jBOCx3Cb63PIfifn9M3v48GrhrMxdZrc2es3SSBMEkTAtxxbShiyTxvvRacQJi3j/7A0gpXjrvMzq8Zy74Z/iN7NwYpwxPQQ5lOJfzAf5r4FhdWRcAa2tTdcyqoCuhUhgUiAoPlKdDRasAytBADXxQ6b2bhEI1+tNQm5eJKPo3NpQ/z+bjk7JJNNTwprwKrqClE7qsiGpl0dl1K4kL8rs9pPqKF+RKutqaF+EFs5EwmVR13SgQokRQehgW4VAapQEgZWkO3DO/iemI2RyoVM93GIdAwdqaSX5mtmZakav8MfHsuHyTSPAORzv19790R6tthiN9PRKg3Te7lZUYQ8v/FlV3n6l60JSafBwf3mE6GnhXhGJzLfwgIN+8TidmPotGSwMXCyTDWeXi/qCeo/5t+CZzyUgn3CYSHGr9LTQOQxF9hohOh4KRJhoNxHZCRypY9rGqDDAosfoqgxcInoUMoRWnR+oQ6HJdwOVTv8wSGgLD6Od+TOEx0ArOaOeDUNzz/5szlUf8v0NA0PfffZ1ri7arI00eFxFgsOBVrl5eBXmYzmc8g21MxdWIrb9PhgAnkU+wXBh0KjFZptlXbbHKHS9EVuve6XAt5/MxMm0BO8it9WDGJypoP2M8pbqrWg9VT0wywmzLi0NX5DQ2sEWwKsFs40TKKtiZ4E3lUO+ddSPFdxACdihJPjiQOAABXSBG405r1YrnPDFYX+hnoueZ/Bw5AhnferuiVbwBK5pENhNX9vRqYmPVtiQaeilYd96ly47in9H7XF8o5503jSH3i58hnfcIgMS2Qu3qkFpb9TP9mfwXlOHsfwxQ0mh7//6JzupBW0uRSo0+yzrD4zZyixjyliMsJK5r0ca1cf2dRfPTbgO+dcmBfxc++eucosvk+BoOUMJXpdC5ph8oyjDa9mBhG/NouKMKNg D76nqTGe wvxXeM2ptJMP7YfXAM2ZFYcMIibJEQlG2tma/EwqakIWh4+RM8zIbtTXEM/hjRTTaeawjGFuGi0ZXm5h79bXVNPNP4qxAPfi09N/9+HqQPSW31iraSrhfOtnw2EISb7DWCJuzVikE/2IPtja2SPTscMD6NaiPmWWj8qjzt1g1DVnFwyoDa3K17w30symkJmbol2nj2ysumt0aDWxXk7/riLe04hlIDgpVPyJ3Ar3UFs3DnIBMMHzwr+zXqsrDouNkpKf7hE3R623bLIRK3rgS52Z79hs7I5gmQGPGKoZXghKuCxfu1TbNADry9hnUmtz+RHSeIzzao62nS0gYH9KVPLMBdBTYKq4MiotsOeciaWxga1CKXqUvfvzH4B2vzUVnuaCeXE6UBlUTLtkOSJf+CQUAxgh/CFsGTskRrCRj46Yol4bJUq0YrVEeZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/4/2023 4:46 AM, Yu Zhao wrote: > On Wed, Aug 2, 2023 at 6:56 AM Yin, Fengwei wrote: >> >> >> >> On 8/2/2023 8:49 PM, Ryan Roberts wrote: >>> On 02/08/2023 13:42, Yin, Fengwei wrote: >>>> >>>> >>>> On 8/2/2023 8:40 PM, Ryan Roberts wrote: >>>>> On 02/08/2023 13:35, Yin, Fengwei wrote: >>>>>> >>>>>> >>>>>> On 8/2/2023 6:27 PM, Ryan Roberts wrote: >>>>>>> On 28/07/2023 17:13, Yin Fengwei wrote: >>>>>>>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(), >>>>>>>> folio_mapcount() is used to check whether the folio is shared. But it's >>>>>>>> not correct as folio_mapcount() returns total mapcount of large folio. >>>>>>>> >>>>>>>> Use folio_estimated_sharers() here as the estimated number is enough. >>>>>>>> >>>>>>>> Yin Fengwei (2): >>>>>>>> madvise: don't use mapcount() against large folio for sharing check >>>>>>>> madvise: don't use mapcount() against large folio for sharing check >>>>>>>> >>>>>>>> mm/huge_memory.c | 2 +- >>>>>>>> mm/madvise.c | 6 +++--- >>>>>>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>>>>>> >>>>>>> >>>>>>> As a set of fixes, I agree this is definitely an improvement, so: >>>>>>> >>>>>>> Reviewed-By: Ryan Roberts >>>>>> Thanks. >>>>>> >>>>>>> >>>>>>> >>>>>>> But I have a couple of comments around further improvements; >>>>>>> >>>>>>> Once we have the scheme that David is working on to be able to provide precise >>>>>>> exclusive vs shared info, we will probably want to move to that. Although that >>>>>>> scheme will need access to the mm_struct of a process known to be mapping the >>>>>>> folio. We have that info, but its not passed to folio_estimated_sharers() so we >>>>>>> can't just reimplement folio_estimated_sharers() - we will need to rework these >>>>>>> call sites again. >>>>>> Yes. This could be extra work. Maybe should delay till David's work is done. >>>>> >>>>> What you have is definitely an improvement over what was there before. And is >>>>> probably the best we can do without David's scheme. So I wouldn't delay this. >>>>> Just pointing out that we will be able to make it even better later on (if >>>>> David's stuff goes in). >>>> Yes. I agree that we should wait for David's work ready and do fix based on that. >>> >>> I was suggesting the opposite - not waiting. Then we can do separate improvement >>> later. >> Let's wait for David's work ready. > > Waiting is fine as long as we don't miss the next merge window -- we > don't want these two bugs to get into another release. Also I think we > should cc stable, since as David mentioned, they have been causing > selftest failures. Stable was CCed. Andrew asked about the user-visible impact and I replied: https://lore.kernel.org/linux-mm/24e7429c-14ed-d953-e652-eac178de76e3@intel.com/ I was not aware that selftest is impact by the issue. And waiting for whether these patches are necessary for stable. But I don't want to promote this kind of change in other place as we will move to David's solution. Regards Yin, Fengwei