Re: [Lhms-devel] [RFC] free_area[] bitmap elimination [0/3]

Hiroyuki KAMEZAWA
2004-08-24T00:10:38Z

Hi

Thanks for comments.
I'd like to be more carefull about white spaces.

I'm now writing a new patch with detailed descriptions and
a few of additional range checks on 2.6.8.1-mm4.
This new one is running on both i386 and IA64 now.
(The previous patch cannot run on my IA64 ;( )

Thanks
Kame

Dave Hansen wrote:

> A few tiny, cosmetic comments on the patch itself:
>
>
>> }
>>
>>+
>>+
>>+
>> #endif /* CONFIG_HUGETLB_PAGE */
>>
>
>
> Be careful about adding whitespace like that
>
>
>> /*
>>+ * indicates page's order in freelist
>>+ * order is recorded in inveterd manner.
>>+ */
>
>
> The comments around there tend to use a space instead of a tab in
> comments like this:
> /*
> * foo
> */
>
> patch 2:
>
>> area = zone->free_area + current_order;
>> if (list_empty(&area->free_list))
>> continue;
>>-
>> page = list_entry(area->free_list.next, struct page, lru);
>> list_del(&page->lru);
>
>
> More whitespace .
>
> -- Dave
>
>

--
--the clue is these footmarks leading to the door.--
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>