From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B128CD11C2 for ; Fri, 5 Apr 2024 14:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBC956B0092; Fri, 5 Apr 2024 10:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D45686B0093; Fri, 5 Apr 2024 10:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBE696B0095; Fri, 5 Apr 2024 10:30:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 988076B0092 for ; Fri, 5 Apr 2024 10:30:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 233E381171 for ; Fri, 5 Apr 2024 14:30:28 +0000 (UTC) X-FDA: 81975713736.26.6BC5870 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf09.hostedemail.com (Postfix) with ESMTP id F11F0140026 for ; Fri, 5 Apr 2024 14:30:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=huASlTyo; spf=pass (imf09.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712327426; a=rsa-sha256; cv=none; b=ZruSgjFaVJ6cU9JiBEwH1vrubXgNyre9OUnbP7PdARO6A2nU8Parz9hpUc34rOu0Lx8kIx dSO8P+dG4w8TDitw4IKiQ+V4Oc4OL2kxiHnoeZgXj02JxdLCzJ+FvLatTVG1NxeVKSqmzu pqO7OWgpaX+lNjTBNzQFELHHpbUXNFA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=huASlTyo; spf=pass (imf09.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712327426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/hnq3sCt2H7lY5oSS405R1id2Z+jwtM4OI26amI8Aeo=; b=aHRUqH7rTxw2FIo8V9aues1444V+cxsjve8uQY6SKOuWJi3WrEMdOEASRG9/FCloKtcP9b 79o2qEZ+ze7lB/IWM+APSlmXTg/ob969o/re5HAaIsnWf5oIvJ8j812w20xoK3xWxPK9DC Yqdkv0FhA4FgC1H+7j2GlYZsrEwlMZM= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-51381021af1so3630563e87.0 for ; Fri, 05 Apr 2024 07:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712327423; x=1712932223; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/hnq3sCt2H7lY5oSS405R1id2Z+jwtM4OI26amI8Aeo=; b=huASlTyoxKEntia9qwUWG3oe350RW6mY+z/98Aa+EfuOltIsJWGd2og5AT0IN/yaS+ kDo1OjtJpe87pZ5ycz0Xq9L+LMuU2SOIfu4JKbeZtsCfkG0QRI2FFvtbhK8lbXJzU2eQ K6/A4YQ9L4Pnu07FtgmiZWxos/Qx4aMekX2RQOE5R4EIZkEQQ0sXN3EL6aulsk52Kea+ zMRyFUV63pxx47LFKSE4Y0bHFozaZbFhtUD+lAlS09j8TH2z6E6xpcdQoiabWc0qjbJB PUz/Vcl2exP+LkXReTwM9DC2irJO50jeiA09Hko1sl58MQ7MDrhaVvyLBh3fXzrBRthF 4Klw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712327423; x=1712932223; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/hnq3sCt2H7lY5oSS405R1id2Z+jwtM4OI26amI8Aeo=; b=bFYL9A39EMBO8H8wIxUaY/bgtTNpU81Eq3P/qcn/769xN8N+/ShnflnNjXljlTdjz+ JGvnhDVTNpu76IZ7hiHboK1Q5iSkAAikhxolvM6YwsdsQij5puPupQTGLLBr2Ykon/kX A7nzxteZtI9M8FKhircfWpCxTzPu255jLoGZiZonsEYuZq18eQVGm1VZVlYVhfOlTiTJ 2O1HxjUMQ2UqWiCgdom+brFX9aGb8WpMI74AnlepqTtFaA86fAEJGM6ATt9GzOqIg2pd HZH+cDH0gB7FFm95FTsPf5ucbEWBbr+oFYLZdR4tjz/usofrTW1DgaNR+1yzWEN5N8Po ZHvQ== X-Forwarded-Encrypted: i=1; AJvYcCWEe3m9yEWBritXvPsoXvmwdpgihb5wNnI9dzuNNkQhHEIrjsdk4XH1MI1+fL2zKtomlwpCBwZtrvGg3K09NXthF0Y= X-Gm-Message-State: AOJu0YzD1zotOq5E9b8P7958RqESxs9g4FDYDLkely6/FIAV/m0Yodrz 8IGsJBe6r2k8cLIEluk3wAFO3VOgr2MkbzTzZB324uE7KNEsvlRK X-Google-Smtp-Source: AGHT+IEN7LuOfybxnTQmCx4kMrf3SVJjqvCauomGfGiCeZbO2kceAhX5eC2lsiS+gBj9j+xLKcrlpA== X-Received: by 2002:ac2:454b:0:b0:516:ce0f:738e with SMTP id j11-20020ac2454b000000b00516ce0f738emr1466474lfm.19.1712327422562; Fri, 05 Apr 2024 07:30:22 -0700 (PDT) Received: from ?IPV6:2001:678:a5c:1202:2659:d6e4:5d55:b864? (soda.int.kasm.eu. [2001:678:a5c:1202:2659:d6e4:5d55:b864]) by smtp.gmail.com with ESMTPSA id 23-20020ac24837000000b00516be080873sm207196lft.8.2024.04.05.07.30.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 07:30:22 -0700 (PDT) Message-ID: <41328d5a-3e41-4936-bcb7-c0a85e6ce332@gmail.com> Date: Fri, 5 Apr 2024 16:30:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/37] Memory allocation profiling To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240321163705.3067592-1-surenb@google.com> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F11F0140026 X-Stat-Signature: ihaxi6k8o6bd5c1gowu3oquark6kj7nu X-Rspam-User: X-HE-Tag: 1712327425-464809 X-HE-Meta: U2FsdGVkX1+u2BBZmbGfRo/a7dTq5WjRLjdlzPxhZe3A1ZIAe2VSeOeneNeco4wdmscrbZjK1rXQujI16ZTu7xDugfaFlDlTeWFcBYkZaqN1fF0sA8QWKT5MPCPX1pu9OAIXjb1N2y3etG8/1QkobnADZrbOS8xzejL8ygB0WMrSYBLlmz8X4/3CD5KEGRh56Za1UhJsddjhHQ60qO4P4en/5nxTQldPeOwKvB/TfPx3yinS0AZsr0b3v8wD/tdXc9r6piFV5OUVFsl8MxK6D9KszmiFSGldJntKmKpJe+pxrsQKgxEvEUoS5jMw4jhaCmZClpEmXetPw4AmkaBePDke1oD0HWnWuWj3hMkDmYfGMvoikS8D2PDL5Q7bKdY5po2I9oAYTB3rwfEgKWIdM5S52KEzFSukqewlEgLu0ULt+HGB5elw2SoCi4Of9KN87HApEMihNVHT9Kk76VSDFEJoADqLPtOAZsW4hEzcVyzFc5V6vf8monj/r7VTYqJIiZqV8oQgpCDeKR/in913SUGZU9eSko2aIf5h7NiqdlWDmxsUH9GVJqnljkFJuXGvpP7ueZte2Jm/2csVqydk0ecv38Upj+e/VKmIKX/urU7bOuG6s0UCHseherqVPN3zfkXsTU8FZ57de0NMI/qR5IuKQoFQwr2opnIwQ/m+5QCmrFvuLsxeZPtPIY6tIJDOpsC/WhVXk9WwLKR75UyFs0+wNnikU9bhFpJjWAkiacZ0u+7ScviolQGTlw/OZbLNm7VGFOCblaL1MAlXO5cGJ+o/Rnf0c0AOCQ/MunP0KByR8RvHhYhFipmF9UQKrKyDMOvQaiHkZlhzjq9/NWbvasn1CKeyHseM+kEyXR1xHPHxc4E0zjI4qbj8UEbY04OWHqu8afhBI4na+mpH0AgSnqnGbsDGHFtpPtgVhuQRgjzvB4R786FEY8N9jylJMq5Y15pvPeVX0GmxCkuZ2aN AqwQqtz6 TQHziIyqN54SF5ec8TuQP17XxilH9viDCz+FKriRKAf0g8h90tJ+Wcd42mBUSwD+yHYz07gOhQASwIm6tffoKaltz8OUX/Tug+tWX3meJh3Y56sPcgJ/uAbsEz9f88q+wPNUFF6yTN4zBU4U3RedJIMRfP/77HAi+5o5FHCcd/W1XtJHrU96f0Lf6/xjBvYOcS0kNWc5ngsE3GQyoWCHqWaYaJjD0V31fT5Ywg7rcHzU67NulYOuyUft3Ayj86t6EX1gq9Ogir0KMnQgIbqNYewidlwKcLjiXi90WLaCRULHp6h0XBPBBAC81gjBNPHwB56MuqAj9XkDOY9XuSIdGwXj1O0J4/M6W8mwBD6QjRUETQNXlqOgV4TqsFWSfpA44YaA723+1NtPogusIonx0Sxmaq9C153FgTxNUwsy5DpG1SAOCC8AQFnJPeoSyMg52keHfV88A9bJnnn93CTL8vckp/8/QnW1iP3BCdaCrjvmXJsWNDYRMj0rWc65lWZRP+tiDSGJI9pOeKn2jAQmPfJYMrXIZxHVGyZAkxQPTKY2j6hpdFZxmG+QsXHKrTgDmMrHE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-04-05 16:14, Suren Baghdasaryan wrote: > On Fri, Apr 5, 2024 at 6:37 AM Klara Modin wrote: >> If I enable this, I consistently get percpu allocation failures. I can >> occasionally reproduce it in qemu. I've attached the logs and my config, >> please let me know if there's anything else that could be relevant. > > Thanks for the report! > In debug_alloc_profiling.log I see: > > [ 7.445127] percpu: limit reached, disable warning > > That's probably the reason. I'll take a closer look at the cause of > that and how we can fix it. Thanks! > > In qemu-alloc3.log I see couple of warnings: > > [ 1.111620] alloc_tag was not set > [ 1.111880] WARNING: CPU: 0 PID: 164 at > include/linux/alloc_tag.h:118 kfree (./include/linux/alloc_tag.h:118 > (discriminator 1) ./include/linux/alloc_tag.h:161 (discriminator 1) > mm/slub.c:2043 ... > > [ 1.161710] alloc_tag was not cleared (got tag for fs/squashfs/cache.c:413) > [ 1.162289] WARNING: CPU: 0 PID: 195 at > include/linux/alloc_tag.h:109 kmalloc_trace_noprof > (./include/linux/alloc_tag.h:109 (discriminator 1) > ./include/linux/alloc_tag.h:149 (discriminator 1) ... > > Which means we missed to instrument some allocation. Can you please > check if disabling CONFIG_MEM_ALLOC_PROFILING_DEBUG fixes QEMU case? > In the meantime I'll try to reproduce and fix this. > Thanks, > Suren. That does seem to be the case from what I can tell. I didn't get the warning in qemu consistently, but it hasn't reappeared for a number of times at least with the debugging option off. Regards, Klara Modin