From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FD7DC5B572 for ; Mon, 17 Aug 2026 17:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36D1B6B0889; Mon, 17 Aug 2026 13:48:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D2D6B088E; Mon, 17 Aug 2026 13:48:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C456B088F; Mon, 17 Aug 2026 13:48:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE62B6B0889 for ; Mon, 17 Aug 2026 13:48:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D13D11A08DB for ; Mon, 17 Aug 2026 17:48:00 +0000 (UTC) X-FDA: 85111494720.18.8CD2DD8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id EB178140008 for ; Mon, 17 Aug 2026 17:47:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=UFC53VTl; spf=pass (imf09.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1786988879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iOfZaB713Ys+B7W6jfvJNm+JxoikF1oqkGAtPEWVmKM=; b=1dhwSnI4H81anrmok13vkrQ8pRdtCJ/1I6/2yKIQXaC2+UszQT3SjEu9Gvmr9luxEpaqMA WjKsK8BTTwF1scklWfd0mvzOqr/X8VjRUlEtoJSWmLxrrm8Wt2Rekh6++FTC1OULyYgE6e qq869vSgCezFy19I6uuVAmIAJBnCq4M= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1786988879; b=g3Hqmh/W3sDHWpEcWxZESlNnGZe2qZ6QbSjHhXKmp1PsMVPXAdM3pHq8PI1l3o8TUrfJrX dnW0AlegTLIyz8gIIrmbGjJmdldmibgZL/DiOgsuzOTku6KJCyk3MBG/vgunVP96XvBagQ Vy73/9SiHRrqY+QeCwKxQnlFP6Fudgo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=UFC53VTl; spf=pass (imf09.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 130554162D; Mon, 17 Aug 2026 17:47:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E09A61F000E9; Mon, 17 Aug 2026 17:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786988878; bh=iOfZaB713Ys+B7W6jfvJNm+JxoikF1oqkGAtPEWVmKM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=UFC53VTl2Puis5UdHizYJS6wpzdkR0Y4Cs2swJC+qyXyAJgM1ZYkvox7UjN5rhbsj 1+NFH13oX6N+hcodMHyEgtNPdNRlwoqSt98ZPNHZKtNyDp6PXseAXNVN9Ls0qdFCG5 oGf1yvZ9jgHFPR0lBXgqHL8/3mqgAwmgBfdPPGzGXRMq6ateng8F+4B3n3WzVi2QRH ZtfVbyZSB3L8fcXmbNE+QHMT7xtuyH5E8YwbOyVCqbg/mNHEtJA+AzZwPkRCb0y2rA 8KMB33y59JwnRcapyXIzk1JimaAEJ8E6iTxCL3h7twR3XZJQzQYsHPeG1IYmMKeS/H myNzcFZeLvwpw== Message-ID: <4148c151-5ef7-4e5e-986e-b05e600045db@kernel.org> Date: Mon, 17 Aug 2026 19:47:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/migrate_device: fix cache flush when replacing huge zero PMD To: Zi Yan , Hui Su , Andrew Morton Cc: Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260817060845.377800-2-sh_def@163.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: xqbrjtqckxybn11w3fss41yam5n84nc5 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EB178140008 X-HE-Tag: 1786988878-362172 X-HE-Meta: U2FsdGVkX1+5sLpjUSkLB5iljHRsD9/TXBl7zTcCkkTCERVPCPu1xBMsgoAiRWMnW+UsJcRFI4WksxX9xyr3n3yD+HFEgGKoGFC723L9XR0RBCnumwOzmgrA8D7/umpl7PEoA8TBi1T6dM3zYtFF6Fx1H1PAk7gYwu1IaAMlSs8ycjw1yoouOKDT1b/UbX1WOrd+wTt/H0qAVMBvrkkxBVWKEI4jED7b79Y185t6Sx6QR67JehoOFMXM0Jw+zwHE2c//LPC4tSsDZsb/oTCAuw2DXgiwT3sbDGAX6KGSZtg6wnN2cRN4Im7L7uZr94nErlFlz5PbKAn98qq7Tlt5W7xqoxM0+dC7rb59b9h8qv6eR0m/v5q9nZNYNSA7s/9s2U42aMfvEm9KyXOk283QYQyTjHeFpEjYUMOqO+31Dz4I2yxTMiMogtqVCgqC3BSg30XF8b25A65jVHU5DinxnTLilzVArFBstLxwjDKzaxyt7xEc0AUwfgHLCYbvTZZdHggwFZavN+5TC3jdJS7UKPZwgJYp+mejnZ4obX0JeSDueX4ckuiDKRNqNiZoVaO3hE/xYYfvc1pFcEu2rrfgpaHWCDNKjOtfGR4F6xwGKaZl2pAbjYhrN8CwCqVSo2qyHhJeTeUG0HLvbKrskbdj6nJhSacl0vUyv0BZk12hzJsvrgYz4imqBF7jqjdjsTMZ3m82UnJ481kTHUXesH8H0l3gFFgyn6JwAw4BIQd7KAzoj4iI8Gw6uUDVZ9a5eGNZPQIWLnChRt5RY96aS5devNWcUE/n2Snz62vGlF1fECwfrNYvGgGoAwIcXkYkbnt9s4huob87JSF824tynHfnRjRwDxGnvkVCHedR3PDz3JYzrwSHu9gutUK7eYWCfWU/KDn/E74oYuHyghp2XYyOQ/xFjt0JwFauRnJy0HHGiVpUJsHEA7tS88m8RbgPI/rk7Y0MF5D9NMyiRBQu9Zr hC5hPDzK op8VQKVqtRSYdJwYbfUmD/VXQ4DYOrCXZ7ACJjAd6THDsbsXz7AOwIr0qPjVcPt6culqFBP50oIsWzOTpd0p/THk9N6z0y9I7FAJAiX+/LZ4OAftVWXnlSp8L6zz7535xDXGoO8Yl5ZosLL2Mn/20SXLs1XDI0kS5DlUzjyrz8ninkLqjtIgHeJXsQPunw5vR65Df1oGIDUqUfenWmXo/gbJABcXVJ+HUMM8uls4M0ClNO+rtxyT8TwfdlqnIkoj2FG8o5VAzYgbrrykY/SnASrq8qjZ0bg8Fnp4L5NZ1sNr4RryZlC9mgaQlQbnJQx7jJtkj2zi0WLbT0g1wA5N7Bxh/vGK4sYKeGXixUtsCvHNWnQUcjs1qwgLOGZ7pwM/NVqMYHGrgdwbJW54bg1UpKXOEv1zOiWJNWlwi4YjzDFVlFbIWkGRGrn42vkxEFl9AviC4K9xAwWgFIS4= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/17/26 18:39, Zi Yan wrote: > On Mon Aug 17, 2026 at 2:08 AM EDT, Hui Su wrote: >> migrate_vma_insert_huge_pmd_page() calls flush_cache_page() before >> replacing an existing huge zero PMD. However, the third argument to >> flush_cache_page() is a PFN, while addr + HPAGE_PMD_SIZE is an end >> virtual address. >> >> More importantly, the mapping being invalidated is PMD-sized rather >> than PAGE_SIZE-sized. Flush the whole PMD range with >> flush_cache_range(), matching other huge PMD invalidation paths. >> >> Fixes: a30b48bf1b24 ("mm/migrate_device: implement THP migration of zone device pages") >> Signed-off-by: Hui Su >> --- >> mm/migrate_device.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Thank you for fixing it. > > Reviewed-by: Zi Yan Acked-by: David Hildenbrand (Arm) I do wonder whether there should be a PMD helper. -- Cheers, David