From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89059C3DA4A for ; Mon, 19 Aug 2024 09:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E1F96B0085; Mon, 19 Aug 2024 05:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06A776B0088; Mon, 19 Aug 2024 05:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFE696B0089; Mon, 19 Aug 2024 05:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC18C6B0085 for ; Mon, 19 Aug 2024 05:55:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7595BA115E for ; Mon, 19 Aug 2024 09:55:28 +0000 (UTC) X-FDA: 82468537536.03.6D3452E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 2B64E18001E for ; Mon, 19 Aug 2024 09:55:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ICh+Tmm7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724061263; a=rsa-sha256; cv=none; b=KRUvKSOYoLplnNMZUM2H/woDv1YG52Wat/g1U2YO/50XJh0+X0yOzQHVpf++XKVdGeXOxg nSgHsn67T8KEA6NOCtBgOy1pvUEKcGil3x4Sk5FxMQQeq3GAKWwXe5pZRc+NG3qlRRzXXj t0UIwoGjv8Mz+pN2bW/W5U99jzkMRKw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ICh+Tmm7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724061263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28pzRtH2lblsPvMe2aCxq5h50UEXCYwwlTamSyuI3MY=; b=PH0Psp3EcFLZQh5coggr0OyRPtO8RTwEpm0U2KEo5LRc/f7tVVaVf9OYR7DZBkCVG5c/Y6 K3Ffcbqpyf08l0lynBETV4soKDncfgJeEh92/Vl8I16zz9jQ7TAU7KxC32NV3ymKjfC5Wb tMPmQSHtc8W06007TYk0rMSlZ+c1doI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724061325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=28pzRtH2lblsPvMe2aCxq5h50UEXCYwwlTamSyuI3MY=; b=ICh+Tmm7aD0pplUfLZYZbya9ZyskWCSYvZRqSu6EYjW8CkeVMopPxZhtWip8FwwXDJLs3F MtiqAtcJPQw8+PgQjzPcm2GaFTfnQGfqkF+igzwKES4vBFdeyjZrsPDx12dvPddKrgeb1Y nz7U4gL6hMjyCKyIAV5k87DOZ/MDWok= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-XUXJT29aPBGTeAQzQVf8gQ-1; Mon, 19 Aug 2024 05:55:23 -0400 X-MC-Unique: XUXJT29aPBGTeAQzQVf8gQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a7a9c275447so270330766b.3 for ; Mon, 19 Aug 2024 02:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724061323; x=1724666123; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=28pzRtH2lblsPvMe2aCxq5h50UEXCYwwlTamSyuI3MY=; b=oIan0Cirdr+DQhxeUICCTYeyyZVcBD9kypu9D9mYMTw9uZ7/amITsQrVpXbuMx3vSb nXEgEiqzzLFLy76WdoKIlknZ2C5tnLHIQ7a+CfC3mq361g95BVXZa3wC2wXEK1Ro3a9N ZNfGSr+aaJzPAqpNKmLMse2a7QpJ3IvPEq0clqYk6FqazdR1yIxivnWXPu5BzHUd0vlh DXgmK3FiIqzlO36epu4ujj+eFBxQlWhdi8dJXfnyCDC8pmpPFERRu3ZTs4X/g6MaYMuD CWPkvVcGO0gBPkWzkZY3FxJTlEb0CQzMeURzuU5r18JqYWbGBi2czNgdl/jiQVGJusk1 MCzg== X-Forwarded-Encrypted: i=1; AJvYcCUm7NKDVGdMEeO0rnAvDdkDfK01ij11PpS2M35TJOK//JbTo87MKcYLhUWCrPULK4xrN7OAKMvMw5bRcxtEZN+4V3k= X-Gm-Message-State: AOJu0YwgBRVeAQO15snulrcUuY+7IYFDkQPMpkAQkOpw/WD9uFXNhqtw yJIEIy5z9yJJ6CdfAiPnrG+wAlXL3ZcHV7XB3pShXjen/nHoh7oI6jnMb32Pp8JGM/A3NEBaV6j zG3rRM5NrVkrj8eTTOomvS6LYaOPaHXwoxVSJK7D5uHF6m3Hu X-Received: by 2002:a17:907:f7a4:b0:a7a:b385:37cd with SMTP id a640c23a62f3a-a83929542dcmr746309566b.30.1724061322688; Mon, 19 Aug 2024 02:55:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFspndlXBbf/RQIjxomblZ6FACXpAZYO9AXYFzOcRPOIg4eI+/JNNNju+hnpBKrXcRcpD4wkw== X-Received: by 2002:a17:907:f7a4:b0:a7a:b385:37cd with SMTP id a640c23a62f3a-a83929542dcmr746307266b.30.1724061322184; Mon, 19 Aug 2024 02:55:22 -0700 (PDT) Received: from [100.81.188.195] (ipb218f908.dynamic.kabel-deutschland.de. [178.24.249.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83839693ccsm616135466b.190.2024.08.19.02.55.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 02:55:21 -0700 (PDT) Message-ID: <416ac265-ced2-4f90-a347-0a256edf7fdf@redhat.com> Date: Mon, 19 Aug 2024 11:55:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: BUG_ON to avoid NULL deference while __GFP_NOFAIL fails To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, Christoph Hellwig , Lorenzo Stoakes , Kees Cook , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Wang , Maxime Coquelin , "Michael S. Tsirkin" , Xuan Zhuo References: <20240817062449.21164-1-21cnbao@gmail.com> <20240817062449.21164-4-21cnbao@gmail.com> <5654b71c-1d9d-4c48-b28b-664662da8897@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2B64E18001E X-Stat-Signature: pid3nmjz1546dhrszq9g3aby84dch6cn X-Rspam-User: X-HE-Tag: 1724061325-897388 X-HE-Meta: U2FsdGVkX19hR4lr/yznHhziuQ5XEwpE4jfo9PCftVzOlkTT2NanDYcb8wvAxDEohv2k2sTSkCwIE8Wyvci40s0VoNXvp4e6o0VamK7PrhIRKtNJinAHscPoLqTt45I3lwH+raA6w47Y3iwd5OVLxZPEfYB2VZLmM433mQgwmcw24dAfHdnA86ods1wKFRVZV7dH2gqvAsp4GYcvykygryGX0VuJQ7K/rjJ1mmV0nDAgvbkKjgfI7p9bbl+ILiAqGgm6/tYosPFE8BmVhTOadBEIPcrnZV/DU1tmM/X3rstzSZK/RJ1VGx120WAHZXiFBrzi2/DMc9UQQ7JqnK3oRhqdzlvaY8oj0UhsLGt3eJC5hGQ3QiwxFpRJSNrMqIPMl+o61hCMMseUuI29XqkL1jbd4RycldERZTjkf5ZUHX/dDgF7g7OQMgIRtesgv80Je7shJyEMVPeDOaMlmX0/blcb3AukqT3muo5/sngTn631NDIkQBgucKdz8EYe30CqFUrqcs141cpoDMfFPdXY8NJ8LGsOVVJPjs9GaNCR94sjrlSJar4y0g6kX32M3v5dqYcY9Zg8LFcOKAGjGn9//Z2vaqR4COHNr34990ZXf+z4vCmj2nNAVMIZBrDH01qk8G/OZAIus6qvhv6GCW+JO4Fqm3vKtlBbsAjjEGZDQBKZ6BH4pgRqXke9Zjg/9HlLqgII7Ws0S9aaT+7jShPjZXl4Ec5Uqby6lvyvP2jWu5uTZ/waYS7dnGENpybBP59wMZynYGWfA3e3FvQ0RwXqFdKy8VxnncH6P9mdRgo6zfy2fjtbcU2AZwmuxabPRz0kRXG1a5nZda105bZl/dVyc4a1q8yR2lTAeyOMQ/w1Yimq/Hj9CguZPq2fQA7vefPTLOxHMsvgX5pETaD9vf8KbDBMPd/SD9ImhHHAko2QWSBShl+3iWq/C9xSNZluYMy+0PKR2fvl2KpLs+GM4Cr Eo3NfDOY bKYkeavJgT40oX+l+vRQlmVTye9UDz/vvuRP3ZAZ0WfI7vcDzbFZixjkgRjiCE1DUanhyPb+EQt0B+qqTbz01uGWMUroYaoTC3PhkfAXLVHF3nEj5reargVEsMBRMoKkbZ8rI3zZx2NBE0qQAAe8gpBtoRtxr2F1hlh6aU3a0Iw5A7UnUS1s8Z5pH2TRQ7fJtu2qj/JHsoLDL0cJOhIni0En6l+4D0on5CorPFApSonR0/ZSI58q0whlzsueEXRv2hDV7fPn3WHVJnCGbZwmUFtlXMDUBsXHFD/c8NSzUIwU+Fz8eNvdGCKAIyl/fqXNohlPpT0s03vMvLhZNbxEmmaoug1vqTUTY4YhAX2H//Nqtf+niHgWhQnCd9KVQQr2xhDlWR8mB5Ro5nSMxVzDwgOFyx7ZiWIaosPIcwdbW3d6yfFdKJoGjiJNOTHrIkqa0OrClhmgbMWwk4axNaqo5kob2E2pojTqjjKLBR3zs0Lt9VUnyzKLreHoHcqHIO926JYsB70IIA8Pua5nrN7xg8LCiqfpxN+qJNMsJNGK0Dh7xEFrmYIUDqcGddVdopuB/1hv1WZdaEdApnk3u0AxXti0zgCqmy6A3bS1UqRFn07PBEVf04OJ1hq+zC/TYTJcjcbpZEqx4WSAX6x0p8oJ/K5xSWhJJEgfD3An8cn2zaYB4Ri3WScT7yxWwikRlSDniSoMWXSIL6ApTTKqjp/7ZMe1PTHoGf154cbhJqqa6HPaXR1pzUuRmH+1nPzyvX4KzhmvsHfS3K+de7VdwghJ6bHp3iGU3Asewyz55KWv6S0vJKa2zTvZMI/Mg11XreD2QLNW7KibnYZdTsJt3EQO+C/GZM68WPh/dgRN78zdtwVFPe6gmriSShJ1azrTLmBWmxjigwcwDnu+Flf6Xo//2baH9PKHXMYONkhQsudaa57A1VC6EzwYLgNgbIkL0kpSIFEkqRFn7W5SqbdQ3rFxK5MteM6rE 4NJBW36G 7Mwvpc4/5wKKP/FndOOMGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.08.24 11:47, Barry Song wrote: > On Mon, Aug 19, 2024 at 9:43 PM David Hildenbrand wrote: >> >> On 17.08.24 08:24, Barry Song wrote: >>> From: Barry Song >>> >>> We have cases we still fail though callers might have __GFP_NOFAIL. Since >>> they don't check the return, we are exposed to the security risks for NULL >>> deference. >>> >>> Though BUG_ON() is not encouraged by Linus, this is an unrecoverable >>> situation. >>> >>> Christoph Hellwig: >>> The whole freaking point of __GFP_NOFAIL is that callers don't handle >>> allocation failures. So in fact a straight BUG is the right thing >>> here. >>> >>> Vlastimil Babka: >>> It's just not a recoverable situation (WARN_ON is for recoverable >>> situations). The caller cannot handle allocation failure and at the same >>> time asked for an impossible allocation. BUG_ON() is a guaranteed oops >>> with stracktrace etc. We don't need to hope for the later NULL pointer >>> dereference (which might if really unlucky happen from a different >>> context where it's no longer obvious what lead to the allocation failing). >>> >>> Michal Hocko: >>> Linus tends to be against adding new BUG() calls unless the failure is >>> absolutely unrecoverable (e.g. corrupted data structures etc.). I am >>> not sure how he would look at simply incorrect memory allocator usage to >>> blow up the kernel. Now the argument could be made that those failures >>> could cause subtle memory corruptions or even be exploitable which might >>> be a sufficient reason to stop them early. >>> >>> Signed-off-by: Barry Song >>> Reviewed-by: Christoph Hellwig >>> Acked-by: Vlastimil Babka >>> Acked-by: Michal Hocko >>> Cc: Uladzislau Rezki (Sony) >>> Cc: Lorenzo Stoakes >>> Cc: Christoph Lameter >>> Cc: Pekka Enberg >>> Cc: David Rientjes >>> Cc: Joonsoo Kim >>> Cc: Roman Gushchin >>> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> >>> Cc: Linus Torvalds >>> Cc: Kees Cook >>> Cc: "Eugenio Pérez" >>> Cc: Hailong.Liu >>> Cc: Jason Wang >>> Cc: Maxime Coquelin >>> Cc: "Michael S. Tsirkin" >>> Cc: Xuan Zhuo >>> --- >>> include/linux/slab.h | 4 +++- >>> mm/page_alloc.c | 4 +++- >>> mm/util.c | 1 + >>> 3 files changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/slab.h b/include/linux/slab.h >>> index c9cb42203183..4a4d1fdc2afe 100644 >>> --- a/include/linux/slab.h >>> +++ b/include/linux/slab.h >>> @@ -827,8 +827,10 @@ kvmalloc_array_node_noprof(size_t n, size_t size, gfp_t flags, int node) >>> { >>> size_t bytes; >>> >>> - if (unlikely(check_mul_overflow(n, size, &bytes))) >>> + if (unlikely(check_mul_overflow(n, size, &bytes))) { >>> + BUG_ON(flags & __GFP_NOFAIL); >>> return NULL; >>> + } >>> >>> return kvmalloc_node_noprof(bytes, flags, node); >>> } >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>> index 60742d057b05..d2c37f8f8d09 100644 >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.c >>> @@ -4668,8 +4668,10 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, >>> * There are several places where we assume that the order value is sane >>> * so bail out early if the request is out of bound. >>> */ >>> - if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp)) >>> + if (WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp)) { >>> + BUG_ON(gfp & __GFP_NOFAIL); >>> return NULL; >>> + } >>> >>> gfp &= gfp_allowed_mask; >>> /* >>> diff --git a/mm/util.c b/mm/util.c >>> index ac01925a4179..678c647b778f 100644 >>> --- a/mm/util.c >>> +++ b/mm/util.c >>> @@ -667,6 +667,7 @@ void *__kvmalloc_node_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flags, int node) >>> >>> /* Don't even allow crazy sizes */ >>> if (unlikely(size > INT_MAX)) { >>> + BUG_ON(flags & __GFP_NOFAIL); >> >> No new BUG_ON please. WARN_ON_ONCE() + recovery code might be suitable here. > > Hi David, > WARN_ON_ONCE() might be fine but I don't see how it is possible to recover. Just return NULL? "shit in shit out" :) ? -- Cheers, David / dhildenb