Re: [PATCH 0/7] abstract pagetable locking and pte updates

William Lee Irwin III
2004-11-02T01:55:49Z

On Tue, Nov 02, 2004 at 12:34:22PM +1100, Nick Piggin wrote:
> Why do you say the audits need to be better? No doubt there will
> still be bugs, but I didn't just say "ahh let's remove the lock
> from around the tlb operations and pray it works".
> I could very well be missing something though - You must be
> seeing some fundamental problems or nasty bugs to say that it's
> been designed it in a vacuum, and that the audits are no good...
> What are they please?

How many times does it take? No, and I'm not looking for you. You have
the burden of proof.

You yourself claimed you hadn't audited the things. The question
this raised was rather obvious:

If you didn't even look at them, how do you have any idea
it's going to work for them?

All that needs to be supplied is sufficient evidence, collected
from 20 spots around the VM (arch code), and for that matter, in
summary form ("I audited all architectures"). This should not be in
the form of a lie, not to imply you would do that. The sparc64 analysis
you gave is actually somewhat off but it doesn't really matter so long
as there's actual diligence instead of simultaneous claims of
sufficiency and non-diligence.

I am not even looking at the code. I have my own work to do. I
respectfully ask that when you do your own, you exercise the kind
of diligence I described above as opposed to the kind of affiar you
described in your announcement.

-- wli