From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1983AC83F27 for ; Wed, 16 Jul 2025 08:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93B746B0096; Wed, 16 Jul 2025 04:31:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EBEA6B009F; Wed, 16 Jul 2025 04:31:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B3CC6B00AA; Wed, 16 Jul 2025 04:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66D186B0096 for ; Wed, 16 Jul 2025 04:31:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 098A21402C9 for ; Wed, 16 Jul 2025 08:31:42 +0000 (UTC) X-FDA: 83669459244.21.3E28C87 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf04.hostedemail.com (Postfix) with ESMTP id 3A76340007 for ; Wed, 16 Jul 2025 08:31:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hpbMtJga; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752654700; a=rsa-sha256; cv=none; b=djdZOvi5nYKMg0FkQlYVACKCjMxpFNvzqFbUrMDpSPGhtwD2NlFRBQ+EQEpgF4mExRF0Ou k4Jctu0pttABrIw8xD0XZmfeCi+7mOCHIAh089FP7sNOCYvFx21aElCUo3DVLdAMQoo7NJ xnwVmorv5I605RfUKZ0PYvDH4X3Rz/w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hpbMtJga; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of xiaoyao.li@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752654700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tCetvLqAVu7j5hkcjG05J00oWB7AJjlewj8q20VOS+I=; b=VoTAIz3YYsnOwNe3DRY8atAUDLRqoEsrbPumanvELS6IUAOa5AXQTCRgwqYbeq6oDKN0l7 E97pCt1iM7GFz5mmUtDwdbHCqqoT0iZR3/qdcvPw3jEVwyi+Y6YQsCzX8bH7sWwZj6jqB2 1jd2uj0NOl2NmYfkKBzDqg5NVbIwY3Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752654699; x=1784190699; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=M8tEAX0g/+FHjCYjptDJd+fCfcSOLCtDuZhA2so9Vs8=; b=hpbMtJgaUEIJOyn0u5Y/4JXgpeKkq+ywmBUF2udZIi1lmFJ/jFVckYHM nrEAbrBdCFTAdHqJP7pogje7q+5MIBxuldxFdUI6OxQ/yiLvE3Cml9i60 D0oqmVgkKCVkyQRzonv9ft24usrPVivXWRK/Tz1A6S1nI0WhR8EGFO77d DOZFtO1S7KZigV8BKC1odyDpR8UTcE2stItqinRN2a2i4hoSKJ2a7GEIL jQ9uqlC47BmgPBXBo39HOhfo3/56BjDJQf8U/pYZA8SYVKJrdIlKEOmhR ts82wFLlnp7pHwdz3CTJ3bSKpxR5B7+Sb2g2QzXyvUAe3eUApbOJcnA7k Q==; X-CSE-ConnectionGUID: cYtRGg6jSMWQMz4+rwzUig== X-CSE-MsgGUID: w60fUX40QKCFz6B6Pa1JLg== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="65955346" X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="65955346" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2025 01:31:33 -0700 X-CSE-ConnectionGUID: nVOQ/N/PSSSwhIizbLv+DA== X-CSE-MsgGUID: O80dBXWoQ8GoQDCI749OMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,315,1744095600"; d="scan'208";a="162986525" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2025 01:31:18 -0700 Message-ID: <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> Date: Wed, 16 Jul 2025 16:31:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3A76340007 X-Stat-Signature: 6d87ikgfbc3deskotqc7bgit1zxj3qon X-Rspam-User: X-HE-Tag: 1752654699-318819 X-HE-Meta: U2FsdGVkX19ICW2gmFk+bAHHvq7BhxQax2N6uEjK3QI0tuwtPwnE/M6bo06jU3NE3uJJx3PrK0JmClyi0R6BQM7EZimZVar2IRD4NZC+2qOSq4NAUowF2emJsaVhoe2s3BvMp6SMfNBeLt6rYhJzgG2pNHphQJVq+nKdi99sRFsf7yUb81RSwlznbP5sZXysdJaI29ETJwTVCn8+5G99MqclW2ETBpuiUypA6GJF9gBc5GUOFNdpAH34FmvF5XPIHF9D4/Ie2G99IsJeCdX3u/hBDU8RyyCpjv8xXtnniEcIVqnampEfuZNFmVaE6lNo97coIGHEkDqkhiOQESYx1Wv82afnoE8KDKb2wuqON/ORqMiZeSryQt0BKqfCvkWC7K+9kBcfl4XrpQMrEeQ1E9rXLI0vynPdM3B6WYMv5lveq+ybVOQp4Mm4Oormmp/jGx8/DO8lFFJPwvoNx/EVhs9jCFCEXq+1/qR+9C4wNNxWIH0w2+Xp/YzznA4y96HXfz3KbMj2H0z3VOZt3mzOCm0VOEtm7tpjLqGkFdW+zWAsrdc8y/n/CvLtIGLvMrwrDZUv9I2CEDD/+z4uB6dYJFFPyHSb8u4xzoK2/SKGMVVye5sC1GAhPHM57fiXIR7njpjFSoUd6BjxzHzMttFcS/omEtZHh9KlWiMqkxcuGswqhD3hfKmednRlABSPmgtoc4gtPTmP4UFuesnMDc/3SpidoZIej7Si/D5LCy8N3gChsNNysJ2P9yAYVibiQ14fH+V800np+RyDJjloSZBZt582/1Hh3hGani6Kr59S+Cr4Y74DLGfTYy4QsPfdAVpCvIASXEoCS2zj9arpeU+nPeNTZSswXkKsMn5JSzgf0LC7Lwgt6l/6FXrCnC+qshsodlhyBfXE+wr5YJUbIu+pj4JDkzJW48nNwYu1bTVFAFAJRKYjjXVwmlKOkEX39osULw7EzUu32cnITlz4Twd kRin9ehR ZbidCYTkQ2kgwM2sVtKw7HfMCtKIGjut/MXfGNY7NQ4y5AIlbkcD+Y1hCUHXwUTK2LvcRA/XW+tq7ZWSRyleW/qgTt85xX/v+Dgd3ekO3K2uVLp5FjcjOSzQRbsPv+M9AecIUwf0AZBvKlwUzCG+J0x2bIBEk6++tHRnP0RKB6cs0h0QMWW8ljtUYASmTT0gUHcMniimwNSk81vSgAKPV4Xl+ndt0dBjBVoX5wQNI7KALemxNJGSB3ZrosB6iCW95nij6D3IakvECgSV+mK3c63+DlBfPk25h93vgcZGZeFjk+q8d8WcFI89IIrP0B0gc1uX7ly+xtALR+DCULiMdsiWsmyH5kAAAoOhAab0WVk73lr+sBuX9UIev0CYJOoFj3ZVaxhs6dot6ceM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/16/2025 4:11 PM, Fuad Tabba wrote: > On Wed, 16 Jul 2025 at 05:09, Xiaoyao Li wrote: >> On 7/15/2025 5:33 PM, Fuad Tabba wrote: >>> The original name was vague regarding its functionality. This Kconfig >>> option specifically enables and gates the kvm_gmem_populate() function, >>> which is responsible for populating a GPA range with guest data. >> Well, I disagree. >> >> The config KVM_GENERIC_PRIVATE_MEM was introduced by commit 89ea60c2c7b5 >> ("KVM: x86: Add support for "protected VMs" that can utilize private >> memory"), which is a convenient config for vm types that requires >> private memory support, e.g., SNP, TDX, and KVM_X86_SW_PROTECTED_VM. >> >> It was commit e4ee54479273 ("KVM: guest_memfd: let kvm_gmem_populate() >> operate only on private gfns") that started to use >> CONFIG_KVM_GENERIC_PRIVATE_MEM gates kvm_gmem_populate() function. But >> CONFIG_KVM_GENERIC_PRIVATE_MEM is not for kvm_gmem_populate() only. >> >> If using CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() is >> vague and confusing, we can introduce KVM_GENERIC_GMEM_POPULATE to gate >> kvm_gmem_populate() and select KVM_GENERIC_GMEM_POPULATE under >> CONFIG_KVM_GENERIC_PRIVATE_MEM. >> >> Directly replace CONFIG_KVM_GENERIC_PRIVATE_MEM with >> KVM_GENERIC_GMEM_POPULATE doesn't look correct to me. > I'll quote David's reply to an earlier version of this patch [*]: It's not related to my concern. My point is that CONFIG_KVM_GENERIC_PRIVATE_MEM is used for selecting the private memory support. Rename it to KVM_GENERIC_GMEM_POPULATE is not correct. Current code uses CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() because kvm_gmem_populate() requires both gmem and memory attributes support and CONFIG_KVM_GENERIC_PRIVATE_MEM can ensure it. But CONFIG_KVM_GENERIC_PRIVATE_MEM was not only for gating kvm_gmem_populate(). >>> I'm curious what generic means in this name? >> That an architecture wants to use the generic version and not provide >> it's own alternative implementation. >> >> We frequently use that term in this context, see GENERIC_IOREMAP as one >> example. > [*]https://lore.kernel.org/all/b6355951-5f9d-4ca9-850f-79e767d8caa2@redhat.com/ > > Thanks, > /fuad