From: David Hildenbrand <david@redhat.com>
To: Nhat Pham <nphamcs@gmail.com>, Kairui Song <ryncsn@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Baoquan He <bhe@redhat.com>, Barry Song <baohua@kernel.org>,
Chris Li <chrisl@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Ying Huang <ying.huang@linux.alibaba.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm, swap: cleanup swap entry allocation parameter
Date: Wed, 8 Oct 2025 12:26:24 +0200 [thread overview]
Message-ID: <41e7c36a-1349-4973-b133-316c823ead36@redhat.com> (raw)
In-Reply-To: <CAKEwX=PLfQCWZV7i9YP9UvcTmnHZXr635t3BX9D2uLEVr-Fnqw@mail.gmail.com>
>>> diff --git a/mm/swapfile.c b/mm/swapfile.c
>>> index 732e07c70ce9..534b21aeef5a 100644
>>> --- a/mm/swapfile.c
>>> +++ b/mm/swapfile.c
>>> @@ -1425,7 +1425,7 @@ static bool swap_sync_discard(void)
>>> * Context: Caller needs to hold the folio lock.
>>> * Return: Whether the folio was added to the swap cache.
>>> */
>>> -int folio_alloc_swap(struct folio *folio, gfp_t gfp)
>>> +int folio_alloc_swap(struct folio *folio)
>>> {
>>> unsigned int order = folio_order(folio);
>>> unsigned int size = 1 << order;
>>
>> One trivial issue for myself, I better update the kerneldoc too...
>> sorry about this:
>>
>
> LGTM, with the kerneldoc update:
>
> Acked-by: Nhat Pham <nphamcs@gmail.com>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-10-08 10:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 20:02 [PATCH 0/4] mm, swap: misc cleanup and bugfix Kairui Song
2025-10-06 20:02 ` [PATCH 1/4] mm, swap: do not perform synchronous discard during allocation Kairui Song
2025-10-07 23:52 ` Nhat Pham
2025-10-08 20:54 ` Chris Li
2025-10-09 15:32 ` Kairui Song
2025-10-09 16:58 ` Chris Li
2025-10-12 16:49 ` Kairui Song
2025-10-14 21:27 ` Chris Li
2025-10-15 2:55 ` Chris Li
2025-10-15 6:24 ` Kairui Song
2025-10-15 16:45 ` Kairui Song
2025-10-21 6:48 ` Chris Li
2025-10-21 8:44 ` Kairui Song
2025-10-21 7:34 ` YoungJun Park
2025-10-24 4:00 ` Kairui Song
2025-10-06 20:02 ` [PATCH 2/4] mm, swap: rename helper for setup bad slots Kairui Song
2025-10-07 23:47 ` Nhat Pham
2025-10-08 10:25 ` David Hildenbrand
2025-10-08 20:58 ` Chris Li
2025-10-06 20:02 ` [PATCH 3/4] mm, swap: cleanup swap entry allocation parameter Kairui Song
2025-10-06 20:07 ` Kairui Song
2025-10-07 23:49 ` Nhat Pham
2025-10-08 10:26 ` David Hildenbrand [this message]
2025-10-08 20:59 ` Chris Li
2025-10-14 3:12 ` Baolin Wang
2025-10-06 20:02 ` [PATCH 4/4] mm/migrate, swap: drop usage of folio_index Kairui Song
2025-10-07 23:48 ` Nhat Pham
2025-10-08 1:20 ` Andrew Morton
2025-10-09 15:33 ` Kairui Song
2025-10-08 21:03 ` Chris Li
2025-10-14 3:15 ` Baolin Wang
2025-10-07 22:20 ` [PATCH 0/4] mm, swap: misc cleanup and bugfix Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e7c36a-1349-4973-b133-316c823ead36@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=ryncsn@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox