From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48005C54E71 for ; Fri, 22 Mar 2024 08:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF996B0082; Fri, 22 Mar 2024 04:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F216B0083; Fri, 22 Mar 2024 04:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B36C56B0087; Fri, 22 Mar 2024 04:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A22266B0082 for ; Fri, 22 Mar 2024 04:24:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 45894A12AF for ; Fri, 22 Mar 2024 08:24:07 +0000 (UTC) X-FDA: 81923987334.11.5BA54E5 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf29.hostedemail.com (Postfix) with ESMTP id A3F3D12000E for ; Fri, 22 Mar 2024 08:24:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711095845; a=rsa-sha256; cv=none; b=jpX+kNKqpm2zYJ+jGfE2lJugYM0+/JAyOkBYv59CWMwAWJ34DLYcD+pZdZENtm6EUkDrSZ 7muYXjnnuwTyGuigSNbDLdnmuloGpxNPKboVzORk697bOq2Gy0pOJhBhy5UjSHBmIPvOJ4 5p6xLecCOKeiVrHgRJliPY6mVEA6hPg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711095845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cXDH9U8GTLW2+MyHrw/vM/GmKShUiKxOI8m5TYEP1OE=; b=ysDUv/GKsBmc3MIVzi1tAHFxLlSmQEwipZIHvbz9UsOtY5Xv9IhbKOAowb39Pw2oEP4zDM +jk/RJgWirQVO6bAKhNDdMG8RpYmZLso6n+spCKfA515IESGZ6om8Q64UgK8FHV5XG5pB6 Xuzpa/59G8onHtXWYRwugrBsptiVXtQ= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V1FfF2wBxz1h3Sh; Fri, 22 Mar 2024 16:21:25 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 5016B1A016C; Fri, 22 Mar 2024 16:24:00 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Mar 2024 16:23:59 +0800 Subject: Re: [PATCH 1/9] mm: Always initialise folio->_deferred_list To: "Matthew Wilcox (Oracle)" CC: , David Hildenbrand , Vlastimil Babka , Muchun Song , Oscar Salvador , Andrew Morton References: <20240321142448.1645400-1-willy@infradead.org> <20240321142448.1645400-2-willy@infradead.org> From: Miaohe Lin Message-ID: <41ea6bcc-f40c-a651-2aae-e68fdaeb1021@huawei.com> Date: Fri, 22 Mar 2024 16:23:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240321142448.1645400-2-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A3F3D12000E X-Stat-Signature: 6xtergjix511w3qo8kbyzuc47p6hx94e X-Rspam-User: X-HE-Tag: 1711095844-718463 X-HE-Meta: U2FsdGVkX19oIClW9bkrqHKqil5hg2ke/9FI+joL6jzgxtwsQ4SMMBB1++ii8ArjpMdPKmf1b6kKGEKDyhxm2KKEdyhZdDfSjdfHQnTbo3w9oIffJrL2+52c3ZAx+shvtg86WPA4eEAybR5a/+lKl13d2k/o4YBoh6C5ZXnv/97t3XucEXFF9qIN1ESagdH3V5RP+gHezwgssTpaSuppewsx4VHKNaQo3hXZHThTnHklM0ciKzkG3u5V4yag77MhcEkaPf6NBkaIiRo/FdL2SD0olsbFSfMOVkqxl/UfdRjsjU9bAzs2LMhtBnFu2aDcrAD3LbRBZoQoaHMtQga7j6ROfVcjRYojbUDGH19s68xMxVGNIqIK2I8aMsI/Ly7IDHjWuyjyegf4Zfy5lD9QerV95uExxeBaXRBmOjOlJsKCrkDWXlEEr3CJva5uO440RWs1hw1zpu4cVL4eKG83onn0zGbs1yqf4gW+RzJUc7+J3NdAcDS7R2h7HGWUxvjOrwi+PEF1HCI+FlsxazlfmrmpGYL3rnQFS+YuTQvwgiT+ogYGsw0jAUdfa4i3k1xC87gPUy0Om+QG4jw+dZleJioE24xCdjwZ5blAcKvqhvXE9SNiCuvclXyQlJlonFSelBnADfzcInmDddJJGmdsNcKwHvB0JGYFQascJpNzMpFEFcYgjtuF97ZCi6EazXMlgfd74nkbIKz2NnCoO3Dmx6Ws2T9rwUIdMYvWoSQLZEmC7vjbvCPxh4ONYThMoWZDvOP73V/AIQRAGptu+uv/jApJ84f17rWETmMhomag179ab9mgFNDQKyGv933OZgKmHIODeJodRwgkT4b0NowV+HFsmtbZTWU8mi3Bwbr3xImxyAAVV002DzO+sF2r4IBKhGW/xnWl/EslZL08JLCbpV7ADlAZu+3+tvvf+gFDiSMQ9/hxP9AzcQjZ/c0OfWnAAx+nDrr3XcyUsxgPH5g bHpR6Bsv BaKcEj5Ind8NZyAimpmGzeCOjU2SwdLZOgwDqCHhS9F0+EkvAEssrSBWDvhJG+ZAenrbh3QmufvNB2+2yGZEh76GUqIDRhhh8xWploW2p2jkOUsTLYwHWmRNHXjzX8aooudv5kSQaRGiUXxNUmmL5yY6NARSkvekqGcmtOyZbd1+25DqwZLwYgSzu70f0mfcPDUnI4RE9IThCO537yQL6L5KWm46U/19mn9Qe2k1rHFMojGw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/21 22:24, Matthew Wilcox (Oracle) wrote: > For compound pages which are at least order-2 (and hence have a > deferred_list), initialise it and then we can check at free that the > page is not part of a deferred list. We recently found this useful to > rule out a source of corruption. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/huge_memory.c | 2 -- > mm/hugetlb.c | 3 ++- > mm/internal.h | 2 ++ > mm/memcontrol.c | 2 ++ > mm/page_alloc.c | 9 +++++---- > 5 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 9859aa4f7553..04fb994a7b0b 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -792,8 +792,6 @@ void folio_prep_large_rmappable(struct folio *folio) > { > if (!folio || !folio_test_large(folio)) > return; > - if (folio_order(folio) > 1) > - INIT_LIST_HEAD(&folio->_deferred_list); > folio_set_large_rmappable(folio); > } > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 23ef240ba48a..7e9a766059aa 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1796,7 +1796,8 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, > destroy_compound_gigantic_folio(folio, huge_page_order(h)); > free_gigantic_folio(folio, huge_page_order(h)); > } else { > - __free_pages(&folio->page, huge_page_order(h)); > + INIT_LIST_HEAD(&folio->_deferred_list); Will it be better to add a comment to explain why INIT_LIST_HEAD is needed ? > + folio_put(folio); Can all __free_pages be replaced with folio_put in mm/hugetlb.c? Thanks.