From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836F5C25B78 for ; Wed, 15 May 2024 02:47:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB2536B0177; Tue, 14 May 2024 22:47:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E631A6B0179; Tue, 14 May 2024 22:47:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50E36B017B; Tue, 14 May 2024 22:47:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B73CD6B0177 for ; Tue, 14 May 2024 22:47:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3CD341A06FA for ; Wed, 15 May 2024 02:47:15 +0000 (UTC) X-FDA: 82119093630.22.F7F67D2 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id BA67014000F for ; Wed, 15 May 2024 02:47:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715741233; a=rsa-sha256; cv=none; b=n5f/oc3i81X20xvvXA6ZdE5DcIaTSdQ99fZxP1xUbkf2ps3/7hxOtG8vSD9Np21moP7mMl fYBZ+0t6LvgphI+ZZUyHFRSN3WXfxQRmxSkfB5XC1/GuB/aIPhX9XSXQdjywJOZ6QQbg++ yoTH/kL07RoSV/6bMWYUwtyXCRul/2Q= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715741233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWI5bgXmqsNPJRMEQUJSHBHxTumSuTFLjCmBxTnuUuo=; b=hHRq/Jtl9F/NdzLbFf3YCcb6SZiv5ln30MTrnpYECngrd8Na9bJphmnSJ/ChBXVizuSHRv xNVKz7UlTEH7M/x1Xu3mn6E6grvRUa8U8HETmqpQgRMr60Bov42oY5E5QOMrhT3pkc7yRY iGNXJDr4avQ1VKlFGmP+tjkINby6dXU= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VfHZz5Xn0zgZCs; Wed, 15 May 2024 10:43:07 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 9CF52140155; Wed, 15 May 2024 10:47:08 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 10:47:08 +0800 Message-ID: <41fdf6cb-ec1b-ff07-44f4-3ba01b45ebda@huawei.com> Date: Wed, 15 May 2024 10:47:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next] memcg: don't handle event_list for v2 when offlining Content-Language: en-US To: Roman Gushchin , Michal Hocko CC: , , , , , , References: <20240514131106.1326323-1-xiujianfeng@huawei.com> From: xiujianfeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Queue-Id: BA67014000F X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: hsrafi4xhsb93tmhyam5rqujjcuh1hpq X-HE-Tag: 1715741232-234086 X-HE-Meta: U2FsdGVkX187BN2dtOVNBH0Wh9yJGHjIc2RcaRRDsUoByvNlkBQT6jppP4Z5uchmmfVDBXMjw9/iRokJH78318yf5nWVsNDL98X4ITMbdJX856YLBlz1SVpQXXOPopYOrNFD7mmqVV9OlWwuol5zoFWn6CqayLaTwFiXG4IDYytfKA4r7PCd+yVKLumnlZl72M0TYHTRhmGGa4zDXxMJ2pOlR2fZ9qmQHA4JVdn2jjtnOkJQxfqF7ZNDlCxktG6agA09LDziRFNeYl9XodQi93HMaknEj5s4nTGzsL2g7dJYXRaSpKSflEXZjBgzsJSQkM7/zDv638siomChexAWahKVHkxDXZ0qsVEq05+Qy7HmM+s+e9z5lTWHxgxiNHMsGiO8rD1LGRmiKXAPI9EB+Z2G92GUxDOLH6mshePFdiTbU1X7VFWDz81KHos3Pe3i1spLBawmiJr88KJoCPHYz9vYGpxldF0Ys1zHtaigxWgMBPa7onrthSxjtuL//cir/MabO/y2i/CwEx5yFTxBy0Q7jrN+0hLpp3iOIv5ukMYxLuRFUKVUcqbVlZO3i6TocLstqQYC0DWcRc+kDpnxsdUxseixZoSaasMt8z58/YYaS1me4hov78QnOX3kF9/nN3OgZjwbk/v5Gqey8i/ONuNckLLjflBbLHPY60BMxtyGUqIEWU0HyF9IpGk1X4WFv51hXKPg6uFydjXhZpNlUquK/rRdG7Pag572giD/iNT4qFKwl7tIszIGSG5MJhqYmnv38Ytdv/Z5u1UzZDgO4WobP4oV7pLB595bInn0yRD807zppwoE2UcDQEonUT0lojBMUohKc3r5y9wpeSNYHxb6+KnLXuSQkjpcmxn1/yVlHhx/1+eXraKSNFcZNbngcC+HcjsPgyrZCxrfZ6bSorPnVlveSOex1YrV2ZrNftNYWlMhz2/v3zahfTXs0FbDnRpCX9OlBWfaGboLAGs Yr11pv0l 2ZqdGe4zp/O8yzhiu1qfgwkyCRcUZBjsjD+fl8o/BlV5ePwuoH5xc27gZFoJ8/vaiO9ZGms3YkI67M/wuDI02CmDYG+ZjEPt6PKzC0iEtp95Dh+PIu0M+ZbkEAxPCg85dpRipM7vgLy0vIXveVKQ4tu8cVYLEu+McEIQDB4Y5l84Lqx6rkpEBb6ANFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/14 23:21, Roman Gushchin wrote: > On Tue, May 14, 2024 at 04:09:58PM +0200, Michal Hocko wrote: >> On Tue 14-05-24 13:11:06, Xiu Jianfeng wrote: >>> The event_list for memcg is only valid for v1 and not used for v2, >>> so it's unnessesary to handle event_list for v2. >> >> You are right but the code as is works just fine. The list will be >> empty. It is true that we do not need to take event_list_lock lock but >> nobody should be using this lock anyway. Also the offline callback is >> not particularly hot path. So why do we want to change the code? > > +1 to that. > > Plus this code will be moved to a separate function in mm/memcontrol-v1.c > and luckily can be compiled out entirely for users who don't need the > cgroup v1 support. I found the patchset you mentioned, Thanks. > > Thanks!