From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7238BC61DC2 for ; Wed, 26 Aug 2026 08:17:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA5F6B008A; Wed, 26 Aug 2026 04:17:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 843E76B009F; Wed, 26 Aug 2026 04:17:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 733576B00A1; Wed, 26 Aug 2026 04:17:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42A706B008A for ; Wed, 26 Aug 2026 04:17:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B2C8A1202D5 for ; Wed, 26 Aug 2026 08:17:07 +0000 (UTC) X-FDA: 85142715294.03.2E7E504 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id EF00C40006 for ; Wed, 26 Aug 2026 08:17:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="N4nY/QZb"; spf=pass (imf27.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1787732226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qugp8jQqwl7nXNbFsBvIRYiMaOQwEcXlebRQocQb2Bs=; b=OHNTmESnsJ/6UC++vZIrSj9ZOMwwotndQjX9GQSZ/2Tn6HzRr8yXBlxQrBqTrS49AqeiRw c7giCh7cDYI6PffO0gVXPCHCSfZZxggR6IPAEip7ALWtPh2wvDJJ9BHTe39rDA+ZEr/x53 6FJFwAxvL/LuJZRW21qHK9RhcpHNUBk= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1787732226; b=J+T16AUt9cJAOdxzNSWUSnjrKGQA0ipEPyiBR0pRTS/GN42hrkWgJ2hEiyapx4bKyFaX22 PXqd+WkFSlfgasXVC+8a4j/fL5Giv1AqaF+dRQ0WmRWvv2EVDMnT98MQq10aUe6yRrnkcP 7EuIC9lbo9ulErKfNGGjtPCh1Qt0hCU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="N4nY/QZb"; spf=pass (imf27.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 296C541E9C; Wed, 26 Aug 2026 08:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2C01F000E9; Wed, 26 Aug 2026 08:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787732225; bh=Qugp8jQqwl7nXNbFsBvIRYiMaOQwEcXlebRQocQb2Bs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=N4nY/QZbRK/Uf12tn8KyxduT8NiRFILfiQnJgGqPvpZoswxqf6GFeXVFytpQ/Un0l Jlbxxiq8ReOSR+3LU5xRqFhIQaXh8q+N65OwgwGkN6SCP5hvHG4TFk8hz7qlywNEdT ZopzGSDk2QaQ3IC/OZAw7+Fd2/DJdDBuaRf+TReITsuGPxCvdCTZRK+6ThqJ7RG/PR PY2CMRgS2XuaeQ5Ku6vuWRVWa4VUPeu4zqPl2hqh8y1o/K77Us0cifns/VPbyAhF2u XSSglyKrYs/3AeuOW/kDOYt67koqSG6DCyHXf7X5VTOgwsd1S6sF9ou5KTtpVzJ45p h5gH1kE7Tw/ag== Message-ID: <42695df0-3962-4126-9afb-9a1905d096a0@kernel.org> Date: Wed, 26 Aug 2026 10:16:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] mm: khugepaged: fix swap entry value to folio_pfn() To: "Lorenzo Stoakes (ARM)" Cc: Vernon Yang , akpm@linux-foundation.org, nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, zokeefe@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Vernon Yang References: <20260824092935.73892-1-vernon2gm@gmail.com> <20260824092935.73892-2-vernon2gm@gmail.com> <6a9c2369-5589-4f2a-bcfe-c6e3b46a1ccd@gmail.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EF00C40006 X-Stat-Signature: ymz8axr1fzfwen9tu65g7hap4f5f5bak X-HE-Tag: 1787732225-236323 X-HE-Meta: U2FsdGVkX1+BNMbD5xmeTHg/RWo53NmzrZpdIrvVhF8UpOBOHMw0uQKh9IfraY/LpENtMd0ownlxpUMdJBD1zdpfJ2xUVAIk2ux6x9v4kXrjNqykuuMz8UkD1mV7nhRIYE3/puzArM8B10J0Ow7pebAgaxaC8c6L/Xzd8tZ/OSrAgqN4kJGZV5Sfz4VLtYzLOxdh5VWE1rtagsfvhVDbCJFVeEd3O3NsqMbLVFTG9wCX/9zjtZU0DMQX55+LvJosKCSdrSs0yUYWgS3hBRzSkAWrUy5rrdxzEMr3N3MYNxWNB5iJ3bRILrBvwl5UKV+oSTBdMjAF+biIMmsuTay+GPaVhVHzyRXsrajaONRM23fEomv+3zvg715rNO8kIVNpjr9VQpH+4nRry18b0CP5zq2DOkPpjKRjhoeqD3CgIqjpQ6mNixan17j80DUrl9iwB8E9QrveNfcIOBAuDYH5tq8XMFxHazwUiq3vDNSvNshN0A0o+9/MgaCn7v5AJ6tPgHGEbbOM5uPrqt+3dNq1uLuOnQmrzm3A35F4S0thZeQaDNr4mnxXsYjKGfX6PL6VGLGOB2BZHH9MddvRKhArXSpmRMcK/rtf1QISV8DH3uq40Q6Oz0nt5RRl3NE1ItWwpcF5FtB0CHCtRozUCX56CVpup24hWZCwn9lYDBAYeWo5aG7/B+8bCB9q2tgHRqrG6XsmWtfKcnsW9qQ1dvaRbprYAzed/7cLN2AalaDqE2UvsP0i5VD2zyyAZl9Z64ca4c+Kffmq8vbkXsDg10i/Zh6nJpUBCnA1xIX6/xHCgFElTWZYkNOE/L+2qtdHdZeMIrSGEgyko/NGILRTMraYzEkZXQtnDeBcjogWDSW3+QzKkH3/9de01t142Ej6s5Bz/au8RgzrCEzWSrUVf05m1Z30FZIEk+Xv6UrhHyO/ax0sd02hIoN7Na5TvzMV3kzr9ZNPdeSKEd+E/bjdSAC xsgzw9og h71a/rd72iMQTvJuyKxO7TBTom1DEu35sFN/ZYZ4ucqbBaRkQWiZcq6jvI/7UyZiBrUoFeCBUG4SdMbRMavd7aI6+CL89w9FUfczbkOg/FUDkMdwBlrvGKcUsz1hSzODX88EMVEa5Vbda7H5NsKd8j5eYYE3bF07IDTJywBcJ3NQOjjU053GVdtSta06qFiCmawrR2Mls/kwR2KJ87VuMsF0XED01IoYb948V7DXN4MJr2NZ9vtlTUYrAopWmmU6IpDySJFv5oeAFV6hlq2CGJhDq1TQGQaPfrZ24lCy7AteYWthX9xu7OPNDAcGyGXV+hDOS8XrHTc45vYc= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/26/26 10:11, Lorenzo Stoakes (ARM) wrote: > On Wed, Aug 26, 2026 at 10:08:58AM +0200, David Hildenbrand (Arm) wrote: >> On 8/26/26 10:07, Lorenzo Stoakes (ARM) wrote: >>> >>> I find this name... problematic :) >> >> Elaborate. > > It's overly long, I read it and am confused as to what is 'problematic' or not, > it reads weirdly in English and pfn_xxx is the usual convention for naming of > pfn's anyway. Excuse me, what? Are you now just making up arguments? > > I made a suggestion in the reply as to how to refactor this to avoid the need > for assigning the name like that anyway, if you branch the result == > SCAN_SUCCEED then it's implied. How is something that doesn't state the purpose make it any clearer? -- Cheers, David