linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: mtk.manpages@gmail.com, Andrea Arcangeli <aarcange@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-man@vger.kernel.org
Subject: Re: [PATCH 0/5] {ioctl_}userfaultfd.2: initial updates for 4.11
Date: Wed, 26 Apr 2017 09:23:45 +0200	[thread overview]
Message-ID: <428a9209-e712-7067-ab11-9c35cddcd89e@gmail.com> (raw)
In-Reply-To: <1493137748-32452-1-git-send-email-rppt@linux.vnet.ibm.com>

Hello Mike,

On 04/25/2017 06:29 PM, Mike Rapoport wrote:
> Hello Michael,
> 
> These patches are some kind of brief highlights of the changes to the
> userfaultfd pages.

Thanks for the patches. All merged. A few tweaks made,
and pushed to Git.

> The changes to userfaultfd functionality are also described at update to
> Documentation/vm/userfaultfd.txt [1].
> 
> In general, there were three major additions:
> * hugetlbfs support
> * shmem support
> * non-page fault events
> 
> I think we should add some details about using userfaultfd with different
> memory types, describe meaning of each feature bits and add some text about
> the new events.

Agreed.

> I haven't updated 'struct uffd_msg' yet, and I hesitate whether it's
> description belongs to userfaultfd.2 or ioctl_userfaultfd.2

My guess is userfaultfd.2. But, maybe I missed something.
What suggests to you that it could be ioctl_userfaultfd.2 instead?

> As for the userfaultfd.7 we've discussed earlier, I believe it would
> repeat Documentation/vm/userfaultfd.txt in way, so I'm not really sure it
> is required.

The thing about kernel Doc files is they are a lot less visible.
It would be best I think to have the user-space visible
API fully described in man pages...

Cheers,

Michael


> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5a02026d390ea1bb0c16a0e214e45613a3e3d885
> 
> Mike Rapoport (5):
>   userfaultfd.2: describe memory types that can be used from 4.11
>   ioctl_userfaultfd.2: describe memory types that can be used from 4.11
>   ioctl_userfaultfd.2: update UFFDIO_API description
>   userfaultfd.2: add Linux container migration use-case to NOTES
>   usefaultfd.2: add brief description of "non-cooperative" mode
> 
>  man2/ioctl_userfaultfd.2 | 46 ++++++++++++++++++++++++++++++++++++++--------
>  man2/userfaultfd.2       | 25 ++++++++++++++++++++++---
>  2 files changed, 60 insertions(+), 11 deletions(-)
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-04-26  7:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 16:29 [PATCH 0/5] {ioctl_}userfaultfd.2: initial updates for 4.11 Mike Rapoport
2017-04-25 16:29 ` [PATCH 1/5] userfaultfd.2: describe memory types that can be used from 4.11 Mike Rapoport
2017-04-26  6:52   ` Michael Kerrisk (man-pages)
2017-04-25 16:29 ` [PATCH 2/5] ioctl_userfaultfd.2: " Mike Rapoport
2017-04-26  6:52   ` Michael Kerrisk (man-pages)
2017-04-25 16:29 ` [PATCH 3/5] ioctl_userfaultfd.2: update UFFDIO_API description Mike Rapoport
2017-04-25 16:29 ` [PATCH 4/5] userfaultfd.2: add Linux container migration use-case to NOTES Mike Rapoport
2017-04-26  7:16   ` Michael Kerrisk (man-pages)
2017-04-25 16:29 ` [PATCH 5/5] usefaultfd.2: add brief description of "non-cooperative" mode Mike Rapoport
2017-04-26  7:18   ` Michael Kerrisk (man-pages)
2017-04-26  7:23 ` Michael Kerrisk (man-pages) [this message]
2017-04-26  7:43   ` [PATCH 0/5] {ioctl_}userfaultfd.2: initial updates for 4.11 Mike Rapoport
2017-04-26  8:43     ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428a9209-e712-7067-ab11-9c35cddcd89e@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).