Re: [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes

Pavel Machek
2005-06-26T03:09:25Z

Hi!

> > > 4. Remove the argument that is no longer necessary from two function
> > > calls.
> >
> > Can you just keep the argument? Rename it to int unused or whatever,
> > but if you do it, it stays backwards-compatible (and smaller patch,
> > too).
>
> Why do you want to specify a parameter that is never used? It was quite confusing to me
> and I would think that such a parameter will also be confusing to others.

Well, yes, it is slightly confusing, but such patch can go in through
different maintainers, and different pieces can come in at different
times.

If you delete an argument, it is "flag day", and I'll (or you) will
have to coordinate it with akpm as one "atomic" patch.... As lots of
different subsystems (and => lots of maintainers) are involved, I'd
prefer to keep the argument for now.
Pavel
--
Boycott Kodak -- for their patent abuse against Java.