Re: [RFC] Fix SMP brokenness for PF_FREEZE and make freezing usable for other purposes

Nigel Cunningham
2005-06-26T10:54:14Z

Hi!

On Sun, 2005-06-26 at 12:30, Pavel Machek wrote:
> > Index: linux-2.6.12/arch/i386/kernel/signal.c
> > ===================================================================
> > --- linux-2.6.12.orig/arch/i386/kernel/signal.c 2005-06-25 05:01:26.000000000 +0000
> > +++ linux-2.6.12/arch/i386/kernel/signal.c 2005-06-25 05:01:28.000000000 +0000
> > @@ -608,10 +608,8 @@ int fastcall do_signal(struct pt_regs *r
> > if (!user_mode(regs))
> > return 1;
> >
> > - if (current->flags & PF_FREEZE) {
> > - refrigerator(0);
> > + if (try_to_freeze)
> > goto no_signal;
> > - }
> >
>
> This is not good. Missing ().

Thanks!

I was just going to begin a search to find out why, after applying it,
everything stopped dead in the water :>

Nigel