From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D9BEB64D9 for ; Wed, 14 Jun 2023 08:50:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D79738E0005; Wed, 14 Jun 2023 04:50:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D29428E0002; Wed, 14 Jun 2023 04:50:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCA5A8E0005; Wed, 14 Jun 2023 04:50:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B02248E0002 for ; Wed, 14 Jun 2023 04:50:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6D9C5A085E for ; Wed, 14 Jun 2023 08:50:16 +0000 (UTC) X-FDA: 80900731632.03.607CFDB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 35F17160009 for ; Wed, 14 Jun 2023 08:50:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ACAlU0Br; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686732613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5B5lUZSMuFMfr+ki8+YhMEK1JVBx4VqBUAAdrrVgwzA=; b=45uzUwvVBtdmYagQNnL/XYOvuNVKZNbnasGbletLxSVBX7VUY5IB0A5yNg4iZUNTYmM/vV WX12DEpiwloLwZO6cGl/Kee9jWd9lvEf4s3snsXRgi13uOfourTj9rJqcK8MnLzHg7Tbe2 KJ49uliyseWwB9b64jXCdysmdqWCdFY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686732613; a=rsa-sha256; cv=none; b=Ix423K4Z6dlbHI/6ICiNS8UJK27L/dXMsKhD6OD+L6lvy20kiH6Ku8zibpvuvgjgkPQ4GP CYmycfTK4jjXioDWvdcLWij7hcqNi+pc9MmPzNxWwQej9gRXwQ1xzi8746obL8/Lldw3lW FAg4RyMv4yNCNIyqOSOf4WSIk4n2gGc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ACAlU0Br; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686732612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5B5lUZSMuFMfr+ki8+YhMEK1JVBx4VqBUAAdrrVgwzA=; b=ACAlU0BrVo8Gqo+n7Bkr7SEMO8eimZulsMOLtu/h2d3/0c4ocmURxXVjyhP33wAH7gI9R7 ivNBNilSCJfiuUEK9HiKkuypSKGwxYj1rUdteI+d99vDaazvQxHk2vYW8PQmkRNUORn+6l 44J0jg3aTxXqzR0MuEuxCTqkSeXVvdM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-57uPyA2WMWisa8gRwwK76g-1; Wed, 14 Jun 2023 04:50:09 -0400 X-MC-Unique: 57uPyA2WMWisa8gRwwK76g-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4f62cf0bb78so5299388e87.1 for ; Wed, 14 Jun 2023 01:50:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686732607; x=1689324607; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5B5lUZSMuFMfr+ki8+YhMEK1JVBx4VqBUAAdrrVgwzA=; b=HfWUHH21HqjUiKS9+/EU7XpgHD8ovNZbkPDYee4XHuoGMvgEufiCgDxLqEy56ZvJdK rBQ2ODnM1h1hwMIN18CFxKUBQlHQulgzMmxbnVIo1wQY0QkpXzc9tSKMsvxN6HZHcJ0x h1ictQTjElwwk6emWUV1Dazh81kv1vCuO+zUAiE+K7zVtNRuKZt64nvX5O8DkF2EE5g+ 6o0Es5NAOPVF0GJCXbcDErlBUWBnaca2vf71Y8qRI2UDpNHuou6WEX/JNL/22MgBiseR EvSl3PfNSh49wVnxgy0dAr9u5yjh+xsZofev0Ha4+W7ygiYtpYKU4G4mJXFjFow5XCOE L5KA== X-Gm-Message-State: AC+VfDx3Htna1rKd5M7jYn9b0ziEre3bVNfsjSWoRC4s3A6jUUNov56p vBl9MkqppbhocuSxXlgW5cq+BthgYvlQlLMhFE9aEwFZI53SSZGEJn4rQuplrSR2TVVEZnM7Nmd MWGJhf3nccWo= X-Received: by 2002:a19:5001:0:b0:4f2:769a:120e with SMTP id e1-20020a195001000000b004f2769a120emr7189218lfb.2.1686732607636; Wed, 14 Jun 2023 01:50:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QcwYxgnMHB8zt+5nd3J5mySSLf2a3UMLrVPLHrR3mI+MG14rCyMyhPKMJcoHtf3oiHRZR5Q== X-Received: by 2002:a19:5001:0:b0:4f2:769a:120e with SMTP id e1-20020a195001000000b004f2769a120emr7189170lfb.2.1686732607272; Wed, 14 Jun 2023 01:50:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c294500b003f7ec896cefsm16882043wmd.8.2023.06.14.01.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 01:50:06 -0700 (PDT) Message-ID: <42a95041-e1a7-f343-8432-e2ce07af4e9e@redhat.com> Date: Wed, 14 Jun 2023 10:50:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 05/42] mm: Move VM_UFFD_MINOR_BIT from 37 to 38 To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, broonie@kernel.org Cc: Yu-cheng Yu , Axel Rasmussen , Peter Xu , Pengfei Xu References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-6-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613001108.3040476-6-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 35F17160009 X-Rspam-User: X-Stat-Signature: gp4mrogihbr4r4fc7pg4ygxuum4upxra X-Rspamd-Server: rspam03 X-HE-Tag: 1686732612-282824 X-HE-Meta: U2FsdGVkX19glGsMoGMuJk0mxX5Zu5ltuQhyHCNiFbJ0is+iKqGT35Jb+JN8rTvYyJqcFNw5oy4Fs04r4QlZX/qeCpLz1QabLuE5OS3ITwWSjEbW33vyzogaNQ6kteYHtjw64ErsofvQQd6Oyt/+V/doHf9HgTpR5VpBE5rMYyKwlsMl2wo5csoEJ5cKMEv4WUUHqBI0rGpxL8mdrnHY4VJfL1UqRsNIfNqfD4MQ8aUz5k+sjKqk81fAapXLzLY0vTm5g8DhKCVtkmpwcOshOEYhcCZY0JC/aGoJiUoDanEGzgxYM2PxnhUNEMyW23YKdA0fQ0cfiEP4CJsYvqxdFNzH5mR1mm0mBIUV6B690NT1sd6moKQPPsmwgYaj/naT/x9wW+vDRIrTi29TeEIkfo8j8fBLHum8rpPXII9nrUVcggHUMEmX8G8Kh9hq+92hxym0GpDDqSTNBgPbTXvVTlfiT212YdyF7Sm/GJKQGRUfaPIPTg7+Wt6CQRow18byogwzr8Ol+bt23l8TICaplBl0q4cF4YlodFKW3XJMjuR3+JzKJRuojYpnHWFxhCe6ZWxjlZUey2dHG/fchERdRJI0jkzxQNTK+QtNl8aWHFHpO/s6uii/Xk8EKDTwWQHZPNzlQQTXqApZ6rNoXbSSYr8jCJqWVHQ6psAZNtgKJXNOWg+9zruHEkdzOVc0v9AAJjExv3JxpxFajJlqwL3h57ZqkQg8NI6+RSqe81mJihR2KX8qiGq/5XOfPpdHFE19Xy2ZJQY4hXys9bghFLTqPGLTqKW1XhwZz/R7+C1FDLwSjtBQWQuovYFpig7v/KcHlJuZ9t//hg6+EOLjPzo6DkN9bTdVriVYJ2YOQiIjT3zJrZBxZQ0vbDEUDj0sevlAW5G2jCQdksWfqmw7mexfbja0FbgtveAI4RlkhVA1TKVRvO5QKQVhy1EPqqLKmViCKs5UmiNI+K/Sj+KojpB KXZe/Yxh JO+Hn/CU4eC+c1Z8FsaBjdxF3wUUVDU90EXvna0ySXWeXIs99W9TvklwD1yq8rRqTMURWS+/lMiDzlVmBqpFbK7xYl3iLntx+/d79OWVJ3aa5woHFoEp9RddoA+nOPjalJKIFeTD/0A0X2iWeaTmkJopycEhVvgN4w8G/nhOL9PxQiWMdTp4D000u0lJVHSJVwnRHIMaEWPMTksZbxT0c8Y+TmspILDCtXpe3xrDbHgFBGfCIPfgjBpJRbzrUHeYvDlIzVUGtyrWC14VYAuIWj3fSDDWZM78KglbdQ2GHYTCwcmQY71fUicdeuX6S7BMHAmyBR6LO7W6yTwo1+K1bI7V4GwH9zAPZKfsm3ojmojMIKlCFIZds5tS/klfvOLsFzwEndNrd2pq9SMZaK1cKbB4XU7PxObIU+7qxGUigzx04N2m8vtyFNDhtTd2QC9b9Dm+KoYmT0zKf9cHsH0PxA4xarEqKkdI25fULCvOjwJsQEp1Y/+9+fqmNwX6HxINYzXsZk/T+RXmlX33OU2HZZhmEhwfEgKQq837+ZpXwEhg8C6jFn8+/tAc4KpcGg/V9+t99BEm5LyhoQ5ZLFT1VZn92FRiHXW2QlZSJTsQXH3PfAUsjkW2G3YQ1FbCzJRSIjrBV976DWTHDNvyouAJOzO8ygwLP9zzKpYgZ703yVun2D0rxDYxip7MTstmbXwJpQEN4yd06VxxibsU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 02:10, Rick Edgecombe wrote: > From: Yu-cheng Yu > > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > Future patches will introduce a new VM flag VM_SHADOW_STACK that will be > VM_HIGH_ARCH_BIT_5. VM_HIGH_ARCH_BIT_1 through VM_HIGH_ARCH_BIT_4 are > bits 32-36, and bit 37 is the unrelated VM_UFFD_MINOR_BIT. For the sake > of order, make all VM_HIGH_ARCH_BITs stay together by moving > VM_UFFD_MINOR_BIT from 37 to 38. This will allow VM_SHADOW_STACK to be > introduced as 37. > > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Reviewed-by: Borislav Petkov (AMD) > Reviewed-by: Kees Cook > Reviewed-by: Axel Rasmussen > Acked-by: Mike Rapoport (IBM) > Acked-by: Peter Xu > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 9ec20cbb20c1..6f52c1e7c640 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -370,7 +370,7 @@ extern unsigned int kobjsize(const void *objp); > #endif > > #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > -# define VM_UFFD_MINOR_BIT 37 > +# define VM_UFFD_MINOR_BIT 38 > # define VM_UFFD_MINOR BIT(VM_UFFD_MINOR_BIT) /* UFFD minor faults */ > #else /* !CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > # define VM_UFFD_MINOR VM_NONE Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb