Re: [PATCH 1/9] add defrag flags

Paul Jackson
2005-09-27T19:30:55Z

Joel wrote:
> We may not be able to use the same flag after all due to our need to mark buffer
> pages as user.

Agreed - we have separate flags. I want exactly user address space
pages. You want really easy to reclaim pages. You have good
performance justifications for your choice. I have just "design
purity", so if for some reason there was a dire shortage of GFP bits,
I suspect it is I who should give, not you.

> > +#define __GFP_BITS_SHIFT 21 /* Room for 20 __GFP_FOO bits */
>
> Yep.

Once this is merged with current Linux, which already has GFP_HARDWALL,
I presume you will be back up to 21 bits, code and comment.

As I noted in another message the "USER" and the comment in:

#define __GFP_USER 0x40000u /* User is a userspace user */

are a bit misleading now. Perhaps GFP_EASYRCLM?

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401