Re: [PATCH 4/9] defrag helper functions

Joel Schopp
2005-09-27T16:07:28Z

>> +void assign_bit(int bit_nr, unsigned long* map, int value)
>
>
> Maybe:
> static inline void assign_bit(int bit_nr, unsigned long* map, int value)
>
> it's short enough

OK. It looks like I'll be sending these again based on the feedback I got,
I'll inline that in the next version. I'd think with it being static that
the compiler would be smart enough to inline it anyway though.

>
>> +static struct page *
>> +fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
>> +{
>> + /* Stub out for seperate review, NULL equates to no fallback*/
>> + return NULL;
>> +
>> +}
>
>
> Maybe "static inline" too.

Except this is only a placeholder for the next patch, where the function
is no longer short. I'm going to keep it not inline.