From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CDDC5B549 for ; Wed, 4 Jun 2025 13:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62CB86B05DD; Wed, 4 Jun 2025 09:09:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DD2C6B05DE; Wed, 4 Jun 2025 09:09:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5BF6B05DF; Wed, 4 Jun 2025 09:09:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2D1AD6B05DD for ; Wed, 4 Jun 2025 09:09:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8739B121471 for ; Wed, 4 Jun 2025 13:09:25 +0000 (UTC) X-FDA: 83517749490.27.257437D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 4D5C740013 for ; Wed, 4 Jun 2025 13:09:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fh6NhztJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749042563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oVf38CoQ+gWhEl7SxQYlaDaoqj2qRHCVOsqMarLV2fI=; b=zpO/z0iCat7H9G3X11QEriCnFmn8D18C2oeMY8oFt55e3/zWZQZvUUZplpsOPXVKj+O8oq 59P+ENpuYAhStKN4AlKIQ5+g+uhEcU+s9GQgKOaJW31GbQ4PG5EKgYjQAjCHxIzupUjh09 4cc759Q8slvC6yVj2Y+q4o5M+e297Gc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749042563; a=rsa-sha256; cv=none; b=AGKshiCrE5Y9q8/50S7NHM0wa9h/4uUz3NwdCGeI/m5lrlumyBD2GcdyoZt+VKKtzMZSqB 7qamDEAJito9Y+MElSUgwjIp9+rlY5OeELUGIPZx3q8W1iwlxj3Db/pP3cCy8SyHx6+3pS thTv9akh9SJXQMhq5KoR22kYUAjxoAA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fh6NhztJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749042562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oVf38CoQ+gWhEl7SxQYlaDaoqj2qRHCVOsqMarLV2fI=; b=fh6NhztJaYj3NPIssVhM+6fw51IbVEvZT3Dntbyx90nq+AkaxLyTXQtDakaeKu/3OBiywc Itq5l96hw65yd/u++6yrRlgfGz/LsvTGpP+f+EqUOaSs4tbNlmF2F2k9rXXQtSiIYv9zO0 uf57AixbUXiCrDiyk/1I9Qad38TvCxc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-DW4Hhvk1NBaAiYV3hFL3ZQ-1; Wed, 04 Jun 2025 09:09:21 -0400 X-MC-Unique: DW4Hhvk1NBaAiYV3hFL3ZQ-1 X-Mimecast-MFC-AGG-ID: DW4Hhvk1NBaAiYV3hFL3ZQ_1749042561 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d50eacafso37619375e9.3 for ; Wed, 04 Jun 2025 06:09:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749042560; x=1749647360; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oVf38CoQ+gWhEl7SxQYlaDaoqj2qRHCVOsqMarLV2fI=; b=NKa1XkzFRC75nesJk47WFZYB2xCxmY7DilrN81zIy/Kss+wNFs3GgrhpUL/UbnuJxN Pe8+D+oYx1rUMcHoxzzduYrJUVnLPt0kocPTYLIDVmn2UJxySGRSwEi5oHKZzad9/JcV HGErgq+THPKLZ6UIAxkW37UVgTvazx2YVNKgdZIGeDzHR4+3PGVHVXhvyi0ovgYcQf3u adjd+9ewbW2VqzVlyWz00Qgu/NHGx3XgFBFvftGhwLY1RHYCfvPWMSuYKhHmm5wrJesB DaEha3rwEvD4Ac66gm71ySGiijOYXpGV5ajfbMYODf0qPGOmL6G1zfMxcOeVPFG5+jSj aLSA== X-Forwarded-Encrypted: i=1; AJvYcCUPlHBCKRCfVCF+65/p4TS+tUao2Tm3a8X3xk8OeCDBHyhbUQ858kHyB4MzUjRdc0JsPnpoaIWe9g==@kvack.org X-Gm-Message-State: AOJu0YzJDtOE7j6/WvjXfGDy3wz7/cPHBfLyg03qWAs4mh8YFiYkvQe8 d78/J009y+4+lhaSeUbCEcLutt1QTcOhtaXDObOkCa+oEGJdpjUa98lw/jMnvW1jXlFuz6NXIRB TVhfde8m+0Zm2vBEq4VXBn2udMzHH5G/eTkTbISwrWUAgDpGFW9jH X-Gm-Gg: ASbGncvhvv6Iqf4AfBeNXKo663vPKYHsd9295DTS3mWdb4nh0hYz+15t2McbNqaWDYZ VlpK2HjVi2iT614Hk/PiW3Z+eMUfKfnzpjBhJBnflg48y89GfGvV04TDAWHza32zTz3Z6N0kch0 W22Go3iEvE6FgtWe4zrUUAYJ0nmk6hRBHdKE9rSROD4btCSn4RuLcwogI1yrWu1W6yRKwqsjwKn he8tZRQsK3SztL/xaA245BEzv53BFvto/lEkR+REkuh2scVUmYqLoIDnXlyfaleMY2ETWNW4Uuo o2+9GbhkSQQvEy7tOqrG4QjL7F/+kuhDF88Ztadgljk+aBdhb7GPdthIZGihKLVAHS0+zH3do2+ 78du95r/g+FpmDorl64sSYQ/b/XftF/bTl2L96IQ= X-Received: by 2002:a05:600c:6219:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-451f0a755e2mr24950375e9.8.1749042560230; Wed, 04 Jun 2025 06:09:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6pD4Wuo/on25BleC9tSaXRP33gf52DpqdwQFvCfGl++HkQUfB9cRYcDO5cS1kp75l6PyGcg== X-Received: by 2002:a05:600c:6219:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-451f0a755e2mr24949525e9.8.1749042559632; Wed, 04 Jun 2025 06:09:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8f1e7sm200560845e9.1.2025.06.04.06.09.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 06:09:19 -0700 (PDT) Message-ID: <437f120c-8f1e-4a77-9b83-2f077f1337f3@redhat.com> Date: Wed, 4 Jun 2025 15:09:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 11/16] KVM: x86: Compute max_mapping_level with input from guest_memfd To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-12-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250527180245.1413463-12-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xt-TF7OMX0zua_aJtJigEubJ4X8PDZUP64hzzT4sf6A_1749042561 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4D5C740013 X-Stat-Signature: ab4se7ehb1qmj6fen34pukn1363ksiw6 X-Rspam-User: X-HE-Tag: 1749042563-429154 X-HE-Meta: U2FsdGVkX1/q4/SuXA1zEJNG1ptMtVH+Hou0DSQDpxbmd6oqtwxFxOyNybIHZ1My5WWGg1GEPcnwF1i6rk9XyOc25KsFgTtsjIvAvl8iasvAHKovBJqEbllyt/W8JdpNPhAfom1wOJYGWqla89fJLvbeaDGh3R80lr6goSw/gOMh/21xjOSSiFodO7LH5o4P6gO5SIB2EPi66wRTYt9tIR8vfHKh5cyB8aLp2/j9wj1F7VxydEqR82MLAPt0G4y+8sL0sRpQWZYYRWfL244k+XNCgAlcEx9UU0wVrQiVx8Ic0cGQFmrY4gmiGhBIn1in0GFwlgMutpPu7WjtonGNzkRxFUx09HBmeB+fcfMFbbOHrkslgPz3WD1Hit2LLM0jzhrQ0ELoXWJCsx2huhc7TEq0zlRmzUAbP8hwbJ6V7WPtnZOudS6lTd+C0UGVXghltKBvq3de0nasfFZJ8TUFeVj85jS5RPaPvbLtV2n0uCYqgtveoHxTIacSwbIHGKiSzTV3ofgtH8qNj44xjZOF0kDVQ+XHwDWlMdEKaDPdkBkIyDIqABRl5wzW357AMIVCaDuI9f7meGw8jwCvxtyxifBxLPYedZIeflj2ALf81cbXXzJKMGGvQs1d2dcNYHBju4GYBRMiDrxKUJlzBx7CmHZQSdnbj5LG5rmeOqMsYnuU7TDVSTnGuha9lSaxZl4IGd/Uf41S89lFUfT/+TrwS9yb18Yta8cBnHkE04Qoo7sRQyqha3QdI0aN3kpZl8lYm0A9BBaYRN4FH2PN+EnLbunQFibJNXO+V8X5ICsxwWatuQjqPccJRsgEpTBd0sylTB12lHRHnztltDxDPYC6w8i7C+uWKnyLYHnRFWCxNV8DU5IGXle4y7Imieq1DI/p1289Ao6R0mXO7tmwLe4bwoIvoUB8HCq8doKJyZjVqmFuMfvZTNXVf/ZlUwKFeaLk0Fbg2HDIX1zzb3PWFt/ yZ5nqirs rVSO2DthbfHc2BKaEykg+C8FmYzU2T9LIDVnTBNZSgj6kgRu/J4iOJZK3dMDjtR8rEoqje60ZZRcpaOeLBlhAjaVLXkwcS/CGdMwvPLggq6jNfj3G2C5BamXF0dDq9ToXT+sAKWvCgAkUw/XCe8txVcsBJd8g9/QrkqkPPpWY+glbRGLokY7c4ziWvLdzlH/rKhvo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.05.25 20:02, Fuad Tabba wrote: > From: Ackerley Tng > > This patch adds kvm_gmem_max_mapping_level(), which always returns > PG_LEVEL_4K since guest_memfd only supports 4K pages for now. > > When guest_memfd supports shared memory, max_mapping_level (especially > when recovering huge pages - see call to __kvm_mmu_max_mapping_level() > from recover_huge_pages_range()) should take input from > guest_memfd. > > Input from guest_memfd should be taken in these cases: > > + if the memslot supports shared memory (guest_memfd is used for > shared memory, or in future both shared and private memory) or > + if the memslot is only used for private memory and that gfn is > private. > > If the memslot doesn't use guest_memfd, figure out the > max_mapping_level using the host page tables like before. > > This patch also refactors and inlines the other call to > __kvm_mmu_max_mapping_level(). > > In kvm_mmu_hugepage_adjust(), guest_memfd's input is already > provided (if applicable) in fault->max_level. Hence, there is no need > to query guest_memfd. > > lpage_info is queried like before, and then if the fault is not from > guest_memfd, adjust fault->req_level based on input from host page > tables. > > Signed-off-by: Ackerley Tng Should there be a Co-developed-by? > Signed-off-by: Fuad Tabba > --- LGTM, but I am not particularly an expert on that code. Having some feedback from Sean Et. al would be great :) -- Cheers, David / dhildenb