Re: [patch 3/9] mempool - Make mempools NUMA aware

Matthew Dobson
2006-01-26T22:57:12Z

Christoph Lameter wrote:
> On Wed, 25 Jan 2006, Matthew Dobson wrote:
>
>
>>plain text document attachment (critical_mempools)
>>Add NUMA-awareness to the mempool code. This involves several changes:
>
>
> I am not quite sure why you would need numa awareness in an emergency
> memory pool. Presumably the effectiveness of the accesses do not matter.
> You only want to be sure that there is some memory available right?

Not all requests for memory from a specific node are performance
enhancements, some are for correctness. With large machines, especially as
those large machines' workloads are more and more likely to be partitioned
with something like cpusets, you want to be able to specify where you want
your reserve pool to come from. As it was not incredibly difficult to
offer this option, I added it. I was unwilling to completely ignore
callers' NUMA requests, assuming that they are all purely performance
motivated.

> You do not need this....

I do not agree...

Thanks!

-Matt