Re: [PATCH] mm: Implement Swap Prefetching v23

Nick Piggin
2006-02-10T05:43:55Z

Con Kolivas wrote:
> On Friday 10 February 2006 16:32, Nick Piggin wrote:
>
>>Con Kolivas wrote:
>>
>>>Just so it's clear I understand, is this what you (both) had in mind?
>>>Inline so it's not built for !CONFIG_SWAP_PREFETCH
>>
>>Close...
>
>
>>>+inline void lru_cache_add_tail(struct page *page)
>>
>>Is this inline going to do what you intend?
>
>
> I don't care if it's actually inlined, but the subtleties of compilers is way
> beyond me. All it positively achieves is silencing the unused function
> warning so I had hoped it meant that function was not built. I tend to be
> wrong though...
>

I don't think it can because it is not used in the same file.
You'd have to put it into the header file.

Not sure why it silences the unused function warning. You didn't
replace a 'static' with the inline? I don't think there is any
other way the compiler can know the function isn't used externally.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com