Re: [PATCH] mm: Implement Swap Prefetching v23

Nick Piggin
2006-02-10T04:45:57Z

Andrew Morton wrote:
> Con Kolivas <kernel@kolivas.org> wrote:
>
>> Ok I see. We don't have a way to add to the tail of that list though?
>
>
> del_page_from_lru() + (new) add_page_to_inactive_list_tail().
>
>
>>Is that
>> a worthwhile addition to this (ever growing) project? That would definitely
>> have an impact on the other code if not all done within swap_prefetch.c..
>> which would also be quite a large open coded something.
>
>
> Do both of the above in a new function in swap.c.
>

That'll require the caller to do lru locking.

I'd add an lru_cache_add_tail, use it instead of the current lru_cache_add
that Con's got now, and just implement it in a simple manner, without
pagevecs.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com