Re: [PATCH] mm: Implement Swap Prefetching v23

Con Kolivas
2006-02-10T05:48:01Z

On Friday 10 February 2006 16:43, Nick Piggin wrote:
> Con Kolivas wrote:
> > On Friday 10 February 2006 16:32, Nick Piggin wrote:
> >>Con Kolivas wrote:
> >>>Just so it's clear I understand, is this what you (both) had in mind?
> >>>Inline so it's not built for !CONFIG_SWAP_PREFETCH
> >>
> >>Close...
> >>
> >>>+inline void lru_cache_add_tail(struct page *page)
> >>
> >>Is this inline going to do what you intend?
> >
> > I don't care if it's actually inlined, but the subtleties of compilers is
> > way beyond me. All it positively achieves is silencing the unused
> > function warning so I had hoped it meant that function was not built. I
> > tend to be wrong though...
>
> I don't think it can because it is not used in the same file.
> You'd have to put it into the header file.

Yes that was the stream of "unimplemented" errors we started seeing on new
gccs that couldn't inline and said so. The build process is mystical and
somewhat random in order but I guessed if it encounters this first it should
be able to inline it. However as I said I don't really need it inlined.

> Not sure why it silences the unused function warning.

It probably just fools it... Will probably warn on newer gccs soon.

> You didn't
> replace a 'static' with the inline? I don't think there is any
> other way the compiler can know the function isn't used externally.

Well I could always just put it in a header file under CONFIG_SWAP_PREFETCH..
I was trying to do the swap.c thing that akpm suggested though.

Cheers,
Con