From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB465C3DA7F for ; Thu, 15 Aug 2024 17:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E4CE6B015F; Thu, 15 Aug 2024 13:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 594FC6B0161; Thu, 15 Aug 2024 13:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483C86B0163; Thu, 15 Aug 2024 13:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 263A16B015F for ; Thu, 15 Aug 2024 13:11:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCC03C169A for ; Thu, 15 Aug 2024 17:11:58 +0000 (UTC) X-FDA: 82455122316.09.E0E729B Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf18.hostedemail.com (Postfix) with ESMTP id AB0891C0015 for ; Thu, 15 Aug 2024 17:11:56 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NP/J6jHH"; spf=pass (imf18.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723741903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tEDqj5AZHKQomSC6+htxpXUh32AukOgHaSJDacyC2bs=; b=erC+rrvQ17cU4bTBEt1cloZjmO7oKYZidb5Itdmb0YZXgjWZLQqMMQBl662AV6o7E+/2qS 375uJ3u66084ga+opxcqCR82xI+6ta27wqX+1wSwm8niAWEBW7P3pJJsR8ogBUVzqxVs+M YQr5+0Mg9UNh6AnQJs9pZvQSKeRvotM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="NP/J6jHH"; spf=pass (imf18.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723741903; a=rsa-sha256; cv=none; b=GkiidwpSwfRhrjuu2bniQfgpCct9bSEaAzPXSAPw6hv0dia/nOlvuQ4sJ9jiv6/H0HywNM fR9fgMbS4KemKy2pvifb7cpe0BLqoZzTYw/gyWIat6bGJV6mmkDE1DSrFmOV8anmoLaNq/ BY6+ZpmXe8bsVt83teDQvrCM6+Rl0bc= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7de4364ca8so147804066b.2 for ; Thu, 15 Aug 2024 10:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723741915; x=1724346715; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tEDqj5AZHKQomSC6+htxpXUh32AukOgHaSJDacyC2bs=; b=NP/J6jHHrcX5KC1EC+BaHG37xhTCeKAjXq+pyOFNbJL3zWRhRoM5b9nsf+3JHp5OYy OMLwRTeYCdIvFfc+MBTcfyJwU2l8ZtuT47KL4l++dGxPxykSmeTPn1ss79minS3VwbGE H02acI98IYFPUZKpEaV9IdCyxGWASCKU1D9TEeezYwgiDujD4ZCgiI4PfNgF8AE7xiZ/ qTtYhYLQ/e4MhV726fZZ6XjK6p42UgQ11D3rF3uP2t7NjL2UFuP0iUHUCXVPT9av2lVY Tqv8F41CkdVbULy5XjDspc1JzE9vPmEI+bIbcNAuLLcqKB7KPnAciAXTsycUrQFV02dy 3FiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723741915; x=1724346715; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tEDqj5AZHKQomSC6+htxpXUh32AukOgHaSJDacyC2bs=; b=nKuKPZGP3tNFs/ect6VXrM/fZ3pdUe9HyIfPV40LyIqVfVnMppUTmx6+LDQqzq2xmz 7gbkvdfm6maltwwbpnsnfYxLLxCcK66z/T+EHOw/dlzW/sXxrDE9k+5fQ1EAISqI00gA jvq1gDCYFyGnf8ZDPHRRFA9m05rn+XwJW0ClcIXeUEfCyjzBqSkQDGuMnFWXxtavfuXs qc5BSaXVwRTFQyIkOn7dAtg/kiHOtDoxZkeCIEG1U+gW8m6jvQBo4+mm+BmxbLj9w/rS z54J6qf5XtEOkdRH3WI0Eit2t7sT66hT8p/KYFYvk/dRkRUBylNLAdbGjMROsm2xYL9K xoUw== X-Forwarded-Encrypted: i=1; AJvYcCUxCYJWeHMCaugYIND6Xu6gnd6mQ4cVKlFd2EQ65sjci2EJiI3haOtMEk06utX8bON06jgOft5+Lx2fJ+8rzJK6sKk= X-Gm-Message-State: AOJu0Yy50w3/w8op2N55lUtiUoUTHQ+Cyrri4w/IVuSSHRSt5H8MfOER KOQhRGNGSij+yMaImdZOMyI+AAMwV0HCp8amukumEIDtWy7d9iDn X-Google-Smtp-Source: AGHT+IGjsj5rtDTfutpHi05OqRVtFGshwby5fAPW/SVT9PnSsBjS3YTpO3WRKIhhmdAdhbwqHjJ+yA== X-Received: by 2002:a17:907:c885:b0:a7d:a4d2:a2ba with SMTP id a640c23a62f3a-a83929d3666mr17484566b.49.1723741914995; Thu, 15 Aug 2024 10:11:54 -0700 (PDT) Received: from [192.168.42.192] ([85.255.234.87]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a838396dfddsm127380066b.214.2024.08.15.10.11.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 10:11:54 -0700 (PDT) Message-ID: <43d30d3e-b1a2-4ec4-b0dc-ede94d5a4f39@gmail.com> Date: Thu, 15 Aug 2024 18:12:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/5] implement asynchronous BLKDISCARD via io_uring To: "Martin K. Petersen" Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org References: Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: s16y1qfxsku77sc6fisxed138n7way5x X-Rspamd-Queue-Id: AB0891C0015 X-Rspamd-Server: rspam11 X-HE-Tag: 1723741916-292299 X-HE-Meta: U2FsdGVkX19An+dUQi2Mx+dYCnnNL8U820x7AOc8aEjr1bmS1K8A5Otru0NCQDKTXZQzbJUvlWC47KZH99G0a/cNxN2uVO5uuNrDJ9J4Ggw7cPZPeSoZr+jv3AB7qKChywjJX2C9kQroE5CPLNAF+UyCtxV37K6VGM0PYvAjk9OImPKfVNLYaUt0/314hSZ3Ws65TOLGCCY3k8t0tGk3bc25VhPD3IR9X1Z94Cj6MNWsJhHXSGTXTqFSf8FmZYrSiMqKl97bBYy/y9aAZ0m4eH4PaPjsQvn04RiUkT2MFHOHNuZEuBP8yJLkmByLOllvRGGWg4v6pvZpmv7c4ex2jmzGMEz87TPlHeE5xVn9xCQjOIZLnfbVN41S6wcXx3xIQ9JtASQKTpbZdDFdku+7fdXxOoMtq9ciKWRlPr4xpFIEAJT+sIKWeEnZzLndDmw7yBnSvIvmA9RgFHqO8s/5F9UB0sE+92TJB1ESVRz4MpWdcmA99+Ffj435loelZuA1iSeLdHvY/rzfs9Ui87CZtLS91ohH0HtdFH6JyTBiz10UqpJjrUqm5M+pRE9mw9HtaOy8XdSUoBKZoDbUcZtcibV/LQCcFTv4eyzcXtozLqbPXnqklPrVbHbNzOi+9xF7kycno14o31Vi/hVc0KY4o6F52DVtt8RV8AbDiYo7bINm5+F7wyeL3lvfzwAhTkCP4Z2WOgmTasVg4MPY4WyNCHg++CMlB23ESXa1cr5QKDPQXnPeaok7GBRpSVGlDHzyaixMbZz62GvInNZMpNoxTjbme8QeX26XglnAc9UidRyujv8k5OVviJHu9rrkX0rQ+VgN1H64QLwhy1uHt401sF4+jGKO2+IoReuuuVJ7O460DFo/XZOzV52a+w1+tWmdrAbdOdBqnLSd/E68wvub6OqILIzCoGtgesMILx5wXXAx7ZgiXt+jzVMj2tI8ynRTGctxctiVFlIFxJCKe/L kX8WN8vd ptVWPp4uX867IIaZO4rkcGKV3CyE28AddBRX8sYc24lkiyHmgGQMLiN/EoBrUCTekrWNuVkvfq7X9Ggxm3Kit2XVpe7FdGxixeETfhT+NvhAoXd0ehtM8BLp7LzJjNTAfEsALF4cgyfkpIiaGj0pLfQfNtGvpkrdPIySDA0M/ZlMnd9YBH6bkCY8fyaN3+APCIqCFH08n1J38P/qXgVV/MCB99QkLy2v7bYR56IuWbGTzraeEnB4cNHcnWF67UZqrlb3gx30qimynseVzoTyiVhUnLjSSFu/WIX/V8WKf9c2abPsF7Grum1EPBXhMTThG1YzXblh7RolAWe2ErBwzxvnWGAyWxLq/es2+yAaGUg6+qC9r5yAdqg8lopdZvQyLbX5ESh7D8K1B8L2rX1j0zsFOugg5EFdDh/mau8hdxQVTAQf+CVxSO6NjJk8FHZX2Foa9uH43ck/MUD2zKeX+sTtHTCnbAdMY6wvX X-Bogosity: Ham, tests=bogofilter, spamicity=0.325039, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/15/24 17:15, Martin K. Petersen wrote: > > Hi Pavel! > >> I'm also going to add BLKDISCARDZEROES and BLKSECDISCARD, which should >> reuse structures and helpers from Patch 5. > > Adding these is going to be very useful. > > Just a nit: Please use either ZEROOUT (or WRITE_ZEROES) and SECURE_ERASE > terminology for the additional operations when you add them. > > DISCARDZEROES is obsolete and secure discard has been replaced by secure > erase. We are stuck with the legacy ioctl names but we should avoid > perpetuating unfortunate naming choices from the past. Noted, thanks, the ioctl names are indeed confusing. -- Pavel Begunkov