From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <443651D7.6020901@redhat.com> Date: Fri, 07 Apr 2006 07:49:43 -0400 From: Hideo AOKI MIME-Version: 1.0 Subject: Re: [patch 1/3] mm: An enhancement of OVERCOMMIT_GUESS References: <4434570F.9030507@redhat.com> <20060406094533.b340f633.kamezawa.hiroyu@jp.fujitsu.com> <4434C12A.4000108@redhat.com> <20060406170851.1402c78d.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20060406170851.1402c78d.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: multipart/mixed; boundary="------------020700080200080102050801" Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: This is a multi-part message in MIME format. --------------020700080200080102050801 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Kamezawa-san, Thank you for your quick response. And sorry for slow response. KAMEZAWA Hiroyuki wrote: > Hideo AOKI wrote: > >>Since __vm_enough_memory() doesn't know zone and cpuset information, >>we have to guess proper value of lowmem_reserve in each zone >>like I did in calculate_totalreserve_pages() in my patch. >>Do you think that we can do this calculation every time? >> >>If it is good enough, I'll make revised patch. >> > > I just thought to show "how to calculate" in unified way is better. I got it. > Do you have a detailed comparison of test result with and without this patch ? Yes. I have test logs and attach them to this e-mail. The logs are verbose output of my test kernel module which I already sent to lkml. http://marc.theaimsgroup.com/?l=linux-kernel&m=114428121522349&w=2 Test machine was i386 4GB memory PC. I didn't use swap region. Let me explain a few things about the log. * 2.6.17-rc1-mm1 HIGH: NORMAL: The test module consumes free pages until the number of free pages is less than pages_high. <+ 1> This line shows the status of memory just before the module calls __vm_enough_memory(). Meaning of each item is below. buf: bufferram cache: page cache slab reclaim: slab_reclaim_pages swap: nr_swap_pages +: margin target: the number of pages to ask __vm_enough_memory() Test MAY be . This line shows __vm_enough_memory() returned success. Please let me know if you have any questions and suggestions. Regards, Hideo Aoki --- Hideo Aoki, Hitachi Computer Products (America) Inc. --------------020700080200080102050801 Content-Type: text/plain; name="log-2.6.17-rc1-mm1.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="log-2.6.17-rc1-mm1.txt" * 2.6.17-rc1-mm1 Apr 6 20:33:33 dhcp1 kernel: Test module was loaded. Apr 6 20:33:33 dhcp1 kernel: init ...<3>done Apr 6 20:33:33 dhcp1 kernel: Apr 6 20:33:33 dhcp1 kernel: HIGH: Apr 6 20:33:34 dhcp1 kernel: HighMem , <3> Apr 6 20:33:34 dhcp1 kernel: HIGH: Apr 6 20:33:34 dhcp1 kernel: Apr 6 20:33:34 dhcp1 kernel: HIGH: Apr 6 20:33:34 dhcp1 kernel: HighMem , <3> Apr 6 20:33:34 dhcp1 kernel: HIGH: Apr 6 20:33:34 dhcp1 kernel: already satisfied Apr 6 20:33:34 dhcp1 kernel: Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: Normal , <3> Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: Normal , <3> Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: Normal , <3> Apr 6 20:33:34 dhcp1 kernel: NORMAL: Apr 6 20:33:34 dhcp1 kernel: already satisfied Apr 6 20:33:34 dhcp1 kernel: concrete test ... Apr 6 20:33:34 dhcp1 kernel: <+ 1> Apr 6 20:33:34 dhcp1 kernel: Test MAY be . Apr 6 20:33:34 dhcp1 kernel: allocation failed: out of vmalloc space - use vmalloc= to increase size. Apr 6 20:33:35 dhcp1 kernel: allocation failed: out of vmalloc space - use vmalloc= to increase size. Apr 6 20:33:35 dhcp1 kernel: Test SURELY was . Apr 6 20:33:35 dhcp1 kernel: concrete test ...done. --------------020700080200080102050801 Content-Type: text/plain; name="log-2.6.17-rc1-mm1+patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="log-2.6.17-rc1-mm1+patch.txt" * 2.6.17-rc1-mm1 + patches Apr 6 20:56:36 dhcp1 kernel: Test module was loaded. Apr 6 20:56:36 dhcp1 kernel: init ...<3>done Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: HIGH: Apr 6 20:56:36 dhcp1 kernel: HighMem , <3> Apr 6 20:56:36 dhcp1 kernel: HIGH: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: HIGH: Apr 6 20:56:36 dhcp1 kernel: HighMem , <3> Apr 6 20:56:36 dhcp1 kernel: HIGH: Apr 6 20:56:36 dhcp1 kernel: already satisfied Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: Normal , <3> Apr 6 20:56:36 dhcp1 kernel: NORMAL: Apr 6 20:56:36 dhcp1 kernel: already satisfied Apr 6 20:56:36 dhcp1 kernel: concrete test ... Apr 6 20:56:36 dhcp1 kernel: <+ 1> Apr 6 20:56:36 dhcp1 kernel: Test was . Apr 6 20:56:36 dhcp1 kernel: concrete test ...done. Apr 6 20:56:48 dhcp1 kernel: Unloading module ... --------------020700080200080102050801-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org