Re: [patch 1/8] Page host virtual assist: unused / free pages.

Martin Schwidefsky
2006-04-24T14:42:10Z

On Mon, 2006-04-24 at 16:07 +0200, Andi Kleen wrote:
> On Monday 24 April 2006 14:34, Martin Schwidefsky wrote:
>
> > +#define page_hva_set_unused(_page) do { } while (0)
> > +#define page_hva_set_stable(_page) do { } while (0)
>
> The whole thing seems quite under commented in the code and illnamed
> (if you didn't know what page_hva_set_unused() is supposed to do
> already would you figure it out from the name?)

Well, we can always add comments if something is unclear. The name
should give you a good hint though: page-(hva)-set-unused. You set the
page to the unused state. Is the name really that confusing ?

--
blue skies,
Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.