Re: Any reason for passing "tlb" to "free_pgtables()" by address?

Hugh Dickins
2006-05-05T12:41:19Z

On Fri, 5 May 2006, Zoltan Menyhart wrote:
> Apparently, there is no reason for passing "tlb" to "free_pgtables()"
> by address, because there is no need for re-scheduling inside this
> function => no other "mmu_gather" can / will be used.

You're right. Well, actually, it's been shown that there _is_ a need
for rescheduling inside that function (high latency), but we've not
yet settled on the right way to go about that - mmu_gathering needs
overhaul to avoid disabling preemption, something both Nick and I
have worked on intermittently.

Personally I'd prefer not to make your change right now - it seems
a shame to make that cosmetic change without addressing the real
latency issue; but I've no strong feeling against your patch.

Hugh