From: "minchan Kim" <barrioskmc@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"hugh@veritas.com" <hugh@veritas.com>,
"yamamoto@valinux.co.jp" <yamamoto@valinux.co.jp>,
taka@valinux.co.jp, Andi Kleen <ak@suse.de>,
"nickpiggin@yahoo.com.au" <nickpiggin@yahoo.com.au>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] radix-tree based page_cgroup. [7/7] per cpu fast lookup
Date: Tue, 26 Feb 2008 22:31:51 +0900 [thread overview]
Message-ID: <44c63dc40802260531o2102759l4463e62fa9b78e1b@mail.gmail.com> (raw)
In-Reply-To: <44c63dc40802260526x3283baf2tb4ab71b384a4ab58@mail.gmail.com>
I knew you purpose with following patch <radix-tree based page_cgroup.
[8/7] vmalloc for large machines>
I am afraid your patch list isn't arranged well. :-<
On Tue, Feb 26, 2008 at 10:26 PM, minchan Kim <barrioskmc@gmail.com> wrote:
> > -struct page_cgroup *get_page_cgroup(struct page *page, gfp_t gfpmask)
> > +struct page_cgroup *__get_page_cgroup(struct page *page, gfp_t gfpmask)
> > {
> > struct page_cgroup_root *root;
> > struct page_cgroup *pc, *base_addr;
> > @@ -96,8 +110,14 @@ retry:
> > pc = radix_tree_lookup(&root->root_node, idx);
> > rcu_read_unlock();
> >
> > + if (pc) {
> > + if (!in_interrupt())
> > + save_result(pc, idx);
> > + }
> > +
>
> I didn't look through mem_control's patches yet.
> Please understand me if my question might be foolish.
>
> why do you prevent when it happen in interrupt context ?
> Do you have any reason ?
>
> --
> Thanks,
> barrios
>
--
Thanks,
barrios
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-26 13:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 3:07 [RFC][PATCH] radix-tree based page_cgroup. [0/7] introduction KAMEZAWA Hiroyuki
2008-02-25 3:10 ` [RFC][PATCH] radix-tree based page_cgroup. [1/7] definitions for page_cgroup KAMEZAWA Hiroyuki
2008-02-25 7:47 ` Hirokazu Takahashi
2008-02-25 7:56 ` Balbir Singh
2008-02-25 8:03 ` KAMEZAWA Hiroyuki
2008-02-26 7:46 ` Hirokazu Takahashi
2008-02-26 9:07 ` KAMEZAWA Hiroyuki
2008-02-25 3:12 ` [RFC][PATCH] radix-tree based page_cgroup. [2/7] charge/uncharge KAMEZAWA Hiroyuki
2008-02-25 3:13 ` [RFC][PATCH] radix-tree based page_cgroup. [3/7] move lists KAMEZAWA Hiroyuki
2008-02-25 3:14 ` [RFC][PATCH] radix-tree based page_cgroup. [4/7] migration KAMEZAWA Hiroyuki
2008-02-25 3:16 ` [RFC][PATCH] radix-tree based page_cgroup. [5/7] force_empty KAMEZAWA Hiroyuki
2008-02-25 3:17 ` [RFC][PATCH] radix-tree based page_cgroup. [6/7] radix-tree based page cgroup KAMEZAWA Hiroyuki
2008-02-25 5:56 ` YAMAMOTO Takashi
2008-02-25 6:07 ` KAMEZAWA Hiroyuki
2008-02-25 6:40 ` Hirokazu Takahashi
2008-02-25 6:52 ` KAMEZAWA Hiroyuki
2008-02-25 7:05 ` Hirokazu Takahashi
2008-02-25 7:25 ` KAMEZAWA Hiroyuki
2008-02-25 8:02 ` Hirokazu Takahashi
2008-02-25 8:11 ` KAMEZAWA Hiroyuki
2008-02-25 8:28 ` KAMEZAWA Hiroyuki
2008-02-25 3:18 ` [RFC][PATCH] radix-tree based page_cgroup. [7/7] per cpu fast lookup KAMEZAWA Hiroyuki
2008-02-25 5:36 ` YAMAMOTO Takashi
2008-02-25 5:46 ` KAMEZAWA Hiroyuki
2008-02-26 13:26 ` minchan Kim
2008-02-26 13:31 ` minchan Kim [this message]
2008-02-26 23:37 ` KAMEZAWA Hiroyuki
2008-02-27 0:57 ` minchan Kim
2008-02-27 1:09 ` KAMEZAWA Hiroyuki
2008-02-27 1:21 ` minchan Kim
2008-02-25 3:19 ` [RFC][PATCH] radix-tree based page_cgroup. [8/7] vmalloc for large machines KAMEZAWA Hiroyuki
2008-02-25 7:06 ` KAMEZAWA Hiroyuki
2008-02-25 3:24 ` [RFC][PATCH] radix-tree based page_cgroup. [0/7] introduction Balbir Singh
2008-02-25 4:02 ` KAMEZAWA Hiroyuki
2008-02-25 3:31 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44c63dc40802260531o2102759l4463e62fa9b78e1b@mail.gmail.com \
--to=barrioskmc@gmail.com \
--cc=ak@suse.de \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=taka@valinux.co.jp \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).