Re: [PATCH v10 06/16] KVM: Fix comments that refer to slots_lock

[Shivank Garg <shivankg@amd.com>]

On 5/27/2025 11:32 PM, Fuad Tabba wrote:
> Fix comments so that they refer to slots_lock instead of slots_locks
> (remove trailing s).
> 
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fuad Tabba <tabba@google.com>
> ---
>  include/linux/kvm_host.h | 2 +-
>  virt/kvm/kvm_main.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index d9616ee6acc7..ae70e4e19700 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -859,7 +859,7 @@ struct kvm {
>  	struct notifier_block pm_notifier;
>  #endif
>  #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES
> -	/* Protected by slots_locks (for writes) and RCU (for reads) */
> +	/* Protected by slots_lock (for writes) and RCU (for reads) */
>  	struct xarray mem_attr_array;
>  #endif
>  	char stats_id[KVM_STATS_NAME_SIZE];
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 2468d50a9ed4..6289ea1685dd 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -333,7 +333,7 @@ void kvm_flush_remote_tlbs_memslot(struct kvm *kvm,
>  	 * All current use cases for flushing the TLBs for a specific memslot
>  	 * are related to dirty logging, and many do the TLB flush out of
>  	 * mmu_lock. The interaction between the various operations on memslot
> -	 * must be serialized by slots_locks to ensure the TLB flush from one
> +	 * must be serialized by slots_lock to ensure the TLB flush from one
>  	 * operation is observed by any other operation on the same memslot.
>  	 */
>  	lockdep_assert_held(&kvm->slots_lock);

Reviewed-by: Shivank Garg <shivankg@amd.com>