Re: Checking page_count(page) in invalidate_complete_page

Andrew Morton
2006-09-29T22:29:51Z

On Fri, 29 Sep 2006 17:48:23 -0400
Chuck Lever <chuck.lever@oracle.com> wrote:

> Andrew Morton wrote:
> > buggerit, let's do this. It'll fix NFS, yes?
>
> It looks right to me.

s/right/less incorrect/ ;)

Please double-check that it passes testing.

> I'll discuss a patch with Trond that adds a
> warning in nfs_revalidate_mapping() and perhaps a performance counter to
> see how many times we hit this in practice.

Yes, please do carefully check the invalidate_inode_pages2() return value:
we've had ongoing subtle problem with that code and we really do want the
early warning which an explicit check+printk will give us.