Re: Checking page_count(page) in invalidate_complete_page

Peter Zijlstra
2006-09-29T21:17:17Z

On Fri, 2006-09-29 at 17:02 -0400, Chuck Lever wrote:
> Peter Zijlstra wrote:
> > On Fri, 2006-09-29 at 16:34 -0400, Chuck Lever wrote:
> >
> >> One option that hasn't been entertained is to remove the "batched LRU
> >> add" logic all together. Just gut lru_cache_add -- it should send
> >> pages immediately to be added to the LRU list. This is a bit slower,
> >> but it fixes the invalidation problems, and makes the icky
> >> lru_add_drain_all() a no-op.
> >
> > That would bring some larger machines to their knees contending on
> > zone->lock.
> >
>
> Versus calling lru_add_drain_all() every time a file system tries to
> invalidate an inode's cached pages?

Surely not all filesystems are that broken? From what I gather from this
discussion its only NFS.

But even then, you can run quite a few workloads without invalidating
inodes often.