Re: Checking page_count(page) in invalidate_complete_page

Andrew Morton
2006-10-02T18:20:05Z

On Mon, 02 Oct 2006 13:02:03 -0400
Steve Dickson <SteveD@redhat.com> wrote:

>
>
> Andrew Morton wrote:
> > On Mon, 02 Oct 2006 09:25:22 -0400
> > Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> >
> >> On Mon, 2006-10-02 at 08:01 -0400, Steve Dickson wrote:
> >>> Question: Maybe I missed this... but what is NFS suppose to do
> >>> when invalidate_inode_pages2() fails on non-file inodes? Noting
> >>> it with as metric as Chuck suggested is a good way to
> >>> detect its happening, but does it make sense for NFS to keep
> >>> calling invalidate_inode_pages2() until it does not fail when
> >>> trying to flush the readdir cache?
> >> Definitely not. There is not much we can do at the filesystem level if
> >> the VM fails, and that is why we haven't bothered checking the return
> >> value previously.
> >>
> >
> > Please add a printk.
> Please add a printk that can be turned off....

Please add a printk which can't be turned off. This is our user's data
we're talking about here.

If that printk comes out then we need to fix the kernel so that it no
longer wants to print that printk. We don't want to just hide it.