Re: Checking page_count(page) in invalidate_complete_page

Steve Dickson
2006-10-02T17:02:03Z

Andrew Morton wrote:
> On Mon, 02 Oct 2006 09:25:22 -0400
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
>
>> On Mon, 2006-10-02 at 08:01 -0400, Steve Dickson wrote:
>>> Question: Maybe I missed this... but what is NFS suppose to do
>>> when invalidate_inode_pages2() fails on non-file inodes? Noting
>>> it with as metric as Chuck suggested is a good way to
>>> detect its happening, but does it make sense for NFS to keep
>>> calling invalidate_inode_pages2() until it does not fail when
>>> trying to flush the readdir cache?
>> Definitely not. There is not much we can do at the filesystem level if
>> the VM fails, and that is why we haven't bothered checking the return
>> value previously.
>>
>
> Please add a printk.
Please add a printk that can be turned off....