Re: Checking page_count(page) in invalidate_complete_page

Chuck Lever
2006-09-28T16:42:44Z

Andrew Morton wrote:
> On Thu, 28 Sep 2006 09:36:40 -0700
> Andrew Morton <akpm@osdl.org> wrote:
>
>>> I think a call to lru_add_drain_all() belongs in both the
>>> invalidate_inode_pages() and the invalidate_inode_pages2() path. Do you
>>> agree?
>> Yes.
>
> Or maybe not. lru_add_drain() will only drain the local CPU's buffer. If
> the page is sitting in another CPU's buffer, the same problem will occur.
>
> IOW, you got lucky.

I used lru_add_drain_all(), so it hit all the per-CPU pagevecs.