From: David Laight <David.Laight@ACULAB.COM>
To: 'kernel test robot' <lkp@intel.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>,
'Andrew Morton' <akpm@linux-foundation.org>,
"'Matthew Wilcox (Oracle)'" <willy@infradead.org>,
'Christoph Hellwig' <hch@infradead.org>,
"'Jason A. Donenfeld'" <Jason@zx2c4.com>
Cc: "oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"Linux Memory Management List" <linux-mm@kvack.org>
Subject: RE: [PATCH next resend 5/5] minmax: Relax check to allow comparison between int and small unsigned constants.
Date: Wed, 26 Jul 2023 09:29:15 +0000 [thread overview]
Message-ID: <4520ae6dc8b447cbaa77be0cdea79986@AcuMS.aculab.com> (raw)
In-Reply-To: <202307260303.3ftEpZRU-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
> Sent: 25 July 2023 20:37
>
...
> drivers/gpu/drm/drm_modes.c: In function 'drm_mode_parse_command_line_for_connector':
> >> include/linux/minmax.h:23:22: warning: ordered comparison of pointer with integer zero [-Wextra]
> 23 | ((x) >= 0 && (x) <= (typeof((x) + 0))(long)__INT_MAX__))
> | ^~
...
> drivers/gpu/drm/drm_modes.c:2474:29: note: in expansion of macro 'max'
> 2474 | extra_ptr = max(bpp_end_ptr, refresh_end_ptr);
> | ^~~
There are a handful of annoying uses of min/max with pointers.
I'll fix this in v2 by adding a cast to the 0.
(I was expecting an error for unsigned types.)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-07-26 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48c2cd0407f14859919d4fcbe526234a@AcuMS.aculab.com>
2023-07-25 19:36 ` [PATCH next resend 5/5] minmax: Relax check to allow comparison between int and small unsigned constants kernel test robot
2023-07-26 9:29 ` David Laight [this message]
2023-07-27 5:20 ` kernel test robot
2023-07-28 7:15 ` kernel test robot
2023-07-28 8:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4520ae6dc8b447cbaa77be0cdea79986@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).