Re: [RFC][PATCH 1/1] Expose per-node reclaim and migration to userspace

Paul Menage
2006-11-30T00:25:25Z

On 11/29/06, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Tue, 28 Nov 2006 19:06:56 -0800
> menage@google.com wrote:
>
> >
> > + for (i = 0; i < pgdat->node_spanned_pages; ++i) {
> > + struct page *page = pgdat_page_nr(pgdat, i);
> you need pfn_valid() check before accessing page struct.

OK. (That check can only fail if CONFIG_SPARSEMEM, right?)

>
>
> > + if (!isolate_lru_page(page, &pagelist)) {
> you'll see panic if !PageLRU(page).

In which kernel version? In 2.6.19-rc6 (also -mm1) there's no panic in
isolate_lru_page().

Paul