From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F9FB606A338 for ; Tue, 27 Oct 2026 10:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YCaic2Ja Received: by kanga.kvack.org (Postfix) id 9ACC26B0692; Tue, 27 Oct 2026 06:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9367E6B069A; Tue, 27 Oct 2026 06:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DA366B0697; Tue, 27 Oct 2026 06:49:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 511476B0692 for ; Tue, 27 Oct 2026 06:49:56 -0400 (EDT) Received: from smtpin12.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 70EA71C42DE for ; Tue, 27 Oct 2026 10:49:55 +0000 (UTC) X-FDA: 85368085950.12.E947D79 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id B91E9120006 for ; Tue, 27 Oct 2026 10:49:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YCaic2Ja; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1793098193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9aBgONiGwXT29AYBBhtg5jqULuWxVDAk/QhC0ZTHjIM=; b=gj/RgTJcJLFEvyy0yXiABn3XKnlUcO4ZKNq8Kpp6LA2j6zeHfvW9myy1sIR18nIhWP9PQj zMYqLFh42ntOdXXD7Dd7BaEf92NS2ML3ICjjspoEzGnNzY4++ZdYl7qkaZEuKi3UkIb3aA 3Z3G3gCVrSkjk9iE6zUQ5rGCq1i5NyM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YCaic2Ja; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1793098193; b=pZgNGv3P+BcRIDgEw3R2LuZe7SQTiPWwUp1De3fF+yxX8Ra1nbsrjaLwEBB+07bT6JjyNK 3+SLZTeNXCaSM9G4s8AL9imWrfd7odRIzIDzt2378VQ1/C07dZV0jswfmxTrOQUFlJP3FY o9ZlRCFofwQOiqMNHBKsATo6F3NyOtk= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 418F36022E; Tue, 27 Oct 2026 10:49:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD4001F01825; Tue, 27 Oct 2026 10:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793098193; bh=9aBgONiGwXT29AYBBhtg5jqULuWxVDAk/QhC0ZTHjIM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=YCaic2JaAdfC4/1+90QJg35TsG8GqrwRhONODUPVyC1RbTfzk47ktvosWNcRjHRlf mTkSPui4csikJ+YuxMET7+ZDdBz5ilfIBElCILjjGdfoy200YsIvziKPd+9fp0Ake2 vZuqSzMox0jEQQrMBhtk55LqkpuvRtuhXPLUWuC/9q8fYL2n6lfvZ8krv/NVoQ1IXg uoR0A1FiuJbDAUSRYeKIpZ64tqzq8Vkt3D/okJZj4b5v2BdjSJC1Smg+zhKKuvlaLt t5o7LNFu8PX11sQ0ttsq9qg9Q6mdtYMV7dYsSr3KvqoJkd+mTK1YjdWJI/U4xcWKSf 5U47iZ3XhurmQ== Message-ID: <459de93b-466c-4661-bf96-9bb647f2a8ad@kernel.org> Date: Tue, 27 Oct 2026 11:49:49 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: use account_new_hugetlb_folio() in add_hugetlb_folio() To: Enze Li Cc: linux-mm@kvack.org, muchun.song@linux.dev, osalvador@suse.de, akpm@linux-foundation.org References: <20261027060446.289404-1-lienze@kylinos.cn> <33a5582e-3d27-4f34-abb4-eebbc7c34ca4@kylinos.cn> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <33a5582e-3d27-4f34-abb4-eebbc7c34ca4@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B91E9120006 X-Rspam-User: X-Stat-Signature: 3yuuc7yfz6rkmyawsmhow8y5ud78faoe X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Rspamd-Server: rspam03 X-HE-Tag: 1793098193-339509 X-HE-Meta: U2FsdGVkX1+7+cI7+oO0wAkAycsx4APUtHUcCrfoTfRp9On3CGOV64dQOpwbp2SIxpk9depMCi0FemUCYAx5x8itInEVZx3EQJV5WAhxxGxN5cijIhAidDvDyenE7ry3SPmj64S1UXyPU63TItYgZkimsv0Dx5m197jh7zoyA9dhxUclInFx4leM05EWy4Rku4/BkamYyiUf+6xv6IyQKrnDpOhmXvqvoFfX1hdLpba7egU/Z3SJWmmri4FTSiNj7CuMjB2k5S9AlBticpU2q6VsLh6F8/OUdcwJHTAGQSGvEt0cisH7db5ZQLENY936r8KXVJyqeEQ71gelXmbypUL6Kf7l/OuAnpW56CJaRspsf89s1V6maI1T+MJgJdEuiyet4usU6Qo2sbmacVVYQcNW9gnbOgP9hkaedXgJuapyIvIQgLUfXyhSPCWLbQzc1U2dTBpR7efm2pg+GJUsKFc1sHrV2xsM5X7uorj+Che0iMVgNeZIyWEYeeg7H8yiIj73NDseH+dGT3CD42kbVdGZFknfpVcNUgC2BPg4pzIsrvj6Ns35KJL7aDDiaSJDAINdA+xD9VOM2mGKJ/DpjZQhPM2betJpdJFbYnI6Vcicog0hAa/2WVg2E46EHU9ksBguBTtGCUBHJvT1D2num5VWqWH0xgRxzYJ7HRZ+GyfBOaB8ZjUDXhQ91/pcu0jNcKd1/fgFyyUYL5CyupRxQckP6zzd/eLRUxVv0D63t9NYCKLq9aMy25azdAq5g7Wca6S3bOrmar08R9fNXtztqN4yFUEmEz657S/3GbHcnQ/7crXPEFna/sHMVFR/RQVjT/IIxzJa90+IUGLYkCh4CS95Cb3DUygxdz7Igzi5/XaJZT/lwP6mxHzvp2J5SZwxqAxqfR0yHEesajE4DmrvbAw9I/ewZKWKWyvO+Wp6oFbfR1m9bxh4yLFLTwuhPy/PrN9RXypm0w9fQCuDOje QVtufnYe E1JGegKuiX0bDBEXyBFI5MmuZL+KxzMDdOEac9tl2w9R4gxY1zSvgydulMXGMGS9xd8ZvQvIOF12qMU/ZHzlyynZuBu5R0a2luDhgjKHk+6UlBWn1Km9vN7bHKi7OuDbXUnIxQD0ET4VxQPr0MxGJCBx/aboDTZ3E9EZjLuKUOJeUfS8nYifRa0X7LHMDutt96B2+2bariDL9QxhXYN3EopEMaOd/NU57AdycSTlTSbbA1y6euUS0NZ8uDkcjqnDswQJ3i7ag7T/cpFaBxfDRE2YK2AORrIyG766drk1D8GwUETI= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/27/26 11:01, Enze Li wrote: > > > On 10/27/26 5:03 PM, David Hildenbrand (Arm) wrote: >> On 10/27/26 07:04, Enze Li wrote: >>> Every other place that accounts a new huge page already calls >>> account_new_hugetlb_folio(), and add_hugetlb_folio() was the odd one >>> out, still open-coding the same two increments. Swap it over. >>> >>> The helper is defined further down the file, so add a forward >>> declaration for it. >>> >>> No functional change intended. >>> >>> Signed-off-by: Enze Li >>> --- >>> mm/hugetlb.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>> index 4a008afaedf9..a8d162449daa 100644 >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -142,6 +142,7 @@ static void hugetlb_unmap_range(struct mmu_gather *tlb, >>> unsigned long end, struct folio *folio, >>> zap_flags_t zap_flags); >>> static struct resv_map *vma_resv_map(struct vm_area_struct *vma); >>> +static void account_new_hugetlb_folio(struct hstate *h, struct folio *folio); >>> >>> static inline bool subpool_is_free(struct hugepage_subpool *spool) >>> { >>> @@ -1444,8 +1445,7 @@ void add_hugetlb_folio(struct hstate *h, struct folio *folio, >>> lockdep_assert_held(&hugetlb_lock); >>> >>> INIT_LIST_HEAD(&folio->lru); >>> - h->nr_huge_pages++; >>> - h->nr_huge_pages_node[nid]++; >>> + account_new_hugetlb_folio(h, folio); >>> >>> if (adjust_surplus) { >>> h->surplus_huge_pages++; >>> >>> base-commit: bae9a042b03b27924c6fd5bdc00a20d6a44d6041 >> >> I have a fix in that area planned. So let's revisit that in a couple of weeks. >> > > Thanks for the heads-up. I'll hold off on this one and resend in a > couple of weeks once your changes land, if it's still needed. Thanks. In general, try avoiding things that are not fixes during the merge window as we try to focus on fixing things (right now more than ever). -- Cheers, David