From: "Jaya Kumar" <jayakumar.lkml@gmail.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
stefani@seibold.net, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org
Subject: Re: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23
Date: Thu, 1 Nov 2007 04:02:44 -0400 [thread overview]
Message-ID: <45a44e480711010102s6ef51f67wff4a796deab0910b@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710301535270.9322@blonde.wat.veritas.com>
On Oct 30, 2007 11:47 AM, Hugh Dickins <hugh@veritas.com> wrote:
>
> I don't understand why you suggested an anon_vma, nor why Jaya is
> suggesting a private list. All vmas mapping /dev/fb0 will be kept
> in the prio_tree rooted in its struct address_space (__vma_link_file
> in mm/mmap.c). And page_mkclean gets page_mkclean_file to walk that
> very tree. The missing part is just the setting of page->mapping to
> point to that struct address_space (and clearing it before finally
> freeing the pages), and the setting of page->index as you described.
> Isn't it?
Oops, sorry that I missed that. Now I understand. I think:
page->mapping = vma->vm_file->f_mapping
page->index = ((addr - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff
at nopage time and then before the driver vfrees, I'll clear mapping
for all those pages.
Thanks,
jaya
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-01 8:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1193064057.16541.1.camel@matrix>
2007-10-29 7:40 ` vm_ops.page_mkwrite() fails with vmalloc on 2.6.23 Andrew Morton
2007-10-29 8:17 ` Jaya Kumar
2007-10-29 10:11 ` Peter Zijlstra
2007-10-29 12:35 ` Peter Zijlstra
2007-10-29 14:28 ` Nick Piggin
2007-10-29 17:01 ` Peter Zijlstra
2007-10-29 17:51 ` Jaya Kumar
2007-10-29 18:17 ` Peter Zijlstra
2007-10-29 22:16 ` Peter Zijlstra
2007-10-30 1:22 ` Jaya Kumar
2007-10-30 9:56 ` Peter Zijlstra
2007-10-30 10:49 ` Stefani Seibold
2007-10-30 12:39 ` Hugh Dickins
2007-10-30 13:12 ` Peter Zijlstra
2007-10-30 13:16 ` Jaya Kumar
2007-10-30 13:25 ` Peter Zijlstra
2007-10-30 15:47 ` Hugh Dickins
2007-10-30 15:51 ` Peter Zijlstra
2007-11-01 8:02 ` Jaya Kumar [this message]
2007-10-22 14:45 Stefani Seibold
2007-10-22 16:37 ` Hugh Dickins
2007-10-22 17:03 ` Jaya Kumar
2007-10-22 17:17 ` Peter Zijlstra
2007-10-22 17:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45a44e480711010102s6ef51f67wff4a796deab0910b@mail.gmail.com \
--to=jayakumar.lkml@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).