From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, zi.yan@cs.rutgers.edu,
kirill.shutemov@linux.intel.com, rientjes@google.com,
lars.persson@axis.com, ziy@nvidia.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
duanxiongchun@bytedance.com, fam.zheng@bytedance.com
Subject: Re: [PATCH v4 5/5] mm: replace multiple dcache flush with flush_dcache_folio()
Date: Wed, 9 Feb 2022 11:10:13 -0800 [thread overview]
Message-ID: <45aa3c81-aeee-7e75-aeff-b122a1f6ac44@oracle.com> (raw)
In-Reply-To: <20220208073617.70342-6-songmuchun@bytedance.com>
On 2/7/22 23:36, Muchun Song wrote:
> Simplify the code by using flush_dcache_folio().
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/migrate.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index c418e8d92b9c..daf2b3508670 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -933,12 +933,8 @@ static int move_to_new_page(struct page *newpage, struct page *page,
> if (!PageMappingFlags(page))
> page->mapping = NULL;
>
> - if (likely(!is_zone_device_page(newpage))) {
> - int i, nr = compound_nr(newpage);
> -
> - for (i = 0; i < nr; i++)
> - flush_dcache_page(newpage + i);
> - }
> + if (likely(!is_zone_device_page(newpage)))
> + flush_dcache_folio(page_folio(newpage));
> }
> out:
> return rc;
prev parent reply other threads:[~2022-02-09 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 7:36 [PATCH v4 0/5] Fix some cache flush bugs Muchun Song
2022-02-08 7:36 ` [PATCH v4 1/5] mm: thp: fix wrong cache flush in remove_migration_pmd() Muchun Song
2022-02-08 7:36 ` [PATCH v4 2/5] mm: fix missing cache flush for all tail pages of compound page Muchun Song
2022-02-08 7:36 ` [PATCH v4 3/5] mm: hugetlb: fix missing cache flush in copy_huge_page_from_user() Muchun Song
2022-02-09 19:07 ` Mike Kravetz
2022-02-10 7:19 ` Muchun Song
2022-02-08 7:36 ` [PATCH v4 4/5] mm: hugetlb: fix missing cache flush in hugetlb_mcopy_atomic_pte() Muchun Song
2022-02-09 18:59 ` Mike Kravetz
2022-02-08 7:36 ` [PATCH v4 5/5] mm: replace multiple dcache flush with flush_dcache_folio() Muchun Song
2022-02-09 19:10 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45aa3c81-aeee-7e75-aeff-b122a1f6ac44@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=zi.yan@cs.rutgers.edu \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).