From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>,
Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping
Date: Mon, 23 Jun 2025 16:09:51 +0200 [thread overview]
Message-ID: <45d66a0c-a5ed-4894-999c-0ed5b732ebb0@redhat.com> (raw)
In-Reply-To: <20250620123014.29748-2-osalvador@suse.de>
>
> - /*
> - * hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) and
> - * pagecache_folio, so here we need take the former one
> - * when folio != pagecache_folio or !pagecache_folio.
> - */
> + /* hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) */
> folio = page_folio(pte_page(vmf.orig_pte));
> - if (folio != pagecache_folio)
> - if (!folio_trylock(folio)) {
> - need_wait_lock = 1;
> - goto out_ptl;
> - }
> -
> + folio_lock(folio);
> folio_get(folio);
Just realized that this won't work for this patch here, as we are
holding the PTL.
In patch #2 you do the right thing.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-06-23 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 12:30 [PATCH v2 0/5] Misc rework on hugetlb faulting path Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping Oscar Salvador
2025-06-23 14:09 ` David Hildenbrand [this message]
2025-06-25 7:49 ` Oscar Salvador
2025-06-25 10:13 ` David Hildenbrand
2025-06-20 12:30 ` [PATCH v2 2/5] mm,hugetlb: Sort out folio locking in the faulting path Oscar Salvador
2025-06-23 14:11 ` David Hildenbrand
2025-06-25 7:47 ` Oscar Salvador
2025-06-25 20:47 ` Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean Oscar Salvador
2025-06-20 14:28 ` Oscar Salvador
2025-06-23 14:13 ` David Hildenbrand
2025-06-25 7:43 ` Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 4/5] mm,hugetlb: Drop obsolete comment about non-present pte and second faults Oscar Salvador
2025-06-20 12:30 ` [PATCH v2 5/5] mm,hugetlb: Drop unlikelys from hugetlb_fault Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d66a0c-a5ed-4894-999c-0ed5b732ebb0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gavinguo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).