From: Mike Kravetz <mike.kravetz@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders
Date: Fri, 2 Aug 2019 10:44:03 -0700 [thread overview]
Message-ID: <45eb7fdb-9390-74d7-6198-6d14a9c78939@oracle.com> (raw)
In-Reply-To: <88e89521-9be2-3886-2155-c7f8d9c22bbb@suse.cz>
On 8/2/19 5:05 AM, Vlastimil Babka wrote:
>
> On 8/1/19 10:33 PM, Mike Kravetz wrote:
>> On 8/1/19 6:01 AM, Vlastimil Babka wrote:
>>> Could you try testing the patch below instead? It should hopefully
>>> eliminate the stalls. If it makes hugepage allocation give up too early,
>>> we'll know we have to involve __GFP_RETRY_MAYFAIL in allowing the
>>> MIN_COMPACT_PRIORITY priority. Thanks!
>>
>> Thanks. This patch does eliminate the stalls I was seeing.
>>
>> In my testing, there is little difference in how many hugetlb pages are
>> allocated. It does not appear to be giving up/failing too early. But,
>> this is only with __GFP_RETRY_MAYFAIL. The real concern would with THP
>> requests. Any suggestions on how to test that?
>
> Here's the full patch, can you include it in your series?
Yes. Thank you!
--
Mike Kravetz
next prev parent reply other threads:[~2019-08-02 17:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 17:50 [RFC PATCH 0/3] fix hugetlb page allocation stalls Mike Kravetz
2019-07-24 17:50 ` [RFC PATCH 1/3] mm, reclaim: make should_continue_reclaim perform dryrun detection Mike Kravetz
2019-07-25 8:05 ` Mel Gorman
2019-07-26 7:40 ` Hillf Danton
2019-07-26 8:12 ` Mel Gorman
2019-07-31 11:08 ` Vlastimil Babka
2019-07-31 12:25 ` Mel Gorman
2019-07-31 21:11 ` Mike Kravetz
2019-08-01 4:22 ` Hillf Danton
2019-08-01 8:44 ` Vlastimil Babka
2019-08-01 3:16 ` Hillf Danton
2019-07-24 17:50 ` [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders Mike Kravetz
2019-07-25 8:06 ` Mel Gorman
2019-07-31 12:06 ` Vlastimil Babka
2019-07-31 20:30 ` Mike Kravetz
2019-08-01 13:01 ` Vlastimil Babka
2019-08-01 20:33 ` Mike Kravetz
2019-08-02 10:20 ` Vlastimil Babka
2019-08-02 12:05 ` Vlastimil Babka
2019-08-02 17:44 ` Mike Kravetz [this message]
2019-07-24 17:50 ` [RFC PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail Mike Kravetz
2019-07-25 8:13 ` Mel Gorman
2019-07-25 17:15 ` Mike Kravetz
2019-07-25 22:43 ` Mel Gorman
2019-07-31 13:23 ` Vlastimil Babka
2019-07-31 21:13 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45eb7fdb-9390-74d7-6198-6d14a9c78939@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).