Re: 2.6.21-rc7-mm1 on test.kernel.org

[Andy Whitcroft <apw@shadowen.org>]

Christoph Lameter wrote:
> On Tue, 24 Apr 2007, Badari Pulavarty wrote:
> 
>> quicklists-for-page-table-pages-avoid-useless-virt_to_page-
>> conversion.patch
>>
>> Andy, can you try backing out only this and enable QUICK_LIST
>> on your machine ?
> 
> Ahh. Right..... The free that we switched to there to avoid the 
> virt_to_page conversion does not decrement the refcount and thus
> is not equivalent.
> 
> Does this patch fix it?
> 
> ---
>  include/linux/quicklist.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.21-rc7-mm1/include/linux/quicklist.h
> ===================================================================
> --- linux-2.6.21-rc7-mm1.orig/include/linux/quicklist.h	2007-04-24 23:35:11.000000000 -0700
> +++ linux-2.6.21-rc7-mm1/include/linux/quicklist.h	2007-04-24 23:35:59.000000000 -0700
> @@ -61,7 +61,7 @@ static inline void __quicklist_free(int 
>  	if (unlikely(nid != numa_node_id())) {
>  		if (dtor)
>  			dtor(p);
> -		free_hot_page(page);
> +		__free_page(page);
>  		return;
>  	}

Confirmed, this fixes the machine.

-apw

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>