Re: [PATCH 00/23] per device dirty throttling -v8

Ingo Molnar
2007-08-05T19:32:31Z

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > also add the CONFIG_DEFAULT_RELATIME kernel option, which makes
> > "norelatime" the default for all mounts without an extra kernel boot
> > option.
>
> Should be a mount option.

it is already a mount option too.

> > + relatime [FS] default to enabled relatime updates on all
> > + filesystems.
> > +
> > + relatime= [FS] default to enabled/disabled relatime updates on
> > + all filesystems.
> > +
>
> Double patch

no - it was not a double patch, i made all the common variants valid
boot options: "relatime", "relatime=0/1", "norelatime" and
"norelatime=0/1". Anyway, this is mooth, in the latest (v2) version
there's only a single boot parameter.

> > +config DEFAULT_RELATIME
> > + bool "Mount all filesystems with relatime by default"
> > + default y
>
> Changes behaviour so probably should default n. Better yet it should
> be the mount option so its flexible and strongly encouraged for
> vendors.

relatime is a mount option already. And distros can disable it if they
want. (they are conscious about their kernel config selections anyway.)

> > +0
> > +#endif
> > +;
>
> This ifdef mess would go away for a mount option

i fixed that in v2.

Ingo