From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.org, libhugetlbfs-devel@lists.sourceforge.net,
Andy Whitcroft <apw@shadowen.org>, Mel Gorman <mel@skynet.ie>,
Bill Irwin <bill.irwin@oracle.com>, Ken Chen <kenchen@google.com>,
Dave McCracken <dave.mccracken@oracle.com>
Subject: Re: [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings
Date: Mon, 17 Sep 2007 21:42:40 +0300 [thread overview]
Message-ID: <46EECAA0.9080300@kolumbus.fi> (raw)
In-Reply-To: <1190050936.15024.89.camel@localhost.localdomain>
Adam Litke wrote:
> On Mon, 2007-09-17 at 20:22 +0300, Mika Penttila wrote:
>
>>> +void return_unused_surplus_pages(void)
>>> +{
>>> + static int nid = -1;
>>> + int delta;
>>> + struct page *page;
>>> +
>>> + delta = unused_surplus_pages - resv_huge_pages;
>>> +
>>> + while (delta) {
>>>
>>>
>> Shouldn't this be while (delta >= 0) ?
>>
>
> unused_surplus_pages is always >= resv_huge_pages so delta cannot go
> negative. But for clarity it makes sense to apply the change you
> suggest. Thanks for responding.
>
>
I think unused_surplus_pages accounting isn't quite right. It gets
always decremented in dequeue_huge_page() but incremented only if we
haven't enough free pages at reserve time.
--Mika
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-17 18:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 16:39 [PATCH 0/4] [hugetlb] Dynamic huge page pool resizing Adam Litke
2007-09-17 16:39 ` [PATCH 1/4] hugetlb: Move update_and_free_page Adam Litke
2007-09-17 16:39 ` [PATCH 2/4] hugetlb: Try to grow hugetlb pool for MAP_PRIVATE mappings Adam Litke
2007-09-17 16:40 ` [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-09-17 17:22 ` Mika Penttilä
2007-09-17 17:42 ` Adam Litke
2007-09-17 18:42 ` Mika Penttilä [this message]
2007-09-17 20:07 ` Adam Litke
2007-09-17 16:40 ` [PATCH 4/4] hugetlb: Add hugetlb_dynamic_pool sysctl Adam Litke
2007-09-17 17:37 ` [PATCH 0/4] [hugetlb] Dynamic huge page pool resizing Dave McCracken
2007-09-17 18:07 ` Andrew Hastings
2007-09-21 5:16 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2007-09-24 15:46 Adam Litke
2007-09-24 15:47 ` [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-09-27 20:08 [PATCH 0/4] [hugetlb] Dynamic huge page pool resizing V5 Adam Litke
2007-09-27 20:09 ` [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-10-01 15:17 [PATCH 0/4] [hugetlb] Dynamic huge page pool resizing V6 Adam Litke
2007-10-01 15:18 ` [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EECAA0.9080300@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=agl@us.ibm.com \
--cc=apw@shadowen.org \
--cc=bill.irwin@oracle.com \
--cc=dave.mccracken@oracle.com \
--cc=kenchen@google.com \
--cc=libhugetlbfs-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).