From: Mike Travis <travis@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v2
Date: Mon, 24 Sep 2007 10:22:35 -0700 [thread overview]
Message-ID: <46F7F25B.6010706@sgi.com> (raw)
In-Reply-To: <20070921154622.c6920dcf.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Thu, 20 Sep 2007 14:30:05 -0700
> travis@sgi.com wrote:
>
>> cpu_data is currently an array defined using NR_CPUS. This means that
>> we overallocate since we will rarely really use maximum configured cpus.
>> When NR_CPU count is raised to 4096 the size of cpu_data becomes
>> 3,145,728 bytes.
>
> This has at least three quite obvious and careless compilation errors.
>
> Please at least compile the code after you've altered it.
>
Sorry for the build errors, my test build scripts obviously were missing
a critical kernel variant to test build. I've fixed that omission and
increased the test build matrix significantly:
arch-i386-allmodconfig
arch-i386-allnoconfig
arch-i386-allyesconfig
arch-i386-defconfig
arch-i386-nomodconfig
arch-i386-nosmp
arch-i386-randconfig-1
arch-i386-randconfig-2
arch-i386-randconfig-3
arch-i386-randconfig-4
arch-i386-randconfig-5
arch-i386-smp
arch-x86_64-allmodconfig
arch-x86_64-allnoconfig
arch-x86_64-allyesconfig
arch-x86_64-nomodconfig
arch-x86_64-nosmp
arch-x86_64-randconfig-1
arch-x86_64-randconfig-2
arch-x86_64-randconfig-3
arch-x86_64-randconfig-4
arch-x86_64-randconfig-5
arch-x86_64-smp
A corrected patch follows.
Thanks,
Mike
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-24 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 21:30 [PATCH 0/1] x86: Reduce Memory Usage for large CPU count systems v2 travis
2007-09-20 21:30 ` [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v2 travis
2007-09-21 22:46 ` Andrew Morton
2007-09-24 17:22 ` Mike Travis [this message]
2007-09-21 10:16 ` [PATCH 0/1] x86: Reduce Memory Usage for large CPU count systems v2 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F7F25B.6010706@sgi.com \
--to=travis@sgi.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).