From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux MM Mailing List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Swap delay accounting, include lock_page() delays
Date: Wed, 31 Oct 2007 16:54:24 +0530 [thread overview]
Message-ID: <472865E8.4070908@linux.vnet.ibm.com> (raw)
In-Reply-To: <200710312010.33833.nickpiggin@yahoo.com.au>
Nick Piggin wrote:
> On Wednesday 31 October 2007 18:41, Nick Piggin wrote:
>> On Wednesday 31 October 2007 18:52, Balbir Singh wrote:
>>> Reported-by: Nick Piggin <nickpiggin@yahoo.com.au>
>>>
>>> The delay incurred in lock_page() should also be accounted in swap delay
>>> accounting
>>>
>>> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>> Ah right, I forgot to resend this one, sorry. Thanks for remembering.
>
> Although, I think I had a bit more detail in the changelog which
> I think should be kept.
>
> Basically, swap delay accounting seems quite broken as of now,
> because what it is counting is the time required to allocate a new
> page and submit the IO, but not actually the time to perform the IO
> at all (which I'd expect will be significant, although possibly in
> some workloads the actual page allocation will dominate).
>
This looks quite good to me. I'm off attending a wedding, I'll resend
the patch when I am back.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-10-31 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 7:52 [PATCH] Swap delay accounting, include lock_page() delays Balbir Singh
2007-10-31 7:41 ` Nick Piggin
2007-10-31 9:10 ` Nick Piggin
2007-10-31 11:24 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472865E8.4070908@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).