From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EE9C83F1B for ; Wed, 16 Jul 2025 11:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E697D6B0099; Wed, 16 Jul 2025 07:16:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E40BE6B009A; Wed, 16 Jul 2025 07:16:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2F3F6B009B; Wed, 16 Jul 2025 07:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C478D6B0099 for ; Wed, 16 Jul 2025 07:16:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7EFDB160375 for ; Wed, 16 Jul 2025 11:16:00 +0000 (UTC) X-FDA: 83669873280.04.CC80166 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1E73FA0009 for ; Wed, 16 Jul 2025 11:15:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i9QDB0ON; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752664558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QnnkqItLsI0ARk49iyBDkOyecK6Jk4xqS5efHEoSN08=; b=FccOpp2CaOnT67D+WlBtt9MccN7Z9SWSXoIC4n2amThY5VEdEaAin9F2SUUn51DpItBcHi HXdBqEvZ+OjmM5ga998l9ceg6qs4VuqRrgz/bhNlF/Blr1RiMBEuMYM9d05ofNJWYcLWrg d4GA6HLtSqfbSmDF1oZ+PC8P1vOFF9Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i9QDB0ON; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752664558; a=rsa-sha256; cv=none; b=wGJCNSUhg6Jdpen7vlNbuNwmzGpB4Y4BXVgoVlIUeikI2rVKf6jgRwJdUE/r8Kn7/nE/lb 66f2IQvHDZFthljKLrm6SKNUOizh7a6UMD1AKw4PFagaYAzJ5lKC/P9EKjX+0F/fu9s7a5 nxe1wxGZYyQriltzbCASAsyKtjZob6E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752664557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QnnkqItLsI0ARk49iyBDkOyecK6Jk4xqS5efHEoSN08=; b=i9QDB0ONskffGC8T9kFHCK0VqC8CJAtaZqGmqI+JWLAfP757mBQGfZ1qlu0/DqyJR9BYgo sMkomrnLYdy8ZPyLv+iweTcXwzdLJiYalHnE8+70rydDcdR8AAXMYjQI7xl5DLOHP3fumf h/aMqYHFbON83yDnOjWHRKajKEWld74= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-nFS-t2NlPOmxzo2AZeHBeQ-1; Wed, 16 Jul 2025 07:15:53 -0400 X-MC-Unique: nFS-t2NlPOmxzo2AZeHBeQ-1 X-Mimecast-MFC-AGG-ID: nFS-t2NlPOmxzo2AZeHBeQ_1752664552 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a50816ccc6so3974375f8f.1 for ; Wed, 16 Jul 2025 04:15:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752664552; x=1753269352; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QnnkqItLsI0ARk49iyBDkOyecK6Jk4xqS5efHEoSN08=; b=J1rzogtN7OEPL+0sPshjs2GitUFqbxi9YRzts5QtO3V2JZsHnhRXzLwIwJsfTGL2yT cIpwg1vmf16SMpYMS6hWAQuXOjwOsd1pqUDXxgwLWvBo2ZaCfgT6uWfV4A4xWRO5TjUg VXLClrVadkRU7ZoVodCWWeEvOpdpoA6mwhoZVqtDHGZvIBHiw7jd93Y1EQ+GVggmm7V+ jh5a7Mfto93Nhyc/KKIlhc+IqR0e+R2Vn8FOeXYfFX2hruaJDub7vE7bk0Dnhw/TfqMs WAx2sYO/qDJ8pPWpG3T8O1rVeHx1gOIlS6bNo1bDn/qu6DuFqzp5B+WS0wxjG29g+Mwl Uj/Q== X-Forwarded-Encrypted: i=1; AJvYcCV9lXPac8U4XT4kLyJX3OBWAyGShtx4Fa53WigJqPCZPPYf9IX0LJj+dWIn1EiVmYOMRmhF392i5w==@kvack.org X-Gm-Message-State: AOJu0YzPFasbk9Jxpfcm3Fmhvnx2LcmqJhyb1MwDjVDrHe1v2HnuNpA2 1l5n+/VwVL3rdjw70T+0Af+KU54uoZLmonJQfOLjcjbUikjlw8AjKb75YNfwOkOIotmB4LKycrx vTZ8cnILDEk3XDuD3X1jMNy2s64NwD0D1ToRNMgoO6Pn07E7/R6al X-Gm-Gg: ASbGnct5b16J1AqLzRUl1OELBJFfUnrXVQ7tlqTprzqOLKlSNJ1C+3h1YY7Ob67h4JZ epY8+T3/KgiPlTU0DlxkWVwRa5tBdKwr/tiaUtsRs3C11s3zdlcM7hIrexRC5yr/t+sUJjhgY+d U66D2pMtGsCzxgAoA7rxqNVSE7aLz/u8/lsGK3x9qCC4OMJF7mZUCOCBjfkFGRiGnKt19LXB3FF 3ZiBq2GcyIyxtbncWKLeis/o9vTmmPyMMHd9BJA09LuyhdQdUfUxFEhfQtCDkvsLZ0f4CQCtmRP 960opo9p0dq0eNYMVRgIgwxFKogBSLa5vpX5S8us4ScM8lJMVWffRAuyxNL6gJpo/4cbOIY= X-Received: by 2002:a05:6000:200e:b0:3a1:fcd6:1e6b with SMTP id ffacd0b85a97d-3b60e541208mr1948917f8f.57.1752664551987; Wed, 16 Jul 2025 04:15:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfBjAbx9P8Bar8PsKPqzUpQU/lrsluFZuBY7lqugO5P66Q0CRJf1PBvMJnWIt0zO2geFf+dA== X-Received: by 2002:a05:6000:200e:b0:3a1:fcd6:1e6b with SMTP id ffacd0b85a97d-3b60e541208mr1948841f8f.57.1752664551376; Wed, 16 Jul 2025 04:15:51 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f26d.dip0.t-ipconnect.de. [79.224.242.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0dc3esm17428114f8f.47.2025.07.16.04.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 04:15:50 -0700 (PDT) Message-ID: <47395660-79ad-4d22-87b0-c5bf891f708c@redhat.com> Date: Wed, 16 Jul 2025 13:15:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Fuad Tabba , Xiaoyao Li Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> <6927a67b-cd2e-45f1-8e6b-019df7a7417e@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GpdohavAqMEJsgwIpIg6aIjc3LCzzbTpFdCF_Ej9tio_1752664552 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1E73FA0009 X-Rspamd-Server: rspam06 X-Stat-Signature: gb1wzie1kbxxxhx56xx4eitskd3mxy7w X-HE-Tag: 1752664557-144838 X-HE-Meta: U2FsdGVkX1/WFw8a/ot2+hHJT1rE+oNokxJNhU6VB1zxBEW8SDN8/kN6b5v8oMyiuCwK7LEY21c5EMEKyH/YuhopGmkDQZhH9Yo4DqHbbkqGWGMgFh7NEE12ZHe8JEuBy0iENZ+X1DnuQOS5F7OzWXI1E7wfU59RqeSjpioAXJdTJGXFu9G2dv6OVO+KdjzfmdL6JscQokX94JBipneJVkYvq+wUXYPDXnrHOrxmf/CG7qE8gJ3V78xLfVoiTbXYZgN9AboYwp5qP3qniPrwsL2InGmZC3ZJiaeG0bPbLj4O+C8yvW4zRQ13foTQE8fbohMrAnTFxQQik4BQu+jxwLcTvKsRbv2tm1VCC+VyzAEAk5hIxVvTFQ6sqcDpz4qwlDqYN0pYkjEptLfB2IhD6S8xFYUg6RMBFrB0aKzpMolPDHSRa/S7C6U1muAukUwDuxT+0QZFs67eG0zg53pcb26RQRmjbx9ZYMd89bFweJIpAdmZkRFlaLoYAwjoeUoe3ZhldVP/LJL5wUm09+V0v9B19vuVWGhsBz47WDgyuIce6JyNoKhSnq9Y4IQYWCMnSQWLD9mVIZnS/X06LijecsiGfY6dODYJv/MK9n5whAGM2aExdTaCW1UTcGXAbsu1hhsJQF8G5cAnksbPK54VqpH/qYXmxtOeHvcyT0bV1PEbZdOLxOqWq8vEVhUPiQmehdYiyRDwVUrYRDpTcHWPhP/Je8vhu3qo/jXpGR5NDpgMX+l+hQJ/OnQFQRepeHfN92pLOflahlchf60azoFt50Mekb0oAxvhn/OqbRvrlF92huQfhOFadQ7CwKRs3Jw2aCt+o+OeOUgxWL6Nt3EZ5QclMXcU6tz9Q59IAv4m0kMYQ1HWnrGrPjk5FSTwLjsd7S61qytWnxNBp+hhNUz0tMTJCXZLxTQQR54sEVEAOOHmAif8U0SBujBMT5EW0LEEIZXWxb2n8pvo3kjKhpS HZpEh162 Xs941BjKYjoKh1efDO1tzv8Es2QjwLMRiZ6Sv3YB83loh9YC1rbxc+3u1Z3BT1GAKAA0qlnJiawu84tP2p2YSkk8LNEPL1aiEeu7UWKch+Xj3m0DzMrI1gv41YWu+VzORV3kbKEXlOFCizNg6neYgN/oEj8IuDQ5DCnK9gILxZkd+XgCheOQzOb+/DD4t0keH7F5lH9sESLfC14jG6C03q7ZtiyN5rPtukJpwWPvu8fZgi4sJ8fPOJx1aOBVE2LJVWM16Qx0AGcG78S/bAOdWY3Ans6va9/aFEbD0mfYnQLDGmUM27zTBULyfiM1RtMi1eQ+IxIWZ/++oFBqK8Br0QjniZ0XecBpTfSmU5xrMpD6SixS52oZv+1Fr/zID0Qpk0cfh6WHGKXwUa3A0lqVXkP6znwxo3xPCY/grm1DsxbjvKwF+ONTZO0crJME9iS/JOE+51PPRd0EPOymM+d4kFzOfLxtSTjyJYRNWf3+GJtCw3+In36bUFJknaFWJ0quid5Ejqkpa/juTBPZMT2RMUNqEESGpFm7ETeIPZI0wUlgDb0hHXaE4rw8yHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 13:05, Fuad Tabba wrote: > On Wed, 16 Jul 2025 at 12:02, Xiaoyao Li wrote: >> >> On 7/16/2025 6:25 PM, David Hildenbrand wrote: >>> On 16.07.25 10:31, Xiaoyao Li wrote: >>>> On 7/16/2025 4:11 PM, Fuad Tabba wrote: >>>>> On Wed, 16 Jul 2025 at 05:09, Xiaoyao Li wrote: >>>>>> On 7/15/2025 5:33 PM, Fuad Tabba wrote: >>>>>>> The original name was vague regarding its functionality. This Kconfig >>>>>>> option specifically enables and gates the kvm_gmem_populate() >>>>>>> function, >>>>>>> which is responsible for populating a GPA range with guest data. >>>>>> Well, I disagree. >>>>>> >>>>>> The config KVM_GENERIC_PRIVATE_MEM was introduced by commit >>>>>> 89ea60c2c7b5 >>>>>> ("KVM: x86: Add support for "protected VMs" that can utilize private >>>>>> memory"), which is a convenient config for vm types that requires >>>>>> private memory support, e.g., SNP, TDX, and KVM_X86_SW_PROTECTED_VM. >>>>>> >>>>>> It was commit e4ee54479273 ("KVM: guest_memfd: let kvm_gmem_populate() >>>>>> operate only on private gfns") that started to use >>>>>> CONFIG_KVM_GENERIC_PRIVATE_MEM gates kvm_gmem_populate() function. But >>>>>> CONFIG_KVM_GENERIC_PRIVATE_MEM is not for kvm_gmem_populate() only. >>>>>> >>>>>> If using CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() is >>>>>> vague and confusing, we can introduce KVM_GENERIC_GMEM_POPULATE to gate >>>>>> kvm_gmem_populate() and select KVM_GENERIC_GMEM_POPULATE under >>>>>> CONFIG_KVM_GENERIC_PRIVATE_MEM. >>>>>> >>>>>> Directly replace CONFIG_KVM_GENERIC_PRIVATE_MEM with >>>>>> KVM_GENERIC_GMEM_POPULATE doesn't look correct to me. >>>>> I'll quote David's reply to an earlier version of this patch [*]: >>>> >>>> It's not related to my concern. >>>> >>>> My point is that CONFIG_KVM_GENERIC_PRIVATE_MEM is used for selecting >>>> the private memory support. Rename it to KVM_GENERIC_GMEM_POPULATE is >>>> not correct. >>> >>> It protects a function that is called kvm_gmem_populate(). >>> >>> Can we stop the nitpicking? >> >> I don't think it's nitpicking. >> >> Could you loot into why it was named as KVM_GENERIC_PRIVATE_MEM in the >> first place, and why it was picked to protect kvm_gmem_populate()? > > That is, in part, the point of this patch. This flag protects > kvm_gmem_populate(), and the name didn't reflect that. Now it does. It > is the only thing it protects. I'll note that the kconfig makes it clear that it depends on KVM_GENERIC_MEMORY_ATTRIBUTES -- having support for private memory. In any case, CONFIG_KVM_GENERIC_PRIVATE_MEM is a bad name: what on earth is generic private memory. If CONFIG_KVM_GENERIC_GMEM_POPULATE is for some reason I don't understand yet not the right name, can we have something that better expresses that is is about KVM .. GMEM ... and POPULATE? -- Cheers, David / dhildenb