From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088D0C27C76 for ; Wed, 25 Jan 2023 10:20:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CDAC6B0072; Wed, 25 Jan 2023 05:20:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 856686B0073; Wed, 25 Jan 2023 05:20:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D1976B0075; Wed, 25 Jan 2023 05:20:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D60C6B0072 for ; Wed, 25 Jan 2023 05:20:12 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C0F3160D4E for ; Wed, 25 Jan 2023 10:20:12 +0000 (UTC) X-FDA: 80392926264.10.203602E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id EB3FA40014 for ; Wed, 25 Jan 2023 10:20:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KOT0Dgs+; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674642009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4bssfLw84Lb1N2+6RHiO1GbN0bUTWIhyPpZgbdiMIPk=; b=qZesaeJm8bY4swBioNlWrDlsQiNewrjSfYWgS/0/djRnWHfETQqqT6SVKM32zx6Tntn3ga dhtgzkjfd1NlruVk5p9qZHnEw2QA0fdoExlkdbLfnVJEXLyEzdK2bXbNihAQ7WRr5ken+Z rVfugpYv5YHi3dTl5dndf8MrGe0LtSU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KOT0Dgs+; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674642009; a=rsa-sha256; cv=none; b=WlxXHkO5iWAcOuetv+F892iDc4SEIE3r8f0EmYm6qzKm32rf9lz06DXYzcbkOHUMS8B08Q KDhdbdbjQac4cfEctgUrehiAPW7IDQl15R/ozcviYmByGn3uec4RAZ+5rjssoQa8ka++IP +xZBkFMhGNpJoNfnAYOI9/pfaYGYVIU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674642008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4bssfLw84Lb1N2+6RHiO1GbN0bUTWIhyPpZgbdiMIPk=; b=KOT0Dgs+USeIbyOEDfp0ZBPewL/V14U3LsI2G/4lzvuRtm/ICyhnTbi2OJ7A5h0gfSS3ud k3IaKCdk81T1vUuBx5Qjoxu8Xwl6s4CcnfOoeNAUS/ualVLklxz2sOYA3eNtnMBlTpskBH rsu0VE9PiH/CDxB8ys06RWM/AIfxqaM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-248-NfHTHLv-MaG4_yms1b5lEA-1; Wed, 25 Jan 2023 05:20:06 -0500 X-MC-Unique: NfHTHLv-MaG4_yms1b5lEA-1 Received: by mail-wm1-f71.google.com with SMTP id c66-20020a1c3545000000b003d355c13229so873326wma.0 for ; Wed, 25 Jan 2023 02:20:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4bssfLw84Lb1N2+6RHiO1GbN0bUTWIhyPpZgbdiMIPk=; b=bHT9Bx4nsa7D7EPXbHwe+h5APe/KaD/T8ysVUWnPzxbxSuPdnhtuWWs69q/iZ9KFvD gacopXQli4d8yWHAlckw62ROkf7zR8o9M7WIsBWNAJU02BPR4xeCYpDAw90lBHRMMI6t UWnL1ZdZBCKpuK9SNZp+m2Vbv0QAM1dEnpky3OuCQiUX0QHiIua70w3dIHxulplzXd+P nZpFa1XK/zq/kVjLey85IUG0mTqOUEUSkLuyqoMramBk2ZKJRPPcT9ViLWQejnwvTIBB Dn0OI1T+F9C1nUxdp4RCy9RYJgcLsJteGniJ9SJpRgD+AORF4GXtsWu087Acuro4/sbI MfHw== X-Gm-Message-State: AFqh2koxCbx+LxY1vrMxXfX9j+CY3MyVaj3Uc6rl5FWptwqE/c04sa7s IeLEzbj83y9JXac0uO7BEr5NcVHnbHu2FGBbwVXNwbTnA8DCyaMSPDL/ZeVGTUZCZtrDER76Hii 6I7viUhAI+s0= X-Received: by 2002:a5d:468d:0:b0:242:63a3:2f20 with SMTP id u13-20020a5d468d000000b0024263a32f20mr26543595wrq.11.1674642005021; Wed, 25 Jan 2023 02:20:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsImpo4DVb+FWP/+3Gl+b6mHKQE0MrGjhKBUuXH/RHYpSJ+CP/A2OZOuIBI5/pbLvN7dkK3EQ== X-Received: by 2002:a5d:468d:0:b0:242:63a3:2f20 with SMTP id u13-20020a5d468d000000b0024263a32f20mr26543579wrq.11.1674642004669; Wed, 25 Jan 2023 02:20:04 -0800 (PST) Received: from ?IPV6:2003:cb:c705:4c00:486:38e2:8ff8:a135? (p200300cbc7054c00048638e28ff8a135.dip0.t-ipconnect.de. [2003:cb:c705:4c00:486:38e2:8ff8:a135]) by smtp.gmail.com with ESMTPSA id j7-20020adfb307000000b002be063f6820sm4904478wrd.81.2023.01.25.02.20.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 02:20:04 -0800 (PST) Message-ID: <477bbc1e-a60a-cfce-d31e-0b4bdd5f6429@redhat.com> Date: Wed, 25 Jan 2023 11:20:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH mm-unstable v2 1/6] mm: Add folio_estimated_mapcount() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <20230124012210.13963-1-vishal.moola@gmail.com> <20230124012210.13963-2-vishal.moola@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230124012210.13963-2-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: md8zgggekj9pwnc3amu6s8zdxxis67h6 X-Rspam-User: X-Rspamd-Queue-Id: EB3FA40014 X-Rspamd-Server: rspam06 X-HE-Tag: 1674642008-190639 X-HE-Meta: U2FsdGVkX1+wM9A1qZmU6bAfdJpj36MMr6HgV/l/tOT9byQRCC+jEEvjvF9EYWOpcg1OirMEDUn3ntx2sWElt+ZeNjy/i1ob6xwCz9Qvdpj/ZAc4VW8S/jxpUvjASvBXekCx9rSvoYuxyy7/IdyW6EQhhx5q3Hyw8RJd5SEbl1gopTyTvl3eoini/nohX4jZVxoYZwYLJ0zkK9ciactP4vG0WDhVTLGmgmoYa/OULL2Kv8vxTmcTEjaMENsAfSSa3UdsqJPVREQKN6c+LVc1rxjfNUIrM0eGspPBk6VPRxp+WFyyDnZl7H4A55+eIk5MNtPLcxECcWmOPWvBpQ2qUyslAwKibtkDRhn0jKRXfSRQ6A2xR1ZbrqVyMbf5XV60G3JplX20xc2F+6h6sG932mwhlw8CWmuDfETiWbr+NtKGtegqHPZNDv2gr7KKZEsTynqn675QEIEKpiqPb1g2jK5hL2MVb6KbQcQAuE/B/8saGLalhmnvNEBUBZW5HpmiKo/mzDp9FQU6ytoxMFgthyTWk7VLzGbqfj3B2tQ0uvuWxKtKsj5Ghyy2yP9oicOmliU2KbkmecImhT9YbBfKZt6h1mTrBymFHbObS/ABiqdIaBhFoRtgGq1db6yqP/L7kXaPBc4NxJjFGGSC01dNStD1oKbOf8h7WjxEYulXFiBkRwOmpkO6x/DSTKhip+CE2B9Xwdfy29FbPKA12OiSStZQS7OR6WhK/FmTY7VjtBl/BCxjBIit8kWBpnENzJ3Ntd8YSXc8yijC8/oHyL6AyZOdzSl0UlcdZlQtg+SMFMGZydVijM9lgRJ4QT+TbPfR3q35jqOhkaaViWHsjyXaFn8IqeYEicAPcZIu70JdHKEqZcTAaJxcRimjkC4IDSisqq/7SvyqKZ9UxCcBZx2sbG8LZ+ucy00XGEDG6f0IXVm7VIL3MuHrJU5xgQc4la1fFG+hXTAIHnLLJa+KCiQ 8M05Kmtc UGCj5/odayieftHjy+Kf6yRV5ZebilRmFQxuhZ4Ix7bmVQTGUk6iVL+YitlFgcTwWuIXe5Mv9LEVXMHjXoOAVdOVCPmdEK9oC+54uc9PrxUTApqTIqi0PjuDyW3bb4Jf/+/CG91e5PL9UrlTfcw3eWiE8ufiL+PKaelH1SWpQnvK6qwVeYMDdg2bw2VVhvesAzEf6GA/su4IWOK1Rs++yYd/tCJFsghlVKoiZEaoRS7isUFeCqRO+FHYSaL4N/fUjSLHaLI8uv2U0MEbGGT0EqNEzkvQq8ogWhMrU8UJmFN+aB81GcOf13jvTotAtz0/bs9GmXCaoD5IRMGm8m7A5YU/3qL3lifGQffaoyn47csg7QmrqF4pszcD4zChsakw4Fj/lDmm5eMYE9n547LfEOkPXHTcB4mq41/O7ZAP0nT9UrPqqgD90DhE8Rb3sijJ2uCGxCchUKr3l/26HC5+5F7SddB7M5Qb3Cp4jxocbh9CWzgXk9V30VGBa1RI4fRZrfpRQTBZX5fvjQ4Eq3XC6uZQtr09E6znGZPXj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 02:22, Vishal Moola (Oracle) wrote: > folio_estimated_mapcount() takes in a folio and calls page_mapcount() on > the first page of that folio. > > This is necessary for folio conversions where we only care about either the > entire_mapcount of a large folio, or the mapcount of a not large folio. > > This is in contrast to folio_mapcount() which calculates the total > number of the times a folio and its subpages are mapped. > > Signed-off-by: Vishal Moola (Oracle) > --- > include/linux/mm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c9db257f09b3..543c360f7ecc 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -875,6 +875,11 @@ static inline int page_mapcount(struct page *page) > return mapcount; > } > > +static inline int folio_estimated_mapcount(struct folio *folio) > +{ > + return page_mapcount(folio_page(folio, 0)); > +} > + > int folio_total_mapcount(struct folio *folio); > > /** I'm sorry, but "estimated" as absolutely unclear semantics. You could have a THP mapped into 9999 processes using THP and the estimation would be "0". Huh? Absolutely unclear and confusing. No thanks. -- Thanks, David / dhildenb