From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F58EC77B7C for ; Wed, 25 Jun 2025 15:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22ED38D0008; Wed, 25 Jun 2025 11:34:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DEF08D0001; Wed, 25 Jun 2025 11:34:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F54A8D0008; Wed, 25 Jun 2025 11:34:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 017908D0001 for ; Wed, 25 Jun 2025 11:34:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7121E59895 for ; Wed, 25 Jun 2025 15:34:55 +0000 (UTC) X-FDA: 83594320950.27.3ADD9E9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id F40191A001A for ; Wed, 25 Jun 2025 15:34:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ePdnUVm8; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750865693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L6U7uSZ3zn6lSctvvHLf/6IoHum5TuGxKVo47SoLtfs=; b=WByJb0BCupVaiZyuPlL0Jzww810G6KypX5vE8G8Qy2Hu1w/5ESF0L6HvsJAzWD+Lz1m/T/ ApGGbY11dJ4yX8jj+hxhqZ74yuTQUplUHtAITLav6ClilSSx5cCgtE0Z7WwykulGd3r7a2 5f3rres12OB2GB8jnUVfghlf5VKA18k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ePdnUVm8; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750865693; a=rsa-sha256; cv=none; b=MXZbiMFQpiRf+wALf98RN7yotBD98iD/OujTh5XmoeUse/J35c+YJgjWLnbIdnWzMTQCvj uZiGuh89VH+UOgs43EU3aoxP9YnHHUqFiQYmLMa2uZ6sGMLWOoiHjmMhLPJ6UWIOifqgpf vclUXVYQlNDHIe9C6vFecPRM+AHmlYs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750865692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L6U7uSZ3zn6lSctvvHLf/6IoHum5TuGxKVo47SoLtfs=; b=ePdnUVm8FgOsMhKxbVz3pVM5qTOdUyRchSn1Sf2NT/yhorjNGnExAm5BLmHB0Q9adk0GTs wJBCiqcH2bcY3vg4RD6W+fWog83KytM2D0wmSZhB8Q4dMhs/RJlnMCATyBipdACWvGThuk 5Yrn5FTHB7GpN9hbXrrEHTruEOGRXq4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-n_c7TMUtOly4HACLuj1SGw-1; Wed, 25 Jun 2025 11:34:49 -0400 X-MC-Unique: n_c7TMUtOly4HACLuj1SGw-1 X-Mimecast-MFC-AGG-ID: n_c7TMUtOly4HACLuj1SGw_1750865688 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451dda846a0so51474025e9.2 for ; Wed, 25 Jun 2025 08:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750865688; x=1751470488; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L6U7uSZ3zn6lSctvvHLf/6IoHum5TuGxKVo47SoLtfs=; b=RV2TZea8CtZnDF15Hj1xsjkfFXKr++1eAj29VfmCv6wUeGEQbb0lI2QPfwFXKnSfwl 6kImy4UQiAkCzDAW1QgK1dmwCTcAAlZk69ZBQJB/We8RFy7mfup0Wu5Wb0umrDKCQ66l VlzdUlWhQ9cYHRSRz8TjIIfL877tonOvJDXeMPfhuotXgxJHNuTlHYhsJZDENgxHSedp gda9L8V2oSQwodnkjGXT8q/vBAwnU3qHrc9wiU27Le5+CUXFuBJN2usX2lXTc0kqgXWV bI+HzL2bLqAnXpZ4zYGbP6J7tkYjtNKEkFKCHRToXgrsagKI8g4MEDCjqmEyRN9+Q5ne wRAA== X-Forwarded-Encrypted: i=1; AJvYcCUBebdC21a1+hmmX+ccM3W3mwPoMnsX5/r3Alr06jWvzuavobTJgtxc35NhkYbqDueIRjXu5VidCw==@kvack.org X-Gm-Message-State: AOJu0YxC8YCI51VjwqUxEeeIuLmdShc7FRDFRGw6BgYHQlMhil00WigE g9FIb7LxbTPCxhW/z1JC9UrhtN23AIyWDNNs0XlflQ0PBDL/DNlAq7H5/Wv8eu60zqGYRztktin VaiwyoFUUivFBIOrYlAa13AB20XggU59gOfkSnEOJjrPNsbcHUW4h X-Gm-Gg: ASbGncu/+ku1T3ppGZn2JFf3/i645riQXC+2Em31YuUq8fcVK9SbaUmXf4oHddrfzMz tYGo4y8AgChys1QLLTX2B0vFhR2DB+rG8uGy0CRK9QXGHcEkKsYfQ11AMs56suXRKgcU8sQ3o04 OUjpYll9P+FpJfOE7d7Xxe+6DdB2mwawznUY3qSGRZQFxQ9iYcV6EZZD1klbdG7Um2CXqxixG5a 2xaXNHbPLyEnzIc/vL/PulRBV3D1jbehidqlO1PWixqzCn8X5GBkKIEd4uUCHo3SretOIX5MYvP alXZLd4A3efJ7j+oFcsZQoCXYlXbElWR5DFjOoukvTWuoNYz6LRTLQLpQiWQRsCzp93/Q7lkDy7 /otuj7MfmzhOqJ7tK3tRUEUFESyP4y5cJT9hcao2l5aCQ X-Received: by 2002:a05:600c:a302:b0:43c:fda5:41e9 with SMTP id 5b1f17b1804b1-453821b0a2amr28702195e9.31.1750865687752; Wed, 25 Jun 2025 08:34:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3G62Xle62kvZpcNmhC/QVpFryCSUhbFB9UamD6FGT8RaMoB3EMzXfizx4te1AkopeO5/XYQ== X-Received: by 2002:a05:600c:a302:b0:43c:fda5:41e9 with SMTP id 5b1f17b1804b1-453821b0a2amr28701915e9.31.1750865687375; Wed, 25 Jun 2025 08:34:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c3a96sm23252415e9.35.2025.06.25.08.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 08:34:46 -0700 (PDT) Message-ID: <477c1b34-6acb-4e49-b9d4-f52d93597c90@redhat.com> Date: Wed, 25 Jun 2025 17:34:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 next] mm,memory_hotplug: set failure reason in offline_pages() To: Dan Carpenter , Oscar Salvador Cc: Andrew Morton , Harry Yoo , Vlastimil Babka , Jonathan Cameron , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3tm-KANxM2TD5awznbdWJ-Tl3f_Z-6l8jbH8Lblywfg_1750865688 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F40191A001A X-Stat-Signature: kye49jypjcsm6zsnqi7psy74ip7cpkmi X-Rspam-User: X-HE-Tag: 1750865692-992786 X-HE-Meta: U2FsdGVkX184B4jACBVRwIpta78VEjtvqmhV/0QD5we5KWLR6Op1JjsiKjrBmL5OhmBVj0GDydxb293u8NJRCBpRjYOv7ojtLg+lmDH4M1204Ngca42vXIFx4/LSJcc5SbYLK98qpmHDcBtGFAzcBSa4Rj7nkmmyad+3WCeI+kJzzOHnrpwtLM3vM8G7a8H8uH1bEUyr7JrcGvM1rLMAIbt+wJaY5u9bhJxnbh9+KV/ManHSIznnJST5Ju4WXJXhKEbT1oNy/zV5qRJLeOX/Ci4l8qR3zgVdw1K9KC3nF5KowZ+lN7kRd7Y8kcuaV9CDbGwOvxTJdYqWH1jrxPhWjJj2gBfjVc9T+dQiTU17cwDhmm7ptrMtqjDbWfsHuyq/DBWrGf5LuMMukVXgpqVuOrXyfckieX3qLXFenMTzopMuW51tvuO1/vWziRfnz2egVP53N5asAmWepmzhE0BSs+woVAW7dDWiqe6HXMctxWcJt94ctRpKsmTEiI91GWEGbWD3IxdaaD3uMwB01Vbuzcxks7logBJcbqkFf+Me3WNcXWLi9T8T4dCCzmcK9dkKhqZUy7j+RB1IzNTGwpLUrO57NGkQ6WaGu+rahRixZFJrafE743LN2BOShZWJL6xk1TFuI6giY2pu2BzYSiEsKAyCSExr6UN0b9Q0vBxzJBNxXb5Sr8P/6Vbo3VX5OT8wXPCBHgejsc/gtodKBg5LksIoEDWYIh9JGh9s7sHbVQ8lfJupQM7UQHc38swivGLzGzISUIflkBv66VvYA80suMZWx3XXxG4ofwKgdtEbH3Z2lncjOIEKVCd61HZVsmv/4YK3v/3RuRaqxcAYLoj8k7mjvxCcYLSQHh6p8IkzG1BmId/eAE1bmzvlZX6X5YoOxwR6AXCe8AQuW2gE+9JlANL182+HW+pAZNy0G6oxJcZbhOhaLYZ8HEeGgIn5vd9uZzYvwQzKo68wyhzaJaB vbEmQMxc 0pzD1fJYvGdK7NN2G9ysgKet2V7Z7HivkiNgOplu8Z5ZxxAV5MCPqYGy94khyRQYKc2C7je2PrafAmxzV8CiaJA4JBU2XEaBEPo+FHR5D84uqob8rrfGJcm9a3sCcrxsVOiNe23kvBZBIgwH0w5Da8+yWu3psTsL3J9jz2yyNrgCu8JVozszJv+CoP5cpVmIUNQauGVG2pbRjiyJGWbdzY3dtSETrlhyFr20tAdu1tgYBqEgakcD0bMEn+ugzE4xbLy316zOidwVUc+d6rixQlvMwwR8xMocUwOVkHto6jPlwtvAjbnHdMuce/qSRF/yowbtfSzBrzvRTyD2mAkwQHVdiyEanHIvL+tmRpevQgj0n91K4svfd+xZz5HTkROG3st6sV80hYuibhMu+LE/25h41FccRjOD2zUuT1ejkOvbu4WbCKZVhyjTzySxUDmdT8Sk91ia2MfLmMRJCfud3DSVfk0ez+gmJZkPHMAgHxVjnQx74Ny+rBF0/uF9A7E1QxfDd3Tk4a3oyUasGPJj8UQUQUz+pLU95m4WEYUz76y/e2BM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 17:32, Dan Carpenter wrote: > The "reason" variable is uninitialized on this error path. It's supposed > to explain why the function failed. > > Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") > Signed-off-by: Dan Carpenter > --- > v2: I misunderstood the reason why the function was failing. Use the > correct reason. > > mm/memory_hotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 4d864b4fb891..e4009a44f883 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, > node_arg.nid = node; > ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); > ret = notifier_to_errno(ret); > - if (ret) > + if (ret) { > + reason = "node notifier failure"; > goto failed_removal_isolated; > + } > } > > ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg); Again, likely to be squashed :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb