Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation

[David Hildenbrand <david@redhat.com>]

On 10.07.25 08:04, Chi Zhiling wrote:
> From: Chi Zhiling <chizhiling@kylinos.cn>
> 
> folio_nr_pages() is faster helper function to get the number of pages
> when NR_PAGES_IN_LARGE_FOLIO is enabled.
> 
> Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
> ---
>   mm/readahead.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/readahead.c b/mm/readahead.c
> index 95a24f12d1e7..406756d34309 100644
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control *ractl,
>   	 * Ramp up sizes, and push forward the readahead window.
>   	 */
>   	expected = round_down(ra->start + ra->size - ra->async_size,
> -			1UL << folio_order(folio));
> +			folio_nr_pages(folio));
>   	if (index == expected) {
>   		ra->start += ra->size;
>   		/*

This should probably get squashed in Ryans commit?

LGTM

-- 
Cheers,

David / dhildenb