From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57F7C83F1A for ; Fri, 11 Jul 2025 16:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D1D96B0099; Fri, 11 Jul 2025 12:16:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 782956B009A; Fri, 11 Jul 2025 12:16:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6715B6B009C; Fri, 11 Jul 2025 12:16:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B9CB6B0099 for ; Fri, 11 Jul 2025 12:16:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CC2BE160C20 for ; Fri, 11 Jul 2025 16:16:00 +0000 (UTC) X-FDA: 83652485280.18.CEA5990 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 3934320019 for ; Fri, 11 Jul 2025 16:15:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TSvrJguq; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752250558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4PdbUTlAoNvyMFKR6OePMk99FSDqKOEu6bezLg3CZ0=; b=Yxp1RHZFA0joMN3yRvscn35Hk9raEZpPBEdvw7OG2zY/iQNfSrbJogewIPpq8EAfsXS49D ENbA/3NnfS8b6s8e9VBg+UZOXe8CfLi1VtyNxlnRBlnmaDvAUP/QxXIYmRc9Z4TLjK1R5N o+wuy/1ssp8n+YvMazqY2yUwwuPgXqg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TSvrJguq; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752250558; a=rsa-sha256; cv=none; b=ASNQL/IUrtOPk9xqqUROSQEBvVm+lSf47d4igoKbNCAuZ5drkDh3zQchO+MhvSm3ucYWQ1 icwxMqagd0xfdNTht6ZNm25Ymx0TyDtWvzKXyCEFESWtj6aZy210ekslpZdoK0PndXkY19 TbduYczOVP7P+BPOVW0DUSC75gpEG3Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752250557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B4PdbUTlAoNvyMFKR6OePMk99FSDqKOEu6bezLg3CZ0=; b=TSvrJguq8OScg/QqQqOLgPS3rcai0efWVL8s7Ygn7X0Fy77U5QxlkgkyeCJaFyU64DmC2S kZarP+Kp9UwPKaSnhYuH6XtEe/kT9EIKGCK3KCjMu1xarbShukqzI0s+e7hMckxOw67mcC Xrg3tlbeaWe3EqEGvf4C+1zZZnHvnuc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-FTqD5IeWO--NErKDXxFTSg-1; Fri, 11 Jul 2025 12:15:56 -0400 X-MC-Unique: FTqD5IeWO--NErKDXxFTSg-1 X-Mimecast-MFC-AGG-ID: FTqD5IeWO--NErKDXxFTSg_1752250555 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-455e9daab1cso2062895e9.1 for ; Fri, 11 Jul 2025 09:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752250555; x=1752855355; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B4PdbUTlAoNvyMFKR6OePMk99FSDqKOEu6bezLg3CZ0=; b=PXh0Q7af1lCh9zu6hD/l6pB0rTKfeCKaaNjK/J5Gx9M4sHbQ/Vpni0LXN2HmYRWaeS SpkFNvL+10P0ycKJSfQmX2RiGb9iv2p0IcxGVoWDKKv8Pi08TAmDFSRGPpIoeDo3LaWR kaxKY9Fa8buI/+vYwJ4pPJuu8ka308ed+tOhlLaCg95HjwZBSKB0+B6lmo1b6YQdRCby SaT03tMwWXulVGcJYje7XNrD2I8PGfegnGK/L9kYUE7FD/DqgtUiNiJSRdhy8qfM03zq NfKgCLFzpVA6rO3SbHRXROquHvOPdeGp5MyEAnOyu1Mi3tcTUeO75d8niWaItjhpLCnx QCYQ== X-Forwarded-Encrypted: i=1; AJvYcCU/ukJ3Xq9wqq+mF/LoIxe0paK0sg+kFOut5KvGS3YSvnCNJmqMdz/UQHKgfju8CbO15OgwSwboug==@kvack.org X-Gm-Message-State: AOJu0YwdN8A6PLrwQepJ2bSAbNR8xmKBWAAxpt5bKoYSxMH08Do8BLlH nYWN8AXNEphY31Ubh1EToEdTzygds5UYMImXqVNqDdn1bJgMtmx1blt6w21OSbAnjOx0xnRtx+U c9YtAHZVBPP4Z3CEPZyl97wgmdVkxb2quDt0EElkU0rbVTdtO/Hr8 X-Gm-Gg: ASbGncs13ck6OnBUmLFcIMcDO5jGwVhMgsagw45ON0V9rnYL2r8LIf7VJ1nOU22paYU GF1WuEHG8I/uNcA9A8lEXoRZZghDRVHPTALD29L3C1M5g4b7j74FwLpNOaykRJw5elQkJTCWoQU UzCxoBsjDRuIh3XGPvUCk6QuhAop2joPF6OPQ+Ybtkj/sv0Fwr38A08RRFgEnsZ8srcNEv+8OfM v7pOCIE/eDCYnyBHX2UygBErVApUd4ToY6Sk/nQwLEePatYMVS6fSnTaGmsc5HtPntGJ7AY2P9W jEw5Z7/RHYBnJuZ7WlNuOyt/TFZjV8wtgtZ8ZEbmNvdgA5Dtmm/uotwapdr4vKhrinLkW8FboY+ 3moolSp9SOXmVESRUrLYeiWAvaCKnLb7YxNSk38tIReEutL63tgXnjOcaK/vo87JDiOY= X-Received: by 2002:a05:600c:4684:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-454ec276b88mr40690175e9.18.1752250554849; Fri, 11 Jul 2025 09:15:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1a5E76BIpgezsbveDVnmxTjzk9mC3/6Cc7fl4zhaGnS7tXf6VRuARN3jKkYuVE7SAT26gyA== X-Received: by 2002:a05:600c:4684:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-454ec276b88mr40689655e9.18.1752250554433; Fri, 11 Jul 2025 09:15:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d5f5sm4888486f8f.56.2025.07.11.09.15.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 09:15:54 -0700 (PDT) Message-ID: <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> Date: Fri, 11 Jul 2025 18:15:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation To: Chi Zhiling , willy@infradead.org, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling , Ryan Roberts References: <20250710060451.3535957-1-chizhiling@163.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250710060451.3535957-1-chizhiling@163.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0WCBZ1Ay09ZHdXJN4JCwTf2uCWMs0KlRDPeoDXMNmWw_1752250555 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3934320019 X-Stat-Signature: ux1r78b3x6qsbwnmmuha1b59sjj7seb4 X-Rspam-User: X-HE-Tag: 1752250558-278288 X-HE-Meta: U2FsdGVkX19xtTnrBQk7rjCcy/Gk2VtTsfL2uhqHcijBJSbYCJqIbiN8kHG4wccvwVNum3b67+klG0Totc4ufTAnfa5hDbHtjs11mNUcJQcOQnCT9DXJZu3GKqzgB29mwTi8XUOX/W+emz4wFh9O1vJDA45PT76nLfmiNWc6a9kdutucTM6BCaPL9watrbpIJ24aIpBOrwUO3fSLfGN06wxbex50c4k7Y9YU+vLAb8M1lGDTlZQlFoGY1wEhRqGRsQvrT576zd7TULifFbUW5lGjo8wTACU4y0KjzROpuGOhOtyJkPe6BCmT4CjHSkp2SAUZFrIfWHfyYsSxUP37/mqHpHLGamJarMvNRz6W5ZCHy4xN6ouh20FOOevepMhYHqBgkaqLFCI44WkX4OWUY8i70UyadUauUr+D2eNRwAjD7EFtf6ChZWOWCKvihZOvKC8KXYpxd3nnK/LwYbr4UgsW/SFVECnamnox9NFI1Jheh9u12owgf72L3rdqEVXRaywKw2OMnN96uCNMVirv2l8E5LoxaFmH3iF8sAtEZ8xakebSB/skD7MMObtX5nnRQjX2BSGkA2Y7KBmqFpSvsVWrhepZc9bndN4oa7A22F52+YiqWlyDTRAwVSnEAGZOf8lsWcSDBrD+P86ICOC6pxTU6uuJ+HEzCM3PbAoMwiJdK7nsLOd7a3nz2QouEkhAFYZWDb/kFm4Ofj7OlR+J+pMLdyQslceHi2Foy9CnYGcYFeACBJ5FpYkRuGFyoQ46gHnIOb+QhGuxs3JsG/kB5/CQFTsADuvxnNTAS+qh5g7tk3xBTiE7Cjg3/VT8SGI8EKyecPzPl/U6gVuirLczHu6OgnrO818FkoWuPNGdxBWftPRFd4xpkje65IhNb/xZLtMwmSya03V4La1ftP9hPA5Y5AJ7Gq5EYSn+pwGZ1GnotWj1LGELVJA9Awl8gXb/+5UUcwvK3bjZsCYLBJr TlY4F1XO YEoNyGJICuVWn06UczD925k3lQJM9vqhGJa+WX1UvXcakpZWDG9ibZnx8lXCmgOngS9pZY7J2U6ogwYxguOnoD7BpQgdogO1PMwkCfQMwxhVzdRJB0PdPLes77RWBui3BrAdjLwYs8fZ641gqbM7sLCFLRsEJoy7mk6CtFzAolHvbONJzeajeQac3ryE4e+VHMX8aaFddbaobiigCUbbLlwG/47e/S9nglnrf/RdXDedvbobR1822UdNoIJnQuvpk7KGy29R/mEkk60JSl31oNo2/ppnAhdekysdiUpYc8GtGFcj3+o+KeKfNk+X/0JqEYpCoq9rcK6bsL7lNAfWQw1/dGS2rnBTdxym0h6vZ0QPGHEKqlRi1Y/LhFUopjo/blnlt+ti4HZQH96x+SMPZyRztNtUntOw/5yooE74jWb/7v4HsKaLNrL/NKGP4G9kMbwdLbxyCDLzf4MwX7lwgcPTxwUDozoGgnI4n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.07.25 08:04, Chi Zhiling wrote: > From: Chi Zhiling > > folio_nr_pages() is faster helper function to get the number of pages > when NR_PAGES_IN_LARGE_FOLIO is enabled. > > Signed-off-by: Chi Zhiling > --- > mm/readahead.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 95a24f12d1e7..406756d34309 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control *ractl, > * Ramp up sizes, and push forward the readahead window. > */ > expected = round_down(ra->start + ra->size - ra->async_size, > - 1UL << folio_order(folio)); > + folio_nr_pages(folio)); > if (index == expected) { > ra->start += ra->size; > /* This should probably get squashed in Ryans commit? LGTM -- Cheers, David / dhildenb