From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <47B6A680.9040307@cs.helsinki.fi> Date: Sat, 16 Feb 2008 11:01:52 +0200 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [patch 4/8] slub: Update statistics handling for variable order slabs References: <20080215230811.635628223@sgi.com> <20080215230853.942719945@sgi.com> In-Reply-To: <20080215230853.942719945@sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Mel Gorman , linux-mm@kvack.org List-ID: Christoph Lameter wrote: > Change the statistics to consider that slabs of the same slabcache > can have different number of objects in them since they may be of > different order. > > Provide a new sysfs field > > total_objects > > which shows the total objects that the allocated slabs of a slabcache > could hold. > > Update the description of the objects field in the kmem_cache structure. > Its role is now to be the limit of the maximum number of objects per slab > if a slab is allocated with the largest possible order. > > Signed-off-by: Christoph Lameter > > @@ -70,7 +71,7 @@ struct kmem_cache { > struct kmem_cache_node local_node; > > /* Allocation and freeing of slabs */ > - int objects; /* Number of objects in slab */ > + int objects; /* Number of objects in a slab of maximum size */ So why not rename this to max_objects then so we can reuse objects for objects0? Rest of the patch looks good to me. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org