Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

[Balbir Singh <balbir@linux.vnet.ibm.com>]

John Stoffel wrote:
> I know this is a pedantic comment, but why the heck is it called such
> a generic term as "Memory Controller" which doesn't give any
> indication of what it does.
> 
> Shouldn't it be something like "Memory Quota Controller", or "Memory
> Limits Controller"?
> 

It's called the memory controller since it controls the amount of memory that a
user can allocate (via limits). The generic term for any resource manager
plugged into cgroups is a controller. If you look through some of the references
in the document, we've listed our plans to support other categories of memory as
well. Hence it's called a memory controller

> Also, the Kconfig name "CGROUP_MEM_CONT" is just wrong, it should be
> "CGROUP_MEM_CONTROLLER", just spell it out so it's clear what's up.
> 

This has some history as well. Control groups was called containers earlier.
That way a name like CGROUP_MEM_CONT could stand for cgroup memory container or
cgroup memory controller.

> It took me a bunch of reading of Documentation/controllers/memory.txt
> to even start to understand what the purpose of this was.  The
> document could also use a re-writing to include a clear introduction
> at the top to explain "what" a memory controller is.  
> 
> Something which talks about limits, resource management, quotas, etc
> would be nice.  
> 


The references, specially reference [1] contains a lot of details on limits,
guarantees, etc.  Since they've been documented in the past on lkml, I decided
to keep them out of the documentation and mention them as references. If it's
going to help to add that terminology; I can create another document describing
what resource management means and what the commonly used terms mean.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>