From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <47BF2C73.4030308@cs.helsinki.fi> Date: Fri, 22 Feb 2008 22:11:31 +0200 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [2.6 patch] mm/slub.c: remove unneeded NULL check References: <20080219224922.GO31955@cs181133002.pp.htv.fi> <6f8gTuy3.1203515564.2078250.penberg@cs.helsinki.fi> <20080222195905.GM1409@cs181133002.pp.htv.fi> In-Reply-To: <20080222195905.GM1409@cs181133002.pp.htv.fi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Adrian Bunk Cc: clameter@sgi.com, mpm@selenic.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" List-ID: Adrian Bunk wrote: > There's no reason for checking c->freelist for being NULL here (and we'd > anyway Oops below if it was). > > Signed-off-by: Adrian Bunk > > --- > dae2a3c60f258f3ad2522b85d79b735a89d702f0 diff --git a/mm/slub.c b/mm/slub.c > index 74c65af..072e0a6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1404,8 +1404,7 @@ static void deactivate_slab(struct kmem_cache *s, struct kmem_cache_cpu *c) > struct page *page = c->page; > int tail = 1; > > - if (c->freelist) > - stat(c, DEACTIVATE_REMOTE_FREES); > + stat(c, DEACTIVATE_REMOTE_FREES); > /* > * Merge cpu freelist into freelist. Typically we get here > * because both freelists are empty. So this is unlikely Christoph, please apply. Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org